| Message ID | 20180211093607.27351-30-armbru@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 02/11/2018 03:36 AM, Markus Armbruster wrote: > We used to generate first test and later QGA QAPI code into > qapi-generated/. Commit b93b63f574 moved the test code to tests/. > Commit 54c2e50205 moved the QGA code to qga/qapi-generated/. The > directory has been unused since. > > Signed-off-by: Markus Armbruster <armbru@redhat.com> > --- > .gitignore | 1 - > Makefile | 1 - > configure | 1 - > 3 files changed, 3 deletions(-) Reviewed-by: Eric Blake <eblake@redhat.com>
On Sun, Feb 11, 2018 at 10:36 AM, Markus Armbruster <armbru@redhat.com> wrote: > We used to generate first test and later QGA QAPI code into > qapi-generated/. Commit b93b63f574 moved the test code to tests/. > Commit 54c2e50205 moved the QGA code to qga/qapi-generated/. The > directory has been unused since. > > Signed-off-by: Markus Armbruster <armbru@redhat.com> good catch, Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > .gitignore | 1 - > Makefile | 1 - > configure | 1 - > 3 files changed, 3 deletions(-) > > diff --git a/.gitignore b/.gitignore > index dabfe6bea8..4055e12ee8 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -27,7 +27,6 @@ > /libuser > /linux-headers/asm > /qga/qapi-generated > -/qapi-generated > /qapi-gen-timestamp > /qapi/qapi-builtin-types.[ch] > /qapi/qapi-builtin-visit.[ch] > diff --git a/Makefile b/Makefile > index 84411ee6ab..7eb1ede6f4 100644 > --- a/Makefile > +++ b/Makefile > @@ -726,7 +726,6 @@ clean: > rm -f trace/generated-tracers-dtrace.h* > rm -f $(foreach f,$(GENERATED_FILES),$(f) $(f)-timestamp) > rm -f qapi-gen-timestamp > - rm -rf qapi-generated > rm -rf qga/qapi-generated > for d in $(ALL_SUBDIRS); do \ > if test -d $$d; then $(MAKE) -C $$d $@ || exit 1; fi; \ > diff --git a/configure b/configure > index 62562f08cf..f564a1639e 100755 > --- a/configure > +++ b/configure > @@ -7015,7 +7015,6 @@ DIRS="tests tests/tcg tests/tcg/cris tests/tcg/lm32 tests/libqos tests/qapi-sche > DIRS="$DIRS docs docs/interop fsdev scsi" > DIRS="$DIRS pc-bios/optionrom pc-bios/spapr-rtas pc-bios/s390-ccw" > DIRS="$DIRS roms/seabios roms/vgabios" > -DIRS="$DIRS qapi-generated" > FILES="Makefile tests/tcg/Makefile qdict-test-data.txt" > FILES="$FILES tests/tcg/cris/Makefile tests/tcg/cris/.gdbinit" > FILES="$FILES tests/tcg/lm32/Makefile tests/tcg/xtensa/Makefile po/Makefile" > -- > 2.13.6 >
Quoting Markus Armbruster (2018-02-11 03:36:07) > We used to generate first test and later QGA QAPI code into > qapi-generated/. Commit b93b63f574 moved the test code to tests/. > Commit 54c2e50205 moved the QGA code to qga/qapi-generated/. The > directory has been unused since. > > Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com> > --- > .gitignore | 1 - > Makefile | 1 - > configure | 1 - > 3 files changed, 3 deletions(-) > > diff --git a/.gitignore b/.gitignore > index dabfe6bea8..4055e12ee8 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -27,7 +27,6 @@ > /libuser > /linux-headers/asm > /qga/qapi-generated > -/qapi-generated > /qapi-gen-timestamp > /qapi/qapi-builtin-types.[ch] > /qapi/qapi-builtin-visit.[ch] > diff --git a/Makefile b/Makefile > index 84411ee6ab..7eb1ede6f4 100644 > --- a/Makefile > +++ b/Makefile > @@ -726,7 +726,6 @@ clean: > rm -f trace/generated-tracers-dtrace.h* > rm -f $(foreach f,$(GENERATED_FILES),$(f) $(f)-timestamp) > rm -f qapi-gen-timestamp > - rm -rf qapi-generated > rm -rf qga/qapi-generated > for d in $(ALL_SUBDIRS); do \ > if test -d $$d; then $(MAKE) -C $$d $@ || exit 1; fi; \ > diff --git a/configure b/configure > index 62562f08cf..f564a1639e 100755 > --- a/configure > +++ b/configure > @@ -7015,7 +7015,6 @@ DIRS="tests tests/tcg tests/tcg/cris tests/tcg/lm32 tests/libqos tests/qapi-sche > DIRS="$DIRS docs docs/interop fsdev scsi" > DIRS="$DIRS pc-bios/optionrom pc-bios/spapr-rtas pc-bios/s390-ccw" > DIRS="$DIRS roms/seabios roms/vgabios" > -DIRS="$DIRS qapi-generated" > FILES="Makefile tests/tcg/Makefile qdict-test-data.txt" > FILES="$FILES tests/tcg/cris/Makefile tests/tcg/cris/.gdbinit" > FILES="$FILES tests/tcg/lm32/Makefile tests/tcg/xtensa/Makefile po/Makefile" > -- > 2.13.6 >
diff --git a/.gitignore b/.gitignore index dabfe6bea8..4055e12ee8 100644 --- a/.gitignore +++ b/.gitignore @@ -27,7 +27,6 @@ /libuser /linux-headers/asm /qga/qapi-generated -/qapi-generated /qapi-gen-timestamp /qapi/qapi-builtin-types.[ch] /qapi/qapi-builtin-visit.[ch] diff --git a/Makefile b/Makefile index 84411ee6ab..7eb1ede6f4 100644 --- a/Makefile +++ b/Makefile @@ -726,7 +726,6 @@ clean: rm -f trace/generated-tracers-dtrace.h* rm -f $(foreach f,$(GENERATED_FILES),$(f) $(f)-timestamp) rm -f qapi-gen-timestamp - rm -rf qapi-generated rm -rf qga/qapi-generated for d in $(ALL_SUBDIRS); do \ if test -d $$d; then $(MAKE) -C $$d $@ || exit 1; fi; \ diff --git a/configure b/configure index 62562f08cf..f564a1639e 100755 --- a/configure +++ b/configure @@ -7015,7 +7015,6 @@ DIRS="tests tests/tcg tests/tcg/cris tests/tcg/lm32 tests/libqos tests/qapi-sche DIRS="$DIRS docs docs/interop fsdev scsi" DIRS="$DIRS pc-bios/optionrom pc-bios/spapr-rtas pc-bios/s390-ccw" DIRS="$DIRS roms/seabios roms/vgabios" -DIRS="$DIRS qapi-generated" FILES="Makefile tests/tcg/Makefile qdict-test-data.txt" FILES="$FILES tests/tcg/cris/Makefile tests/tcg/cris/.gdbinit" FILES="$FILES tests/tcg/lm32/Makefile tests/tcg/xtensa/Makefile po/Makefile"
We used to generate first test and later QGA QAPI code into qapi-generated/. Commit b93b63f574 moved the test code to tests/. Commit 54c2e50205 moved the QGA code to qga/qapi-generated/. The directory has been unused since. Signed-off-by: Markus Armbruster <armbru@redhat.com> --- .gitignore | 1 - Makefile | 1 - configure | 1 - 3 files changed, 3 deletions(-)