From patchwork Wed Feb 21 11:05:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 10231957 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 63E0D60209 for ; Wed, 21 Feb 2018 11:07:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 24F961FF2D for ; Wed, 21 Feb 2018 11:07:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 194BD28A85; Wed, 21 Feb 2018 11:07:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B011628A75 for ; Wed, 21 Feb 2018 11:07:20 +0000 (UTC) Received: from localhost ([::1]:60042 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eoSF5-0005DP-Oe for patchwork-qemu-devel@patchwork.kernel.org; Wed, 21 Feb 2018 06:07:19 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35260) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eoSDP-0003sW-3c for qemu-devel@nongnu.org; Wed, 21 Feb 2018 06:05:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eoSDJ-0006bI-06 for qemu-devel@nongnu.org; Wed, 21 Feb 2018 06:05:35 -0500 Received: from mail-wr0-x242.google.com ([2a00:1450:400c:c0c::242]:42327) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eoSDI-0006ax-NU for qemu-devel@nongnu.org; Wed, 21 Feb 2018 06:05:28 -0500 Received: by mail-wr0-x242.google.com with SMTP id k9so3264670wre.9 for ; Wed, 21 Feb 2018 03:05:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CyGDq8tNesS2rDqF6Ds44vPw+vKj1nIBkuNu1XbVG40=; b=VkTPdGtJe/1M9vIc7GJoC89idYA4hAowYN9ENn54H5xXt7U1Qo3N96ppDC1isPm2fH WEED3/wXsI3AGkMPPVPVj4f7hQyFzw+FE1xKzKdB8rfmEFBrUPlRwzR04to+jOhJfuK6 RK28zH0GoyFxQXjPbIeoNVXALRA/FJJDZovXQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CyGDq8tNesS2rDqF6Ds44vPw+vKj1nIBkuNu1XbVG40=; b=r1uVPthCtlsAiKapV1mdlrubX8XwnGZ36Qr+VE1zo300H2eDM/TeJ/lgODOYwCJyM1 f+Hrgece3eAbN20AqJ7MsoQltGn+KOx+YdizSnEiJjOBC6RtVkOZ2xftF46kcfr78mkZ aAn4y9mE8swjSjl51u9R6KcAJtKZPaEgVP0H54FLDmDDWh8jF23TRo/INqDCqMkRejaK i8IoKe3osbyR674dF+Y5YiIOOQ6G0/ak//iIqIYDM7CwuyyCEzpNqxepzpWcWli+nC0y WVOB+nwufkKEbg06ZbMNywECq4C+p3Zjv07W6W1qLKBWXkasfIvncAKRFrKeZ3b3mh3p dGyQ== X-Gm-Message-State: APf1xPBKZrRUSEFubXQtFqLY+furzWdrkU1mxjqpTPmfMEPGOU0d6Zyh u5f6mMbrNnwCfsQx6w5WTFIciA== X-Google-Smtp-Source: AH8x227UivOJbjeP0uonTmm73IeZA4qX+ieMWi369pOALF52WOEDre9BA74tljKOnVA7xPW3ehoImg== X-Received: by 10.28.149.8 with SMTP id x8mr1866297wmd.24.1519211127558; Wed, 21 Feb 2018 03:05:27 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id t14sm28929630wmc.23.2018.02.21.03.05.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Feb 2018 03:05:24 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 3584D3E025C; Wed, 21 Feb 2018 11:05:23 +0000 (GMT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: peter.maydell@linaro.org Date: Wed, 21 Feb 2018 11:05:02 +0000 Message-Id: <20180221110523.859-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180221110523.859-1-alex.bennee@linaro.org> References: <20180221110523.859-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::242 Subject: [Qemu-devel] [PULL 02/22] include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , qemu-devel@nongnu.org, Aurelien Jarno Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP It's not actively built and when enabled things fail to compile. I'm not sure the type-checking is really helping here. Seeing as we "own" our softfloat now lets remove the cruft. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/include/fpu/softfloat.h b/include/fpu/softfloat.h index d5e99667b6..52af1412de 100644 --- a/include/fpu/softfloat.h +++ b/include/fpu/softfloat.h @@ -103,32 +103,6 @@ enum { /*---------------------------------------------------------------------------- | Software IEC/IEEE floating-point types. *----------------------------------------------------------------------------*/ -/* Use structures for soft-float types. This prevents accidentally mixing - them with native int/float types. A sufficiently clever compiler and - sane ABI should be able to see though these structs. However - x86/gcc 3.x seems to struggle a bit, so leave them disabled by default. */ -//#define USE_SOFTFLOAT_STRUCT_TYPES -#ifdef USE_SOFTFLOAT_STRUCT_TYPES -typedef struct { - uint16_t v; -} float16; -#define float16_val(x) (((float16)(x)).v) -#define make_float16(x) __extension__ ({ float16 f16_val = {x}; f16_val; }) -#define const_float16(x) { x } -typedef struct { - uint32_t v; -} float32; -/* The cast ensures an error if the wrong type is passed. */ -#define float32_val(x) (((float32)(x)).v) -#define make_float32(x) __extension__ ({ float32 f32_val = {x}; f32_val; }) -#define const_float32(x) { x } -typedef struct { - uint64_t v; -} float64; -#define float64_val(x) (((float64)(x)).v) -#define make_float64(x) __extension__ ({ float64 f64_val = {x}; f64_val; }) -#define const_float64(x) { x } -#else typedef uint16_t float16; typedef uint32_t float32; typedef uint64_t float64; @@ -141,7 +115,6 @@ typedef uint64_t float64; #define const_float16(x) (x) #define const_float32(x) (x) #define const_float64(x) (x) -#endif typedef struct { uint64_t low; uint16_t high;