| Message ID | 20180223132311.26555-2-marcandre.lureau@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 02/23/18 14:23, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau <marcandre.lureau@redhat.com> > > Apparently, unnecessary. Avoids extra build dependency and churn. > > CC: Laszlo Ersek <lersek@redhat.com> > CC: Stefan Berger <stefanb@linux.vnet.ibm.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 2 -- > SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf | 1 - > 2 files changed, 3 deletions(-) > > diff --git a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c > index a7ae3354b5..3758fc6a41 100644 > --- a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c > +++ b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c > @@ -18,7 +18,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > #include <IndustryStandard/UefiTcgPlatform.h> > #include <Ppi/FirmwareVolumeInfo.h> > #include <Ppi/FirmwareVolumeInfo2.h> > -#include <Ppi/LockPhysicalPresence.h> > #include <Ppi/TpmInitialized.h> > #include <Ppi/FirmwareVolume.h> > #include <Ppi/EndOfPeiPhase.h> > @@ -44,7 +43,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > #include <Library/MemoryAllocationLib.h> > #include <Library/ReportStatusCodeLib.h> > #include <Library/ResetSystemLib.h> > -#include <Library/Tcg2PhysicalPresenceLib.h> > > #define PERF_ID_TCG2_PEI 0x3080 > > diff --git a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf > index f7b85444d9..bc910c3baf 100644 > --- a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf > +++ b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf > @@ -58,7 +58,6 @@ > PerformanceLib > MemoryAllocationLib > ReportStatusCodeLib > - Tcg2PhysicalPresenceLib > ResetSystemLib > > [Guids] > Good catch. Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jiewen.yao@intel.com > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > marcandre.lureau@redhat.com > Sent: Friday, February 23, 2018 9:23 PM > To: edk2-devel@lists.01.org > Cc: qemu-devel@nongnu.org; javierm@redhat.com; pjones@redhat.com; Yao, > Jiewen <jiewen.yao@intel.com>; lersek@redhat.com > Subject: [edk2] [PATCH 1/7] SecurityPkg/Tcg2Pei: drop Tcg2PhysicalPresenceLib > dependency > > From: Marc-André Lureau <marcandre.lureau@redhat.com> > > Apparently, unnecessary. Avoids extra build dependency and churn. > > CC: Laszlo Ersek <lersek@redhat.com> > CC: Stefan Berger <stefanb@linux.vnet.ibm.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 2 -- > SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf | 1 - > 2 files changed, 3 deletions(-) > > diff --git a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c > b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c > index a7ae3354b5..3758fc6a41 100644 > --- a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c > +++ b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c > @@ -18,7 +18,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY > KIND, EITHER EXPRESS OR IMPLIED. > #include <IndustryStandard/UefiTcgPlatform.h> > #include <Ppi/FirmwareVolumeInfo.h> > #include <Ppi/FirmwareVolumeInfo2.h> > -#include <Ppi/LockPhysicalPresence.h> > #include <Ppi/TpmInitialized.h> > #include <Ppi/FirmwareVolume.h> > #include <Ppi/EndOfPeiPhase.h> > @@ -44,7 +43,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY > KIND, EITHER EXPRESS OR IMPLIED. > #include <Library/MemoryAllocationLib.h> > #include <Library/ReportStatusCodeLib.h> > #include <Library/ResetSystemLib.h> > -#include <Library/Tcg2PhysicalPresenceLib.h> > > #define PERF_ID_TCG2_PEI 0x3080 > > diff --git a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf > b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf > index f7b85444d9..bc910c3baf 100644 > --- a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf > +++ b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf > @@ -58,7 +58,6 @@ > PerformanceLib > MemoryAllocationLib > ReportStatusCodeLib > - Tcg2PhysicalPresenceLib > ResetSystemLib > > [Guids] > -- > 2.16.1.73.g5832b7e9f2 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel
On 02/24/18 01:09, Yao, Jiewen wrote: > Reviewed-by: Jiewen.yao@intel.com Given that Jiewen co-maintains SecurityPkg as of commit 3db2823f1e27 ("Maintainers.txt: Add Jiewen to be co-maintainer of SecurityPkg.", 2018-03-02), I pushed this patch in isolation: commit a39e72267034. However, Marc-André, something seems to be wrong with the way you formatted the patch. The patch email is base64 encoded (which I guess shouldn't be a problem per se), and I had to pass "--ignore-whitespace" to git-am. It means that the *context* lines in your patch didn't have the correct CRLF terminators. That seems very strange because the files being modified are fully CRLF (I checked). The git settings that I personally recommend to edk2 contributors are written up here: https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers Also, if you could push every version of the patch set to a separate branch in your public edk2 clone (e.g. on github, or elsewhere), that would be great -- please just mark the repo URL and the branch name in the cover letter of that version, when you post it. Thanks! Laszlo >> -----Original Message----- >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >> marcandre.lureau@redhat.com >> Sent: Friday, February 23, 2018 9:23 PM >> To: edk2-devel@lists.01.org >> Cc: qemu-devel@nongnu.org; javierm@redhat.com; pjones@redhat.com; Yao, >> Jiewen <jiewen.yao@intel.com>; lersek@redhat.com >> Subject: [edk2] [PATCH 1/7] SecurityPkg/Tcg2Pei: drop Tcg2PhysicalPresenceLib >> dependency >> >> From: Marc-André Lureau <marcandre.lureau@redhat.com> >> >> Apparently, unnecessary. Avoids extra build dependency and churn. >> >> CC: Laszlo Ersek <lersek@redhat.com> >> CC: Stefan Berger <stefanb@linux.vnet.ibm.com> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> >> --- >> SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 2 -- >> SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf | 1 - >> 2 files changed, 3 deletions(-) >> >> diff --git a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c >> b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c >> index a7ae3354b5..3758fc6a41 100644 >> --- a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c >> +++ b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c >> @@ -18,7 +18,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY >> KIND, EITHER EXPRESS OR IMPLIED. >> #include <IndustryStandard/UefiTcgPlatform.h> >> #include <Ppi/FirmwareVolumeInfo.h> >> #include <Ppi/FirmwareVolumeInfo2.h> >> -#include <Ppi/LockPhysicalPresence.h> >> #include <Ppi/TpmInitialized.h> >> #include <Ppi/FirmwareVolume.h> >> #include <Ppi/EndOfPeiPhase.h> >> @@ -44,7 +43,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY >> KIND, EITHER EXPRESS OR IMPLIED. >> #include <Library/MemoryAllocationLib.h> >> #include <Library/ReportStatusCodeLib.h> >> #include <Library/ResetSystemLib.h> >> -#include <Library/Tcg2PhysicalPresenceLib.h> >> >> #define PERF_ID_TCG2_PEI 0x3080 >> >> diff --git a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf >> b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf >> index f7b85444d9..bc910c3baf 100644 >> --- a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf >> +++ b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf >> @@ -58,7 +58,6 @@ >> PerformanceLib >> MemoryAllocationLib >> ReportStatusCodeLib >> - Tcg2PhysicalPresenceLib >> ResetSystemLib >> >> [Guids] >> -- >> 2.16.1.73.g5832b7e9f2 >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >
diff --git a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c index a7ae3354b5..3758fc6a41 100644 --- a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c +++ b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c @@ -18,7 +18,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. #include <IndustryStandard/UefiTcgPlatform.h> #include <Ppi/FirmwareVolumeInfo.h> #include <Ppi/FirmwareVolumeInfo2.h> -#include <Ppi/LockPhysicalPresence.h> #include <Ppi/TpmInitialized.h> #include <Ppi/FirmwareVolume.h> #include <Ppi/EndOfPeiPhase.h> @@ -44,7 +43,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. #include <Library/MemoryAllocationLib.h> #include <Library/ReportStatusCodeLib.h> #include <Library/ResetSystemLib.h> -#include <Library/Tcg2PhysicalPresenceLib.h> #define PERF_ID_TCG2_PEI 0x3080 diff --git a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf index f7b85444d9..bc910c3baf 100644 --- a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf +++ b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf @@ -58,7 +58,6 @@ PerformanceLib MemoryAllocationLib ReportStatusCodeLib - Tcg2PhysicalPresenceLib ResetSystemLib [Guids]