diff mbox

net/slirp: Convert atoi to qemu_strtoi to allow error checking

Message ID 20180316143921.30780-1-nia.alarie@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Nia Alarie March 16, 2018, 2:39 p.m. UTC 
Signed-off-by: Nia Alarie <nia.alarie@gmail.com>
---
 net/slirp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Samuel Thibault March 16, 2018, 5:09 p.m. UTC | #1 
Nia Alarie, on ven. 16 mars 2018 14:39:21 +0000, wrote:
> Signed-off-by: Nia Alarie <nia.alarie@gmail.com>

Applied to my tree, thanks!

> ---
>  net/slirp.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/net/slirp.c b/net/slirp.c
> index 8991816bbf..e938944bd4 100644
> --- a/net/slirp.c
> +++ b/net/slirp.c
> @@ -486,7 +486,9 @@ void hmp_hostfwd_remove(Monitor *mon, const QDict *qdict)
>          goto fail_syntax;
>      }
>  
> -    host_port = atoi(p);
> +    if (qemu_strtoi(p, NULL, 10, &host_port)) {
> +        goto fail_syntax;
> +    }
>  
>      err = slirp_remove_hostfwd(s->slirp, is_udp, host_addr, host_port);
>  
> -- 
> 2.16.2
>
diff mbox

Patch

diff --git a/net/slirp.c b/net/slirp.c
index 8991816bbf..e938944bd4 100644
--- a/net/slirp.c
+++ b/net/slirp.c
@@ -486,7 +486,9 @@  void hmp_hostfwd_remove(Monitor *mon, const QDict *qdict)
         goto fail_syntax;
     }
 
-    host_port = atoi(p);
+    if (qemu_strtoi(p, NULL, 10, &host_port)) {
+        goto fail_syntax;
+    }
 
     err = slirp_remove_hostfwd(s->slirp, is_udp, host_addr, host_port);