From patchwork Thu May 3 09:19:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Edgar E. Iglesias" X-Patchwork-Id: 10377505 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1D49660327 for ; Thu, 3 May 2018 09:39:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 18CB22907B for ; Thu, 3 May 2018 09:39:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0B92029082; Thu, 3 May 2018 09:39:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, FSL_HELO_FAKE, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 77AE22907B for ; Thu, 3 May 2018 09:39:36 +0000 (UTC) Received: from localhost ([::1]:54936 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEAi7-0000Hx-KY for patchwork-qemu-devel@patchwork.kernel.org; Thu, 03 May 2018 05:39:35 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55115) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEAP0-0000w5-32 for qemu-devel@nongnu.org; Thu, 03 May 2018 05:19:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fEAOw-00053y-48 for qemu-devel@nongnu.org; Thu, 03 May 2018 05:19:50 -0400 Received: from mail-lf0-x243.google.com ([2a00:1450:4010:c07::243]:46727) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fEAOv-00053S-Sb for qemu-devel@nongnu.org; Thu, 03 May 2018 05:19:46 -0400 Received: by mail-lf0-x243.google.com with SMTP id v85-v6so24888137lfa.13 for ; Thu, 03 May 2018 02:19:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=nUDQr+O+OIQmi+7QZuQMl8kSBgdeLp6uKQpDahkvZR4=; b=jZAAkWM+jma1nn5DRovj63m576T/7N+z9e2yTe0s2M8pK25E6KK28K4y7oaBfgSGTb j8+k4xqnE84ZSK00/rmFm1BvlaJs8yvX8+2YeXOh+uaRE8Mx4S3Jg7eCFOYBbTrNyNlg dSoLcb3hE9IbRoDfE3hawBRSJ50wCQAM4A3EuLoO0xCYYXxxEInu+PWCTvB9F4rTtJZE GfY2W4tcxqChTIzYccE0c45B1tFKjovFn8LxCrh7dgKD0a5S7ZXlxr/l5n7dmC/7l2aV DospLwkY9f7g+LPJORq2hGmFSEcE4Kpszb2MZYqD4QITPeWVZ213KQ+PBrlF/5GqePx7 Grxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=nUDQr+O+OIQmi+7QZuQMl8kSBgdeLp6uKQpDahkvZR4=; b=V+QOBFdyDFeWvJIMrHsKIQDxfNO2vlDvki7pqeDzPUzs2ygeuXI7b3hPBUfydKg3D+ O4ibWJugntl/EZjxerniMXocinTOMdr4Ci+NQxFg44Nm2QUs27pRBgZzRKUW7itdqqFA 60slxdxIK748i6csT2icdnDCYSxCmlylLfu3KjjOXeNGPFNXOqmF/kNGyu+SfApjX2m7 7gtkqy25vbT3R4f6hULyk7cEaRI3CLISvaAU3wLBxKToRF89kF7WHDgiPtS1YSzGL2ok IUSf9UuaAMtUmOIt49C87vNZryq2e8g30zbjrUlsHKQHuQy+BAXMI8RYSpXUgiOe3B5B pFow== X-Gm-Message-State: ALQs6tCpmPkWLrhN+0UsqTHbhNvJCvbevlnCeANsqrMtUoW6rfv8O6Wm h9G7iIblRaGvE6Y5xX/F5z9ATg== X-Google-Smtp-Source: AB8JxZp2PBEDxrzrmIFCzBolpYBJlkIPrd+TpM4h8mKmU8TgE1deJcqPjszI/dmX1kbXuWp3rll3Dw== X-Received: by 2002:a19:14dd:: with SMTP id 90-v6mr13460765lfu.107.1525339184389; Thu, 03 May 2018 02:19:44 -0700 (PDT) Received: from gmail.com (81-231-232-130-no39.tbcn.telia.com. [81.231.232.130]) by smtp.gmail.com with ESMTPSA id k139-v6sm256236lfg.76.2018.05.03.02.19.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 May 2018 02:19:43 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org Date: Thu, 3 May 2018 11:19:05 +0200 Message-Id: <20180503091922.28733-13-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180503091922.28733-1-edgar.iglesias@gmail.com> References: <20180503091922.28733-1-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::243 Subject: [Qemu-devel] [PATCH v1 12/29] target-microblaze: Remove pointer indirection for ld/st addresses X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: edgar.iglesias@xilinx.com, peter.maydell@linaro.org, sai.pavan.boddu@xilinx.com, frasse.iglesias@gmail.com, alistair@alistair23.me, richard.henderson@linaro.org Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis --- target/microblaze/translate.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index daed0b7e1f..5cc53eb035 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -848,7 +848,7 @@ static void dec_imm(DisasContext *dc) dc->clear_imm = 0; } -static inline void compute_ldst_addr(DisasContext *dc, TCGv_i32 *t) +static inline void compute_ldst_addr(DisasContext *dc, TCGv_i32 t) { bool extimm = dc->tb_flags & IMM_FLAG; /* Should be set to true if r1 is used by loadstores. */ @@ -863,10 +863,10 @@ static inline void compute_ldst_addr(DisasContext *dc, TCGv_i32 *t) if (!dc->type_b) { /* If any of the regs is r0, return the value of the other reg. */ if (dc->ra == 0) { - tcg_gen_mov_i32(*t, cpu_R[dc->rb]); + tcg_gen_mov_i32(t, cpu_R[dc->rb]); return; } else if (dc->rb == 0) { - tcg_gen_mov_i32(*t, cpu_R[dc->ra]); + tcg_gen_mov_i32(t, cpu_R[dc->ra]); return; } @@ -874,27 +874,27 @@ static inline void compute_ldst_addr(DisasContext *dc, TCGv_i32 *t) stackprot = true; } - tcg_gen_add_i32(*t, cpu_R[dc->ra], cpu_R[dc->rb]); + tcg_gen_add_i32(t, cpu_R[dc->ra], cpu_R[dc->rb]); if (stackprot) { - gen_helper_stackprot(cpu_env, *t); + gen_helper_stackprot(cpu_env, t); } return; } /* Immediate. */ if (!extimm) { if (dc->imm == 0) { - tcg_gen_mov_i32(*t, cpu_R[dc->ra]); + tcg_gen_mov_i32(t, cpu_R[dc->ra]); return; } - tcg_gen_movi_i32(*t, (int32_t)((int16_t)dc->imm)); - tcg_gen_add_i32(*t, cpu_R[dc->ra], *t); + tcg_gen_movi_i32(t, (int32_t)((int16_t)dc->imm)); + tcg_gen_add_i32(t, cpu_R[dc->ra], t); } else { - tcg_gen_add_i32(*t, cpu_R[dc->ra], *(dec_alu_op_b(dc))); + tcg_gen_add_i32(t, cpu_R[dc->ra], *(dec_alu_op_b(dc))); } if (stackprot) { - gen_helper_stackprot(cpu_env, *t); + gen_helper_stackprot(cpu_env, t); } return; } @@ -929,7 +929,7 @@ static void dec_load(DisasContext *dc) t_sync_flags(dc); addr = tcg_temp_new_i32(); - compute_ldst_addr(dc, &addr); + compute_ldst_addr(dc, addr); /* * When doing reverse accesses we need to do two things. @@ -1041,7 +1041,7 @@ static void dec_store(DisasContext *dc) sync_jmpstate(dc); /* SWX needs a temp_local. */ addr = ex ? tcg_temp_local_new_i32() : tcg_temp_new_i32(); - compute_ldst_addr(dc, &addr); + compute_ldst_addr(dc, addr); if (ex) { /* swx */ TCGv_i32 tval;