From patchwork Thu May 3 18:21:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Marcel Apfelbaum X-Patchwork-Id: 10378879 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 833A06037D for ; Thu, 3 May 2018 18:26:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7171929225 for ; Thu, 3 May 2018 18:26:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 64C5629227; Thu, 3 May 2018 18:26:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E0B0D29225 for ; Thu, 3 May 2018 18:26:48 +0000 (UTC) Received: from localhost ([::1]:58196 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEIwK-0007JK-4y for patchwork-qemu-devel@patchwork.kernel.org; Thu, 03 May 2018 14:26:48 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53241) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEIqX-00023h-3w for qemu-devel@nongnu.org; Thu, 03 May 2018 14:20:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fEIqW-0008H3-2o for qemu-devel@nongnu.org; Thu, 03 May 2018 14:20:49 -0400 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:54103) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fEIqV-0008Go-S2 for qemu-devel@nongnu.org; Thu, 03 May 2018 14:20:48 -0400 Received: by mail-wm0-x241.google.com with SMTP id a67so440357wmf.3 for ; Thu, 03 May 2018 11:20:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=63TX3fZ7/Vg6SpCpbqc13PYWeelerkpZ2VhP7YDRphM=; b=ff/npLlAJzO/YAqQxZU3kZmjdEHE8cCyI9doIgisXKl6H+AqY7qGnwXewdL5+3ArPu ZuSmAbS4x7a0KIV0YlZnksgY4YyHD7YzOw5aH8l5NyNJUev0ovnJ8e3XsPpOnKx4piqX DwGV6I1VkjpoRE7sYSKcAD5zhQRN5MHNnPoPRzIlndeEpj2dowPTG9hzOxFK2wX9G1uU t+ToSNsCnV2Cr6kyW3IIndYzzE48XKDy33RPEBHFQUw1+HQe8Dx+nZyre2XJDpMmYYHE /B2mcB1Tj0vGbg/ZqPm/TLZZEL1YcmMu7KtMxkqqLobYx7ZpBX9NLxiJduScmzN9GtsY kRIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=63TX3fZ7/Vg6SpCpbqc13PYWeelerkpZ2VhP7YDRphM=; b=KhGLlWJCuHmy7euwiqqMACDYotX5LHR37j52BsALO5OABYzJqQrIA9McnGUiFdAIFt sEzcrsVHbhbgWx8KvgGSTcD8wN9yC1+AF+QoVHolqU5XK3eREcTxETfGVPM2+VSHaRrZ DogLw0G87CNWrF6NpYgXERZoxI/90sMXSk0VJTS87NiiUSH7u5JIAq1fufdfJ9m5JsLy eYzOIIcos6RCp4tVG+/iIlxSAMEdGs8hvs4gZgPdr5hNWmiv1xypdoD0FXDb4uZqaE/4 hSbL+4tzEl9KEWqzBX5tlk4ht/7ekZNUK2m9sR5uHNhQm0ZHjW+e69O4l1g1EUKmKsoC Rggw== X-Gm-Message-State: ALQs6tBu/KxhCG+/8csLMOyQs4rlA8p3aCN2iuiDxHutyVrtRmNxPtSh Vc4qiigyitR8474Wv1MzBQV7ng== X-Google-Smtp-Source: AB8JxZrdL0jhd1A0xhHKG71mkh8+PO2QVahnw4FL0f70ijsNkpisp0Vl+YhSuMOYQjOCX2YxlKCPDw== X-Received: by 10.28.118.9 with SMTP id r9mr17540193wmc.111.1525371646600; Thu, 03 May 2018 11:20:46 -0700 (PDT) Received: from localhost.localdomain ([176.228.154.53]) by smtp.gmail.com with ESMTPSA id w40-v6sm24388801wrc.69.2018.05.03.11.20.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 May 2018 11:20:46 -0700 (PDT) From: Marcel Apfelbaum To: qemu-devel@nongnu.org Date: Thu, 3 May 2018 21:21:19 +0300 Message-Id: <20180503182125.20310-3-marcel.apfelbaum@gmail.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180503182125.20310-1-marcel.apfelbaum@gmail.com> References: <20180503182125.20310-1-marcel.apfelbaum@gmail.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::241 Subject: [Qemu-devel] [PULL 2/8] hw/rdma: Fix possible usage of a NULL pointer X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, yuval.shaia@oracle.com, f4bug@amsat.org Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Coverity CID 1390586; The cq handle is provided by the guest and cannot be trusted to be previuosly allocated. Fix it by exiting the completion flow. Reported-by: Peter Maydell Signed-off-by: Marcel Apfelbaum Reviewed-by: Yuval Shaia Message-Id: <20180430200223.4119-3-marcel.apfelbaum@gmail.com> Reviewed-by: Philippe Mathieu-Daudé --- hw/rdma/vmw/pvrdma_qp_ops.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/rdma/vmw/pvrdma_qp_ops.c b/hw/rdma/vmw/pvrdma_qp_ops.c index 750ade6c31..99bb51111e 100644 --- a/hw/rdma/vmw/pvrdma_qp_ops.c +++ b/hw/rdma/vmw/pvrdma_qp_ops.c @@ -216,6 +216,7 @@ void pvrdma_cq_poll(RdmaDeviceResources *dev_res, uint32_t cq_handle) cq = rdma_rm_get_cq(dev_res, cq_handle); if (!cq) { pr_dbg("Invalid CQ# %d\n", cq_handle); + return; } rdma_backend_poll_cq(dev_res, &cq->backend_cq);