Message ID | 20180619014319.28272-35-mdroth@linux.vnet.ibm.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E9F8660244 for <patchwork-qemu-devel@patchwork.kernel.org>; Tue, 19 Jun 2018 02:32:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D6CCF28681 for <patchwork-qemu-devel@patchwork.kernel.org>; Tue, 19 Jun 2018 02:32:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CB55628C78; Tue, 19 Jun 2018 02:32:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 787C528681 for <patchwork-qemu-devel@patchwork.kernel.org>; Tue, 19 Jun 2018 02:32:47 +0000 (UTC) Received: from localhost ([::1]:38658 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org>) id 1fV6Rq-0004Xl-My for patchwork-qemu-devel@patchwork.kernel.org; Mon, 18 Jun 2018 22:32:46 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45783) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <flukshun@gmail.com>) id 1fV5hv-0001Xl-VK for qemu-devel@nongnu.org; Mon, 18 Jun 2018 21:45:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <flukshun@gmail.com>) id 1fV5hv-0008Nv-64 for qemu-devel@nongnu.org; Mon, 18 Jun 2018 21:45:20 -0400 Received: from mail-ot0-x234.google.com ([2607:f8b0:4003:c0f::234]:40174) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from <flukshun@gmail.com>) id 1fV5hv-0008Ni-0q; Mon, 18 Jun 2018 21:45:19 -0400 Received: by mail-ot0-x234.google.com with SMTP id w9-v6so20745241otj.7; Mon, 18 Jun 2018 18:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=m9CkoYxnJd1eWUMuB6qHUuNN/6NlP1kLtPCsZwLZ4oI=; b=TelHXugh3BQy+8H5T4ZxBs1zn44Gw2A2uBPVV1hEmAdsS+9L9Looh4Ovz2s/jbNv30 ZdJd4w6/K5jhN8DBqJOke5DbtgYTjg5cxU0KAw39SDPITKduUFeGZY9idB0HS/TYo+Mq ypkQIE8/eUVslQa/fzPOraMGzTOFbef/3mxKtztvfkbXhT0IKiVpdcb+PFoRyl+wekFL 2ySbw9cg9sSJERMXhlwwtx6rybr3Y/I7SmKC2IIDxhWLASvT54JfZDVXDDqqnc31GpZR UU/YqrdurM+Rdy+VdhteXEWDd2QAV3zdqIcQNEbKBC1/YR4SgCLfvCc59XETSTd9gNVj xXVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=m9CkoYxnJd1eWUMuB6qHUuNN/6NlP1kLtPCsZwLZ4oI=; b=XUr7CFV/UwciRo0RbuOmZkVtCA4dA5w2SlCf4Rv3U/9z1Ii+A4+Ub1R+UZEZ8ZGZLQ lhaLgTtuRZlgnZE7JjrybqBCvHEutWDEWmrPX5UKHK7UUHtvmHJ+FKO7MVz4ha44fpBN LJzWV29jKEaOWC6Yc8Hp97dDWpcUsnvgjtWM/MvX6QRrykdS4w1Vv4LY8nddPDTw6Ikz md2Qf5UOAEfuKY2nyzZcrvzf2/bCNj1XyscmXw/fx+hZRHqIA2GG3xn1Y68t12UF/NXZ RLO7bcUbQTbEYn5XDzrXMSfR6tF1G5fTgs1iLrp0jWmsT/FphYDWc+3C2UN4qdeiRCpF /keQ== X-Gm-Message-State: APt69E0Gu27Nkpunam28h7JRQJJqMFj67JHmM/B7GtuXFmG6td4Aa3c1 6nUdcki9NUQ9qzUXwTf8yKuMkqS0 X-Google-Smtp-Source: ADUXVKKDD2R6kOb9EG1btwIC/eOS04Jlv0M8yecjiTTSlZ++VbIRftCfESzFAh7lRKoKsh/cCiOD1A== X-Received: by 2002:a9d:43aa:: with SMTP id t42-v6mr9717510ote.327.1529372717855; Mon, 18 Jun 2018 18:45:17 -0700 (PDT) Received: from localhost (76-251-165-188.lightspeed.austtx.sbcglobal.net. [76.251.165.188]) by smtp.gmail.com with ESMTPSA id b63-v6sm7204106oia.4.2018.06.18.18.45.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Jun 2018 18:45:16 -0700 (PDT) From: Michael Roth <mdroth@linux.vnet.ibm.com> To: qemu-devel@nongnu.org Date: Mon, 18 Jun 2018 20:42:00 -0500 Message-Id: <20180619014319.28272-35-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180619014319.28272-1-mdroth@linux.vnet.ibm.com> References: <20180619014319.28272-1-mdroth@linux.vnet.ibm.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c0f::234 Subject: [Qemu-devel] [PATCH 034/113] memory: fix flatview_access_valid RCU read lock/unlock imbalance X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <qemu-devel.nongnu.org> List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe> List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/> List-Post: <mailto:qemu-devel@nongnu.org> List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help> List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=subscribe> Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-stable@nongnu.org, Peter Maydell <peter.maydell@linaro.org> Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org> X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/exec.c b/exec.c index d589283bdd..5f8017a5d7 100644 --- a/exec.c +++ b/exec.c @@ -3320,7 +3320,6 @@ static bool flatview_access_valid(FlatView *fv, hwaddr addr, int len, if (!memory_access_is_direct(mr, is_write)) { l = memory_access_size(mr, l, addr); if (!memory_region_access_valid(mr, xlat, l, is_write)) { - rcu_read_unlock(); return false; } }