From patchwork Tue Jun 19 04:48:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suraj Jitindar Singh X-Patchwork-Id: 10473125 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1A4F9601D7 for ; Tue, 19 Jun 2018 04:50:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0B5C228AB4 for ; Tue, 19 Jun 2018 04:50:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F318D28C05; Tue, 19 Jun 2018 04:50:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9668928AB4 for ; Tue, 19 Jun 2018 04:50:24 +0000 (UTC) Received: from localhost ([::1]:39385 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fV8b1-0003do-Gf for patchwork-qemu-devel@patchwork.kernel.org; Tue, 19 Jun 2018 00:50:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52897) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fV8Zi-00035N-2E for qemu-devel@nongnu.org; Tue, 19 Jun 2018 00:49:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fV8Ze-0004a7-Vl for qemu-devel@nongnu.org; Tue, 19 Jun 2018 00:49:02 -0400 Received: from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244]:34320) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fV8Ze-0004ZY-PH for qemu-devel@nongnu.org; Tue, 19 Jun 2018 00:48:58 -0400 Received: by mail-pg0-x244.google.com with SMTP id q4-v6so8573642pgr.1 for ; Mon, 18 Jun 2018 21:48:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=g0WUEC7Wa+Gbrs/0wDNBBuPKPbfb7KFmeOjnHThHf7o=; b=k7S4/ZtbnueqOSBi0LDpxN2Wp/f6BFsuedZYkXfnr+5fk3CZcnjqvDzr+EaLOZbGlV He3MCWaGw2XuNrkfflTbTQGxUoNKH4Vphm9obb1R+FPgYiwBapGqYbf/sRXXBxiaQ0ls bPll2mxr+q/w1vtiAbkaPpJ0UnJrM/Id5qqNJuXx/ZPJn/HbcN8Z13HMbvZ3me+ups6R MJZwYsgfQR3G2P7ruNvqrgQk79DdE2m8BxFgYxYFUVmv0G+2tiwR/YODef+pMNijibLH 1rC8nvdGwSSUYsHZ2amooFNf043B6TJZOCg6KIBTn1aGGNV3USnKR3VoIOdXRQOIQfQJ 929w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=g0WUEC7Wa+Gbrs/0wDNBBuPKPbfb7KFmeOjnHThHf7o=; b=Kl23TMFXltNGGJtV/6UvZ4m1O0Fp1/ROXhq8J+4iLVWuUR7v1HlhqivyBO94b23McH asAhzxVayoyeFN5nZ5jmjHigoNlMxBesJhikQiDW7P8coVHg2Yycu5PT5LAfUm1gnMm0 dQZM9mAq+ur44guzb+sgK16TalZQuidaRn2zvrKeOU6oNy4PHPvGivO/clpXcBZ3C1NC TvS6OE2+vMM3+g8nTB9S+Uygkpk94w4F78EzpVYQ4C2N5UxvaBbAt4kRlPIzd6mQaUT5 /9pN5W47IvS7cgumIIaCcmGdbLQel/3AAvnCzYGFaL0Aa82MbfWhhee1g2e+S7lhsHGh Fdeg== X-Gm-Message-State: APt69E33EGKeKHcYP/jOT7moyrlbADTkuqzH0hsiQmN8490jWWrcx2Qz YvhyylUPDiw3w2bE4TP2pHUnGUUy X-Google-Smtp-Source: ADUXVKKLtM0kNb62dJKGkn4cQPVsXlAha4tZLXX+ZPV/9mYbbIVU16jDPx94hsqMFNgGnJ3o8eOXFg== X-Received: by 2002:a62:c4dd:: with SMTP id h90-v6mr16618818pfk.86.1529383737427; Mon, 18 Jun 2018 21:48:57 -0700 (PDT) Received: from surajjs2.ozlabs.ibm.com ([122.99.82.10]) by smtp.gmail.com with ESMTPSA id a22-v6sm24396235pfi.124.2018.06.18.21.48.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Jun 2018 21:48:56 -0700 (PDT) From: Suraj Jitindar Singh To: qemu-devel@nongnu.org Date: Tue, 19 Jun 2018 14:48:35 +1000 Message-Id: <20180619044835.18795-1-sjitindarsingh@gmail.com> X-Mailer: git-send-email 2.13.6 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::244 Subject: [Qemu-devel] [PATCH] hmp-commands: use long for begin and length in dump-guest-memory X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Suraj Jitindar Singh , dgilbert@redhat.com, Suraj Jitindar Singh Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP The dump-guest-memory command is used to dump an area of guest memory to a file, the piece of memory is specified by a begin address and a length. These parameters are specified as ints and thus have a maximum value of 4GB. This means you can't dump the guest memory past the first 4GB and instead get: (qemu) dump-guest-memory tmp 0x100000000 0x100000000 'dump-guest-memory' has failed: integer is for 32-bit values Try "help dump-guest-memory" for more information This limitation is imposed in monitor_parse_arguments() since they are both ints. hmp_dump_guest_memory() uses 64 bit quantities to store both the begin and length values. Thus specify begin and length as long so that the entire guest memory space can be dumped. Signed-off-by: Suraj Jitindar Singh --- hmp-commands.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 0734fea931..3b5c1f65db 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1116,7 +1116,7 @@ ETEXI { .name = "dump-guest-memory", - .args_type = "paging:-p,detach:-d,zlib:-z,lzo:-l,snappy:-s,filename:F,begin:i?,length:i?", + .args_type = "paging:-p,detach:-d,zlib:-z,lzo:-l,snappy:-s,filename:F,begin:l?,length:l?", .params = "[-p] [-d] [-z|-l|-s] filename [begin length]", .help = "dump guest memory into file 'filename'.\n\t\t\t" "-p: do paging to get guest's memory mapping.\n\t\t\t"