| Message ID | 20180713173721.14915-1-jsnow@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Am 13.07.2018 um 19:37 hat John Snow geschrieben: > This test doesn't actually care about the format anyway, it just > supports "all formats" as a convenience. LUKS however does not use a > simple image filename which confuses this iotest. > > We can simply skip the test for formats that use IMGOPTSSYNTAX for > their filenames without missing much coverage. > > Signed-off-by: John Snow <jsnow@redhat.com> Thanks, applied to the block branch. Kevin
diff --git a/tests/qemu-iotests/226 b/tests/qemu-iotests/226 index 460aea2fc9..34987d43f9 100755 --- a/tests/qemu-iotests/226 +++ b/tests/qemu-iotests/226 @@ -41,6 +41,9 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 # Generic format, but tests file-protocol specific error handling _supported_fmt generic +if [ "$IMGOPTSSYNTAX" = "true" ]; then + _unsupported_fmt $IMGFMT +fi _supported_proto file _supported_os Linux
This test doesn't actually care about the format anyway, it just supports "all formats" as a convenience. LUKS however does not use a simple image filename which confuses this iotest. We can simply skip the test for formats that use IMGOPTSSYNTAX for their filenames without missing much coverage. Signed-off-by: John Snow <jsnow@redhat.com> --- V2: Test against IMGOPTSSYNTAX instead of 'luks' directly (Kevin) tests/qemu-iotests/226 | 3 +++ 1 file changed, 3 insertions(+)