From patchwork Mon Jul 23 20:16:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Roth X-Patchwork-Id: 10540903 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8AB2A112B for ; Mon, 23 Jul 2018 20:30:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 78A06283EE for ; Mon, 23 Jul 2018 20:30:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6D30A28492; Mon, 23 Jul 2018 20:30:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 18077283EE for ; Mon, 23 Jul 2018 20:30:36 +0000 (UTC) Received: from localhost ([::1]:36396 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhhTX-0004C1-3n for patchwork-qemu-devel@patchwork.kernel.org; Mon, 23 Jul 2018 16:30:35 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40873) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhhIU-0001cF-7Y for qemu-devel@nongnu.org; Mon, 23 Jul 2018 16:19:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fhhIQ-0002g9-1z for qemu-devel@nongnu.org; Mon, 23 Jul 2018 16:19:10 -0400 Received: from mail-oi0-x232.google.com ([2607:f8b0:4003:c06::232]:46730) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fhhIP-0002fe-Sq; Mon, 23 Jul 2018 16:19:05 -0400 Received: by mail-oi0-x232.google.com with SMTP id y207-v6so3451816oie.13; Mon, 23 Jul 2018 13:19:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=0tM492gYNuMQi7pxWmSX7LCNRIuEwmO87+NdvfrQF+Y=; b=fwaS+lgeLfK4h82I3C9y0Mp9TaqN3pa/ckR7/sgV/RodnbiHCUBFBcXu8m2oZCdV2V Vr4SLYf1U5B22CVjx9RIaS0CCZPfyzP/IIFLVg+789+BOOOgLbDjovovWLhi3UbEgypR h3oOwreouVmVlnzKDPnLTGWZjxLs3/WjjasUFz1As4wdxRERHiRfU5iJbCXaMAKYqFQ0 aUNHS9jBHJhmLSjdGMJrfJ53oqsrw+eKOa7Popxt6meMAdW8yFdzQdYF6nZl/Cf8bUKn 73qxHLxClAnOEQk2SyYcF1FBL/ApCSMgZBZeXwKFeL+NF88OzYmepz1mOkC0z5IysKMB nXiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=0tM492gYNuMQi7pxWmSX7LCNRIuEwmO87+NdvfrQF+Y=; b=IHty8hsxi5izgFvXFp12m9lw0Fl8EEB4VsPTxJINlqg2UsmNpLdGrYw6xzAvZm9AA9 f2gDqd155kP1qEThCqdUlhjSvBg7LifH2NObfTwUmVmXF+UFgQrNQZz3Dnk5lCcKnFCE rJLegIl6ZfaVydamaNE/bljyU+Cb1cR24uKL9vp1HzY0eEyMaUKWV7QuB1r9yFv9vZsM a0HPXpNZ71ZdQRRff7o+UDWnyFuB9NuREffx2F+JfgIjLILVF+5LX2HZbrfuaE1RwWD/ Mv9zfrOucrCNFka0NF4D2kpcydqHw0aoVxuEBUKf3DEkJnabx8nWHw0WrUksZe/CafEF 3m1g== X-Gm-Message-State: AOUpUlEFqCGwtjNRNx8akDzbtd5fB3ytjKfecFBDQEnMA9k4xDWWSSX2 YyP9LFqrr4tCc9A0w7P29Ek3sPcZj8c= X-Google-Smtp-Source: AAOMgpfWwUqCwrOSvgNEtqDnPnagTKfjVe+BQ1qu3BjSCfBwBHPJwriLNQd9p+yuQnV7tQiKykerkg== X-Received: by 2002:aca:f58f:: with SMTP id t137-v6mr322426oih.244.1532377144764; Mon, 23 Jul 2018 13:19:04 -0700 (PDT) Received: from localhost (76-251-165-188.lightspeed.austtx.sbcglobal.net. [76.251.165.188]) by smtp.gmail.com with ESMTPSA id f144-v6sm13105537oib.39.2018.07.23.13.19.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Jul 2018 13:19:03 -0700 (PDT) From: Michael Roth To: qemu-devel@nongnu.org Date: Mon, 23 Jul 2018 15:16:29 -0500 Message-Id: <20180723201748.25573-21-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180723201748.25573-1-mdroth@linux.vnet.ibm.com> References: <20180723201748.25573-1-mdroth@linux.vnet.ibm.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::232 Subject: [Qemu-devel] [PATCH 20/99] pc-bios/s390-ccw: struct tpi_info must be declared as aligned(4) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Cornelia Huck , qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Thomas Huth I've run into a compilation error today with the current version of GCC 8: In file included from s390-ccw.h:49, from main.c:12: cio.h:128:1: error: alignment 1 of 'struct tpi_info' is less than 4 [-Werror=packed-not-aligned] } __attribute__ ((packed)); ^ cc1: all warnings being treated as errors Since the struct tpi_info contains an element ("struct subchannel_id schid") which is marked as aligned(4), we've got to mark the struct tpi_info as aligned(4), too. CC: qemu-stable@nongnu.org Signed-off-by: Thomas Huth Message-Id: <1525774672-11913-1-git-send-email-thuth@redhat.com> Reviewed-by: Cornelia Huck Acked-by: Christian Borntraeger Signed-off-by: Cornelia Huck (cherry picked from commit a6e4385dea94850d7b06b0542e7960c1063fdabd) Signed-off-by: Michael Roth --- pc-bios/s390-ccw/cio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pc-bios/s390-ccw/cio.h b/pc-bios/s390-ccw/cio.h index 55eaeee4b6..1a0795f645 100644 --- a/pc-bios/s390-ccw/cio.h +++ b/pc-bios/s390-ccw/cio.h @@ -125,7 +125,7 @@ struct tpi_info { __u32 reserved3 : 12; __u32 int_type : 3; __u32 reserved4 : 12; -} __attribute__ ((packed)); +} __attribute__ ((packed, aligned(4))); /* channel command word (type 1) */ struct ccw1 {