From patchwork Mon Jul 23 20:17:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Roth X-Patchwork-Id: 10541115 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4B065112B for ; Mon, 23 Jul 2018 21:32:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3A95C2858A for ; Mon, 23 Jul 2018 21:32:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2D6B8285D9; Mon, 23 Jul 2018 21:32:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id CEBFF285CB for ; Mon, 23 Jul 2018 21:32:55 +0000 (UTC) Received: from localhost ([::1]:36809 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhiRq-0001V3-Sz for patchwork-qemu-devel@patchwork.kernel.org; Mon, 23 Jul 2018 17:32:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43470) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhhL9-0004M7-FV for qemu-devel@nongnu.org; Mon, 23 Jul 2018 16:21:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fhhL8-0005dn-K3 for qemu-devel@nongnu.org; Mon, 23 Jul 2018 16:21:55 -0400 Received: from mail-oi0-x241.google.com ([2607:f8b0:4003:c06::241]:37289) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fhhL8-0005dN-FZ; Mon, 23 Jul 2018 16:21:54 -0400 Received: by mail-oi0-x241.google.com with SMTP id k81-v6so3485786oib.4; Mon, 23 Jul 2018 13:21:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=ISv87QyZL4IXVgflJF8x7nhss/gySbFuvqHcd8Zg8uk=; b=bqcEBdZAZjQfevvOqNFP/ydGhrvAyao9vw2NRQMIKRudc/m6fULCV3GGUxTsLKZZCX c2MdLb3GsGHgBsZJTUZEJ8uWNjjx/+HLPh/CAQf7BaDjdwEoum4hzy3F+5bQenPu0aAt OAONgNpJ0TlSxYUzu61gbpCiDh/Cd6t77Iw5i01Sh5W0hIhVJVkeapGK0vqDzGn1tG5H JA7xoAifCuQcsgd4gGQPS3WJE2a3Sg/j3vQsykxJsCQTV+LPAkwTxh/DhC0Cxc0oIZID 9wBXMhxwx+dmbg/0JPAZKvAcpblNixmZ6kpi1ix9jm2kClUU0RY4f+2Q7HCpUxgSRrLh bxUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=ISv87QyZL4IXVgflJF8x7nhss/gySbFuvqHcd8Zg8uk=; b=ctIb5LbTTfAzAVhzzkYhc8nLlRxKsBJoLQvIZ9GSv3Luh0VFaayKM1W3c425cmtUzJ VTUZMWVUpRe+uzNESF80vq6E6USZaj20R7Iwc7xWNoSrX+gCqiUSkSsVsD3XZAIr2C6r t4LZHcaW3tLyQIh97vIc1z0HCrO4UMgRDPKk+nny1Rz9zY+DTUOu9wKZDUjPzFycsZYd YiXHODD/jGmqeHZn1wOEvWLZ+2JeAQ5W8Apunozo+LVq9A3SYc/zjpOYVdflWJhc6nUU vaZTyGE7akWgv5l4BLqEnSGym3cuGxPPrNgeTmHK4njHbbX8YebfZsk9ZlcBJXeL87TD Gv+A== X-Gm-Message-State: AOUpUlHRpg54xjM8SPcWqdvJvK+y/elO8A44XZGT+CQdY7BYSRlZgrek S8tgJ2GhqG1DYxoKzrtlt9MAy3sanx9g2Q== X-Google-Smtp-Source: AAOMgpedXcjI8oYzgOrbVTU4YGNZcaJB0Lepjg1paUtsSnpTiB7NkHwFetvRdmnoSaGPPzw7DPzb0Q== X-Received: by 2002:aca:b208:: with SMTP id b8-v6mr315442oif.144.1532377313376; Mon, 23 Jul 2018 13:21:53 -0700 (PDT) Received: from localhost (76-251-165-188.lightspeed.austtx.sbcglobal.net. [76.251.165.188]) by smtp.gmail.com with ESMTPSA id u144-v6sm8706925oie.14.2018.07.23.13.21.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Jul 2018 13:21:52 -0700 (PDT) From: Michael Roth To: qemu-devel@nongnu.org Date: Mon, 23 Jul 2018 15:17:39 -0500 Message-Id: <20180723201748.25573-91-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180723201748.25573-1-mdroth@linux.vnet.ibm.com> References: <20180723201748.25573-1-mdroth@linux.vnet.ibm.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::241 Subject: [Qemu-devel] [PATCH 90/99] vfio/pci: Default display option to "off" X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alex Williamson , qemu-stable@nongnu.org, Gerd Hoffmann Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Alex Williamson Commit a9994687cb9b ("vfio/display: core & wireup") added display support to vfio-pci with the default being "auto", which breaks existing VMs when the vGPU requires GL support but had no previous requirement for a GL compatible configuration. "Off" is the safer default as we impose no new requirements to VM configurations. Fixes: a9994687cb9b ("vfio/display: core & wireup") Cc: qemu-stable@nongnu.org Cc: Gerd Hoffmann Signed-off-by: Alex Williamson (cherry picked from commit 8151a9c56d31eeeea872b8103c8b86d03c411667) Signed-off-by: Michael Roth --- hw/vfio/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index b9bc6cd310..1a806ea684 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -3154,7 +3154,7 @@ static Property vfio_pci_dev_properties[] = { DEFINE_PROP_PCI_HOST_DEVADDR("host", VFIOPCIDevice, host), DEFINE_PROP_STRING("sysfsdev", VFIOPCIDevice, vbasedev.sysfsdev), DEFINE_PROP_ON_OFF_AUTO("display", VFIOPCIDevice, - display, ON_OFF_AUTO_AUTO), + display, ON_OFF_AUTO_OFF), DEFINE_PROP_UINT32("x-intx-mmap-timeout-ms", VFIOPCIDevice, intx.mmap_timeout, 1100), DEFINE_PROP_BIT("x-vga", VFIOPCIDevice, features,