| Message ID | 20180813022006.7216-2-mreitz@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mirror: Mainly coroutine refinements | expand |
On Mon, Aug 13, 2018 at 04:19:50AM +0200, Max Reitz wrote: > Currently, we never test whether we can read from the source while > mirroring (that means, whether we can read from the mirror BDS). Add > such a test to 156 because it fits well. > > Signed-off-by: Max Reitz <mreitz@redhat.com> Reviewed-by: Jeff Cody <jcody@redhat.com> > --- > tests/qemu-iotests/156 | 7 +++++++ > tests/qemu-iotests/156.out | 3 +++ > 2 files changed, 10 insertions(+) > > diff --git a/tests/qemu-iotests/156 b/tests/qemu-iotests/156 > index 0a9a09802e..99f7326158 100755 > --- a/tests/qemu-iotests/156 > +++ b/tests/qemu-iotests/156 > @@ -106,6 +106,13 @@ _send_qemu_cmd $QEMU_HANDLE \ > 'qemu-io source \"write -P 4 192k 64k\"' } }" \ > 'return' > > +# Read it back (proving that we can read while mirroring) > +_send_qemu_cmd $QEMU_HANDLE \ > + "{ 'execute': 'human-monitor-command', > + 'arguments': { 'command-line': > + 'qemu-io source \"read -P 4 192k 64k\"' } }" \ > + 'return' > + > # Copy source backing chain to the target before completing the job > cp "$TEST_IMG.backing" "$TEST_IMG.target.backing" > cp "$TEST_IMG" "$TEST_IMG.target" > diff --git a/tests/qemu-iotests/156.out b/tests/qemu-iotests/156.out > index 34c057b626..a591bd3a1e 100644 > --- a/tests/qemu-iotests/156.out > +++ b/tests/qemu-iotests/156.out > @@ -20,6 +20,9 @@ Formatting 'TEST_DIR/t.IMGFMT.target.overlay', fmt=IMGFMT size=1048576 backing_f > wrote 65536/65536 bytes at offset 196608 > 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > {"return": ""} > +read 65536/65536 bytes at offset 196608 > +64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > +{"return": ""} > {"return": {}} > {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "waiting", "id": "source"}} > {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "pending", "id": "source"}} > -- > 2.17.1 >
diff --git a/tests/qemu-iotests/156 b/tests/qemu-iotests/156 index 0a9a09802e..99f7326158 100755 --- a/tests/qemu-iotests/156 +++ b/tests/qemu-iotests/156 @@ -106,6 +106,13 @@ _send_qemu_cmd $QEMU_HANDLE \ 'qemu-io source \"write -P 4 192k 64k\"' } }" \ 'return' +# Read it back (proving that we can read while mirroring) +_send_qemu_cmd $QEMU_HANDLE \ + "{ 'execute': 'human-monitor-command', + 'arguments': { 'command-line': + 'qemu-io source \"read -P 4 192k 64k\"' } }" \ + 'return' + # Copy source backing chain to the target before completing the job cp "$TEST_IMG.backing" "$TEST_IMG.target.backing" cp "$TEST_IMG" "$TEST_IMG.target" diff --git a/tests/qemu-iotests/156.out b/tests/qemu-iotests/156.out index 34c057b626..a591bd3a1e 100644 --- a/tests/qemu-iotests/156.out +++ b/tests/qemu-iotests/156.out @@ -20,6 +20,9 @@ Formatting 'TEST_DIR/t.IMGFMT.target.overlay', fmt=IMGFMT size=1048576 backing_f wrote 65536/65536 bytes at offset 196608 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) {"return": ""} +read 65536/65536 bytes at offset 196608 +64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) +{"return": ""} {"return": {}} {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "waiting", "id": "source"}} {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "pending", "id": "source"}}
Currently, we never test whether we can read from the source while mirroring (that means, whether we can read from the mirror BDS). Add such a test to 156 because it fits well. Signed-off-by: Max Reitz <mreitz@redhat.com> --- tests/qemu-iotests/156 | 7 +++++++ tests/qemu-iotests/156.out | 3 +++ 2 files changed, 10 insertions(+)