| Message ID | 20180827222322.26009-9-marcandre.lureau@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | chardev: various cleanups and improvements | expand |
diff --git a/chardev/char-pty.c b/chardev/char-pty.c index 68fd4e20c3..ebd7035c6d 100644 --- a/chardev/char-pty.c +++ b/chardev/char-pty.c @@ -134,11 +134,7 @@ static int char_pty_chr_write(Chardev *chr, const uint8_t *buf, int len) PtyChardev *s = PTY_CHARDEV(chr); if (!s->connected) { - /* guest sends data, check for (re-)connect */ - pty_chr_update_read_handler_locked(chr); - if (!s->connected) { - return len; - } + return len; } return io_channel_send(s->ioc, buf, len); }
This doesn't give much compared to the 1 second timer: there is no reliable / unracy way to have slave connect & master write. However, we can simplify the code around chr_write() since the write lock is no longer needed for various other char-pty callbacks (see following patch). Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> --- chardev/char-pty.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)