From patchwork Tue Sep 18 18:52:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Henrique Barboza X-Patchwork-Id: 10604817 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 058EF6CB for ; Tue, 18 Sep 2018 19:01:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E6FC92B467 for ; Tue, 18 Sep 2018 19:01:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D8E182B472; Tue, 18 Sep 2018 19:01:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 871312B467 for ; Tue, 18 Sep 2018 19:01:58 +0000 (UTC) Received: from localhost ([::1]:42182 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g2LG1-0006YO-Vi for patchwork-qemu-devel@patchwork.kernel.org; Tue, 18 Sep 2018 15:01:57 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57434) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g2L7k-0007og-6j for qemu-devel@nongnu.org; Tue, 18 Sep 2018 14:53:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g2L7f-0003Fh-N4 for qemu-devel@nongnu.org; Tue, 18 Sep 2018 14:53:21 -0400 Received: from mail-qt0-x242.google.com ([2607:f8b0:400d:c0d::242]:37661) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g2L7e-00039K-8g for qemu-devel@nongnu.org; Tue, 18 Sep 2018 14:53:18 -0400 Received: by mail-qt0-x242.google.com with SMTP id n6-v6so2744695qtl.4 for ; Tue, 18 Sep 2018 11:53:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=YoHDt3VFJvjZo9uSTOok/ssJkERyZnoUTNT2HKQUqAY=; b=sk4qJAVr07LOYOWc4SfAH/o01dOHsLC6zEUVojfcjzQ/2SeF0q6SOdLkZeUnJ8n3P5 COSfwBq//ib2J9w2w5hQDl8NR+cdL10QsEdqDtNmdoc1g5+6iXpAqXKbKlBKUtW2R6Cu W3I7caOVIMkmbRl0yuAuya9/C5wnz26Eo0Bq+onrjlRJNVgxNgT5wqq5YmlhMy7e1ETr jXXRcSLmarA81ezOCh2frbG0b7/5n2AXOP35GV+sA7WNdCt9r44D6nZHwBXEv1d5XbY1 XCn5BvVOmk2oNp6BHGHqh3YlYCgSgRNaq33dc+7MAaaDgcSN/qLKckAlndk8pk642O5V 4uLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=YoHDt3VFJvjZo9uSTOok/ssJkERyZnoUTNT2HKQUqAY=; b=QyV4snpysuE2K7IT+xYPnQrZzQzpcmqp2QfZ7MQwYFqu4tUtZR2tcRCqZsnDJGHJzo mfHcnVuKNzGqUbMnXIIjMpxlfPePIFnCL/uM7bz0UvJWPDEY9+44fGL4Azx7gphjgZzh XZaUG7hWGX7UOofaX5zkIhuKIkAGH4McawZP1/XYg2LmeWqfWXvxHte/jI41VmeScAf3 NHZAjB+8yEG1BjGyFXUCNkA0vrLuTEgPeWUOCZRpvaAMo5fIZsePiav+B0qim8y6Q42J u5ONhqpPo5jP58HhQ3ppZfH2X9fmgCYNh0o2FcUZfUy++W4wejh3A81WIlbY4ejWTgTj 8mPQ== X-Gm-Message-State: APzg51CyG0I2oLZgdeaXHMjXoFzbfult4a4pi1LruhnGCM6/1h1wPDdG ojaVlwVN52bO/xGg/iuf9YUHeU5wQHw= X-Google-Smtp-Source: ANB0VdYqB7pyVi4U5u2SB8r1rwtr4EsoVBlcJCdMf7M8IRmsGwxz7qFrr7dIVl7AC5p7854YS1/xwQ== X-Received: by 2002:a0c:91d8:: with SMTP id r24-v6mr22237511qvr.113.1537296793840; Tue, 18 Sep 2018 11:53:13 -0700 (PDT) Received: from localhost.localdomain ([2804:431:f700:46a7:852b:e394:1f41:b69d]) by smtp.gmail.com with ESMTPSA id n186-v6sm10568244qkb.32.2018.09.18.11.53.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Sep 2018 11:53:13 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Date: Tue, 18 Sep 2018 15:52:45 -0300 Message-Id: <20180918185246.18109-3-danielhb413@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180918185246.18109-1-danielhb413@gmail.com> References: <20180918185246.18109-1-danielhb413@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::242 Subject: [Qemu-devel] [PATCH v9 2/3] qga: update guest-suspend-ram and guest-suspend-hybrid descriptions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ehabkost@redhat.com, mst@redhat.com, Daniel Henrique Barboza , armbru@redhat.com, mdroth@linux.vnet.ibm.com, imammedo@redhat.com Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP This patch updates the descriptions of 'guest-suspend-ram' and 'guest-suspend-hybrid' to mention that both commands relies now on the proper support for wake up from suspend, retrieved by the 'wakeup-suspend-support' attribute of the 'query-current-machine' QMP command. Reported-by: Balamuruhan S Signed-off-by: Daniel Henrique Barboza Reviewed-by: Michael Roth --- qga/qapi-schema.json | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json index dfbc4a5e32..7ae7e2502c 100644 --- a/qga/qapi-schema.json +++ b/qga/qapi-schema.json @@ -567,9 +567,9 @@ # For the best results it's strongly recommended to have the pm-utils # package installed in the guest. # -# IMPORTANT: guest-suspend-ram requires QEMU to support the 'system_wakeup' -# command. Thus, it's *required* to query QEMU for the presence of the -# 'system_wakeup' command before issuing guest-suspend-ram. +# IMPORTANT: guest-suspend-ram requires working wakeup support in +# QEMU. You *must* check QMP command query-current-machine returns +# wakeup-suspend-support: true before issuing this command. # # This command does NOT return a response on success. There are two options # to check for success: @@ -594,9 +594,9 @@ # # This command requires the pm-utils package to be installed in the guest. # -# IMPORTANT: guest-suspend-hybrid requires QEMU to support the 'system_wakeup' -# command. Thus, it's *required* to query QEMU for the presence of the -# 'system_wakeup' command before issuing guest-suspend-hybrid. +# IMPORTANT: guest-suspend-hybrid requires working wakeup support in +# QEMU. You *must* check QMP command query-current-machine returns +# wakeup-suspend-support: true before issuing this command. # # This command does NOT return a response on success. There are two options # to check for success: