| Message ID | 20181011035026.23517-1-xypron.glpk@gmx.de (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [v2,1/1] hw/arm/virt: provide a model property in the fdt | expand |
On 11 October 2018 at 04:50, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > According to the "Devicetree Specification, Release v0.2" 'model' is a > required property of the root node. > > Some software like the Debian flash-kernel package rely on this property > to identify boards. > > The patch sets the model property to 'qemu,virt'. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > v2 > use the recommended format of the model property > --- > hw/arm/virt.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index 281ddcdf6e..abe366895a 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -200,6 +200,7 @@ static void create_fdt(VirtMachineState *vms) > vms->fdt = fdt; > > /* Header */ > + qemu_fdt_setprop_string(fdt, "/", "model", "qemu,virt"); > qemu_fdt_setprop_string(fdt, "/", "compatible", "linux,dummy-virt"); > qemu_fdt_setprop_cell(fdt, "/", "#address-cells", 0x2); > qemu_fdt_setprop_cell(fdt, "/", "#size-cells", 0x2); The spec says "a string that uniquely identifies the model of the system board". So should we be using "virt" for everything, or should we use "virt-2.10", "virt-2.11", "virt-2.12", etc ? thanks -- PMM
diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 281ddcdf6e..abe366895a 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -200,6 +200,7 @@ static void create_fdt(VirtMachineState *vms) vms->fdt = fdt; /* Header */ + qemu_fdt_setprop_string(fdt, "/", "model", "qemu,virt"); qemu_fdt_setprop_string(fdt, "/", "compatible", "linux,dummy-virt"); qemu_fdt_setprop_cell(fdt, "/", "#address-cells", 0x2); qemu_fdt_setprop_cell(fdt, "/", "#size-cells", 0x2);
According to the "Devicetree Specification, Release v0.2" 'model' is a required property of the root node. Some software like the Debian flash-kernel package rely on this property to identify boards. The patch sets the model property to 'qemu,virt'. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- v2 use the recommended format of the model property --- hw/arm/virt.c | 1 + 1 file changed, 1 insertion(+)