| Message ID | 20181017094406.4844-3-maozhongyi@cmss.chinamobile.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Modern shell scripting (use $() instead of ``) | expand |
Mao Zhongyi <maozhongyi@cmss.chinamobile.com> writes: > Various shell files contain a mix between obsolete `` > and modern $(); It would be nice to convert to using $() > everywhere. > > Cc: alex.bennee@linaro.org > Cc: famz@redhat.com > Cc: philmd@redhat.com > > Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com> Reviewed-by: Alex Bennée <alex.bennee@linaro.org> Tested-by: Alex Bennée <alex.bennee@linaro.org> > --- > tests/docker/dockerfiles/debian-bootstrap.pre | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/docker/dockerfiles/debian-bootstrap.pre b/tests/docker/dockerfiles/debian-bootstrap.pre > index 3b0ef95374..c164778c30 100755 > --- a/tests/docker/dockerfiles/debian-bootstrap.pre > +++ b/tests/docker/dockerfiles/debian-bootstrap.pre > @@ -2,7 +2,7 @@ > # > # Simple wrapper for debootstrap, run in the docker build context > # > -FAKEROOT=`which fakeroot 2> /dev/null` > +FAKEROOT=$(which fakeroot 2> /dev/null) > # debootstrap < 1.0.67 generates empty sources.list, see Debian#732255 > MIN_DEBOOTSTRAP_VERSION=1.0.67 > > @@ -52,7 +52,7 @@ fi > > if [ -z $DEBOOTSTRAP_DIR ]; then > NEED_DEBOOTSTRAP=false > - DEBOOTSTRAP=`which debootstrap 2> /dev/null` > + DEBOOTSTRAP=$(which debootstrap 2> /dev/null) > if [ -z $DEBOOTSTRAP ]; then > echo "No debootstrap installed, attempting to install from SCM" > NEED_DEBOOTSTRAP=true -- Alex Bennée
diff --git a/tests/docker/dockerfiles/debian-bootstrap.pre b/tests/docker/dockerfiles/debian-bootstrap.pre index 3b0ef95374..c164778c30 100755 --- a/tests/docker/dockerfiles/debian-bootstrap.pre +++ b/tests/docker/dockerfiles/debian-bootstrap.pre @@ -2,7 +2,7 @@ # # Simple wrapper for debootstrap, run in the docker build context # -FAKEROOT=`which fakeroot 2> /dev/null` +FAKEROOT=$(which fakeroot 2> /dev/null) # debootstrap < 1.0.67 generates empty sources.list, see Debian#732255 MIN_DEBOOTSTRAP_VERSION=1.0.67 @@ -52,7 +52,7 @@ fi if [ -z $DEBOOTSTRAP_DIR ]; then NEED_DEBOOTSTRAP=false - DEBOOTSTRAP=`which debootstrap 2> /dev/null` + DEBOOTSTRAP=$(which debootstrap 2> /dev/null) if [ -z $DEBOOTSTRAP ]; then echo "No debootstrap installed, attempting to install from SCM" NEED_DEBOOTSTRAP=true
Various shell files contain a mix between obsolete `` and modern $(); It would be nice to convert to using $() everywhere. Cc: alex.bennee@linaro.org Cc: famz@redhat.com Cc: philmd@redhat.com Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com> --- tests/docker/dockerfiles/debian-bootstrap.pre | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)