From patchwork Tue Oct 30 11:23:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 10660747 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5B97F17DF for ; Tue, 30 Oct 2018 11:52:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4AA3C2A23F for ; Tue, 30 Oct 2018 11:52:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 37BD02A24D; Tue, 30 Oct 2018 11:52:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D12922A23F for ; Tue, 30 Oct 2018 11:52:53 +0000 (UTC) Received: from localhost ([::1]:52453 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHSZp-0004lS-3z for patchwork-qemu-devel@patchwork.kernel.org; Tue, 30 Oct 2018 07:52:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59061) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHSAA-00033J-T7 for qemu-devel@nongnu.org; Tue, 30 Oct 2018 07:26:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gHSA8-00063E-2X for qemu-devel@nongnu.org; Tue, 30 Oct 2018 07:26:22 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:46133) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gHS9P-0003pT-AJ; Tue, 30 Oct 2018 07:25:35 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MAOeB-1gOpZx1zcB-00BvGL; Tue, 30 Oct 2018 12:24:26 +0100 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MAOeB-1gOpZx1zcB-00BvGL; Tue, 30 Oct 2018 12:24:26 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Tue, 30 Oct 2018 12:23:37 +0100 Message-Id: <20181030112337.17973-21-laurent@vivier.eu> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181030112337.17973-1-laurent@vivier.eu> References: <20181030112337.17973-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:q5LxrzvdYU7CPNsTLmGXXcTjoHWS7tXgOUNrLn6WUBVWOyJHjX4 58/MogZSaPYGsRQWWABAyYmkkq4GP4kTSBoX+BW8xORZbw9lnsftm0ULdRZVfyzPHvBfkVX im0zJo8hI/KqAI1lgVRGV+pAQltLLBEgS7mpqxBUTnMctLi4AA45imQ6ctGdfhsQfXau6wS maYGw3ZIKpvCBF1VfQoPQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:7TFd7E5ROws=:B4993IzhonnCusVI0tYSqj oK4t//8Dukd/+oJducnR5RFvmCYRSEaVEbLsC4ZmEuEBZgyRWltcIR1lu2F8v2ZjwYB2JknH6 GsPdi4itO5Erwp9m+K+HRu+jWmQLpZMzrPj9749Kk6W/pUF3n7fUYBR3vcLVe/q94VlSn3r/G AAkn/tk20nLGuE6rsbVb6z4F3sI1xNZmBuKWm0+vFrO3fndTto5s+am2PctR10ypxG2iT0Kev fSxN8W4MrqjLJfe0G2dROfSA5HgKL1ZxGVCDtmMT8nXH9GPhRiwx02k1SE4P4s9PIzJ8cMag2 EbWY+nTlE9ccICMPQSC05/sOAYj4QuA7kpQSA+PsNTYPaJ7F+xvc/O6ZCkV4gCQOxNnBqIBYx jBJ4WkuaHZZgXEBCnp2FNktnVWx2EUVQBm3FQBogC7uYb8aKeWZzqgpBdZalh0fuOvcD2NolC /cK4AghL6ZPqyiefJJndsrUdEj2hsEtcWsQyt1P89IecFc6F9dJ7AbP2mh/3Km2O5BVuAVUWO AFA8nwytpwTIyg6gO2IGxHvFRpFQ+x7B4J8A6+WaEjgUsZjk3Fli64vK3ct5bCA/WJ4X+J2e0 +AV2ac23Rf+NNlPxMNjNTRCTv0iXAK9kkzj7PQMERjYAUrvRjN8DuLKyzGRVi7x4UsPH3uFl0 UMaSxu2UYm85aPUAngv4wCBbWS/dguGcFXRMTXulLxNh5tcATdAYn5GCSEvAVVcHdk1bD69X9 qEaOjjIeMk4CJVII X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.135 Subject: [Qemu-devel] [PULL v2 20/20] milkymist-minimac2: Use qemu_log_mask(GUEST_ERROR) instead of error_report X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Michael S. Tsirkin" , Jason Wang , Michael Tokarev , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Gerd Hoffmann , Stefano Stabellini , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Michael Walle , Anthony Perard , xen-devel@lists.xenproject.org, Laurent Vivier , Thomas Huth , Fam Zheng , Eduardo Habkost , Riku Voipio , qemu-arm@nongnu.org, Cleber Rosa , =?utf-8?q?Alex_Benn=C3=A9e?= , Kevin Wolf , Markus Armbruster , Laurent Vivier , Max Reitz , Igor Mammedov , Aleksandar Markovic , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Philippe Mathieu-Daudé qemu_log_mask(GUEST_ERROR) is more appropriate: $ qemu -d help Log items (comma separated): guest_errors log when the guest OS does something invalid (eg accessing a non-existent register) Signed-off-by: Philippe Mathieu-Daudé Acked-by: Michael Walle Message-Id: <20181029130034.26750-1-f4bug@amsat.org> Signed-off-by: Laurent Vivier --- hw/net/milkymist-minimac2.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/hw/net/milkymist-minimac2.c b/hw/net/milkymist-minimac2.c index 3eaa19dfde..664ac34f25 100644 --- a/hw/net/milkymist-minimac2.c +++ b/hw/net/milkymist-minimac2.c @@ -30,6 +30,7 @@ #include "hw/sysbus.h" #include "trace.h" #include "net/net.h" +#include "qemu/log.h" #include "qemu/error-report.h" #include @@ -214,7 +215,8 @@ static size_t assemble_frame(uint8_t *buf, size_t size, uint32_t crc; if (size < payload_size + 12) { - error_report("milkymist_minimac2: received too big ethernet frame"); + qemu_log_mask(LOG_GUEST_ERROR, "milkymist_minimac2: frame too big " + "(%zd bytes)\n", payload_size); return 0; } @@ -347,8 +349,9 @@ minimac2_read(void *opaque, hwaddr addr, unsigned size) break; default: - error_report("milkymist_minimac2: read access to unknown register 0x" - TARGET_FMT_plx, addr << 2); + qemu_log_mask(LOG_GUEST_ERROR, + "milkymist_minimac2_rd%d: 0x%" HWADDR_PRIx "\n", + size, addr << 2); break; } @@ -413,8 +416,10 @@ minimac2_write(void *opaque, hwaddr addr, uint64_t value, break; default: - error_report("milkymist_minimac2: write access to unknown register 0x" - TARGET_FMT_plx, addr << 2); + qemu_log_mask(LOG_GUEST_ERROR, + "milkymist_minimac2_wr%d: 0x%" HWADDR_PRIx + " = 0x%" PRIx64 "\n", + size, addr << 2, value); break; } }