From patchwork Tue Nov 6 11:05:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Luc Michel X-Patchwork-Id: 10670107 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A3BEE15A6 for ; Tue, 6 Nov 2018 11:11:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9245A2A2A4 for ; Tue, 6 Nov 2018 11:11:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 868C12A2B2; Tue, 6 Nov 2018 11:11:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2D86C2A2A4 for ; Tue, 6 Nov 2018 11:11:10 +0000 (UTC) Received: from localhost ([::1]:40323 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gJzGH-0003sp-CY for patchwork-qemu-devel@patchwork.kernel.org; Tue, 06 Nov 2018 06:11:09 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48997) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gJzBp-0006Ur-0x for qemu-devel@nongnu.org; Tue, 06 Nov 2018 06:06:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gJzBj-00010z-0A for qemu-devel@nongnu.org; Tue, 06 Nov 2018 06:06:32 -0500 Received: from greensocs.com ([193.104.36.180]:46712) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gJzBU-0000os-I7; Tue, 06 Nov 2018 06:06:12 -0500 Received: from localhost (localhost [127.0.0.1]) by greensocs.com (Postfix) with ESMTP id 04EDA5C0279; Tue, 6 Nov 2018 12:06:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=greensocs.com; s=mail; t=1541502371; bh=p2Mv8ssQ4PExXJBSLWQS/O2C8dspM4cwOB9TCaV84ag=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=oLrQYy3tiWCMHdur2XD4HRwzMJR+eT30qlYEo/n0AKRtS4+Z5mXd0vsrT3gpcTa8H XQYixx8iNMj2xwf+eY62OLoIGi0746zr127d1dsqYR3lj4R3R9yZcVj9OwKH463fpl az+MBM6QIZruRpFNGhSWgUrjHHrYFVW0zVWTUcEg= X-Virus-Scanned: amavisd-new at greensocs.com Authentication-Results: gs-01.greensocs.com (amavisd-new); dkim=pass (1024-bit key) header.d=greensocs.com header.b=FhW5l/C3; dkim=pass (1024-bit key) header.d=greensocs.com header.b=FhW5l/C3 Received: from greensocs.com ([127.0.0.1]) by localhost (gs-01.greensocs.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mw99C17Zk_l4; Tue, 6 Nov 2018 12:06:10 +0100 (CET) Received: by greensocs.com (Postfix, from userid 998) id 6FF8C5C024B; Tue, 6 Nov 2018 12:06:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=greensocs.com; s=mail; t=1541502367; bh=p2Mv8ssQ4PExXJBSLWQS/O2C8dspM4cwOB9TCaV84ag=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=FhW5l/C3RuIoonhmYMWiCjkXzI5H2SDJ0HdrbxBPWgZm76E2rkt8/HUC12t7wUxJa 7/qtgDxBuv4U30u1eLqq4bRILCgPzwaLNUR/NM+pwQy6VRg2Mu5rBWNBEwY88/gQdu XjTKG1CSvw7g1x0AeLyy4+FjE+9Mp6CDipjECH+E= Received: from michell-laptop.home.lmichel.fr (lfbn-1-8165-82.w90-112.abo.wanadoo.fr [90.112.74.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: luc.michel@greensocs.com) by greensocs.com (Postfix) with ESMTPSA id 0CC805C024F; Tue, 6 Nov 2018 12:06:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=greensocs.com; s=mail; t=1541502367; bh=p2Mv8ssQ4PExXJBSLWQS/O2C8dspM4cwOB9TCaV84ag=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=FhW5l/C3RuIoonhmYMWiCjkXzI5H2SDJ0HdrbxBPWgZm76E2rkt8/HUC12t7wUxJa 7/qtgDxBuv4U30u1eLqq4bRILCgPzwaLNUR/NM+pwQy6VRg2Mu5rBWNBEwY88/gQdu XjTKG1CSvw7g1x0AeLyy4+FjE+9Mp6CDipjECH+E= From: Luc Michel To: qemu-devel@nongnu.org Date: Tue, 6 Nov 2018 12:05:38 +0100 Message-Id: <20181106110548.4209-7-luc.michel@greensocs.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181106110548.4209-1-luc.michel@greensocs.com> References: <20181106110548.4209-1-luc.michel@greensocs.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 193.104.36.180 Subject: [Qemu-devel] [PATCH v4 06/16] gdbstub: add multiprocess support to 'sC' packets X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , alistair@alistair23.me, mark.burton@greensocs.com, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , saipava@xilinx.com, edgari@xilinx.com, qemu-arm@nongnu.org, Luc Michel Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Change the sC packet handling to support the multiprocess extension. Instead of returning the first thread, we return the first thread of the current process. Signed-off-by: Luc Michel Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- gdbstub.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index ba8b1a3413..9be83486f5 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1546,13 +1546,18 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf) type = strtoul(p, (char **)&p, 16); sstep_flags = type; put_packet(s, "OK"); break; } else if (strcmp(p,"C") == 0) { - /* "Current thread" remains vague in the spec, so always return - * the first CPU (gdb returns the first thread). */ - put_packet(s, "QC1"); + /* "Current thread" remains vague in the spec, so always return the + * first thread of the current process (gdb returns the first + * thread). + */ + cpu = get_first_cpu_in_process(s, gdb_get_cpu_process(s, s->g_cpu)); + snprintf(buf, sizeof(buf), "QC%s", + gdb_fmt_thread_id(s, cpu, thread_id, sizeof(thread_id))); + put_packet(s, buf); break; } else if (strcmp(p,"fThreadInfo") == 0) { s->query_cpu = first_cpu; goto report_cpuinfo; } else if (strcmp(p,"sThreadInfo") == 0) {