From patchwork Fri Nov 9 17:33:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Henrique Barboza X-Patchwork-Id: 10676373 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C0F5B139B for ; Fri, 9 Nov 2018 17:35:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A49EC2ED3D for ; Fri, 9 Nov 2018 17:35:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 952422ED38; Fri, 9 Nov 2018 17:35:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 362432ED38 for ; Fri, 9 Nov 2018 17:35:12 +0000 (UTC) Received: from localhost ([::1]:35316 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gLAgZ-0003GW-6h for patchwork-qemu-devel@patchwork.kernel.org; Fri, 09 Nov 2018 12:35:11 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gLAfD-0002L2-A9 for qemu-devel@nongnu.org; Fri, 09 Nov 2018 12:33:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gLAfB-0007Mh-8n for qemu-devel@nongnu.org; Fri, 09 Nov 2018 12:33:46 -0500 Received: from mail-qk1-x744.google.com ([2607:f8b0:4864:20::744]:45251) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gLAf9-00070M-A3 for qemu-devel@nongnu.org; Fri, 09 Nov 2018 12:33:43 -0500 Received: by mail-qk1-x744.google.com with SMTP id d135so2928471qkc.12 for ; Fri, 09 Nov 2018 09:33:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qW42mv6xL4kl5nu3ZOvlhgGHmInL+OIZd5bFWIi5n74=; b=Tc8FC2dmmP61NA66dcOEgA0ss2sADHm0EnxSBXOfL2PTmUn7p7XeGJiQzTnNOKC6We 34zcIhTrz+x/XxvbyxCnqBtZ5ykkuNYMHHnIvyOPlglnTHZoTD2Qrvu8tijh2pqww8+D H8U84oMWvhJW/kATBDhru1gLOIlxRyHLORorGYyK6XXrFyDSuRj0oQSoJIu2SwR7gaMh Fuaf640iLzvcppOLA8NS4u4lleZWRNkDLHzziSPIiRsuuyHvOEzLLUajrn6XuFH9PK+H qDCnJqjS73L5MwnInn9xlVWdUljzmbao4cUTNhcEGr0DTzr3dG4iYEzQ2FiwvwMEhdHO WZBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qW42mv6xL4kl5nu3ZOvlhgGHmInL+OIZd5bFWIi5n74=; b=guM699T2DeHIxjt4IpOkfSK/hTT53GC5BYZLe/KewDRxFbw1HJ8+vCJ9XMQ7haljaa e06dAjBznqLegGyGwuYFNPXU21mqoozkd+Rt4Og1ZOklOUzJZZ/6FC8g8jeV9elP7uZJ l7oqS96eJ1SaD2qgcsuYM/pzhcXiDXs2/hTmRNNBxi1597yneN6H2t/rVoPFpP1apvaZ MGgqrO1C4xOsnEoNHgVJcVFAXuttDbJOG2i+iv7ea50PbRdf7z/aUScCeJO1/l9D4/zP MCioYTu2ic4DfX5LoJCw4tWeHYlYSrwD8d/GP461fi3H64JAupm1eoAsiXSN0i97gssV DVRw== X-Gm-Message-State: AGRZ1gIc3TzJj1v6y1rNbYuqmx8LD3Qeiz2CDqryDxznZkxsFyno1dni uHMhGKpVksjjwI/uGTohnPySRND2 X-Google-Smtp-Source: AJdET5cp7Q9DCE8UCiiW+64rSyYN6ODRJc1RD9FpZFj3BDPl9zs67euDmhut/FuGQHoNopMfRUkKdw== X-Received: by 2002:a05:6214:110e:: with SMTP id e14mr9705314qvs.10.1541784808476; Fri, 09 Nov 2018 09:33:28 -0800 (PST) Received: from localhost.localdomain ([2804:431:f700:ba45:a11b:1d87:ae84:ee6f]) by smtp.gmail.com with ESMTPSA id r142sm3942595qke.27.2018.11.09.09.33.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 09 Nov 2018 09:33:28 -0800 (PST) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Date: Fri, 9 Nov 2018 15:33:08 -0200 Message-Id: <20181109173309.25212-3-danielhb413@gmail.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181109173309.25212-1-danielhb413@gmail.com> References: <20181109173309.25212-1-danielhb413@gmail.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::744 Subject: [Qemu-devel] [PATCH for-3.2 v10 2/3] qga: update guest-suspend-ram and guest-suspend-hybrid descriptions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ehabkost@redhat.com, mst@redhat.com, Daniel Henrique Barboza , armbru@redhat.com, mdroth@linux.vnet.ibm.com, imammedo@redhat.com Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP This patch updates the descriptions of 'guest-suspend-ram' and 'guest-suspend-hybrid' to mention that both commands relies now on the proper support for wake up from suspend, retrieved by the 'wakeup-suspend-support' attribute of the 'query-current-machine' QMP command. Reported-by: Balamuruhan S Signed-off-by: Daniel Henrique Barboza Reviewed-by: Michael Roth --- qga/qapi-schema.json | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json index c6725b3ec8..78a439263e 100644 --- a/qga/qapi-schema.json +++ b/qga/qapi-schema.json @@ -567,9 +567,11 @@ # For the best results it's strongly recommended to have the pm-utils # package installed in the guest. # -# IMPORTANT: guest-suspend-ram requires QEMU to support the 'system_wakeup' -# command. Thus, it's *required* to query QEMU for the presence of the -# 'system_wakeup' command before issuing guest-suspend-ram. +# IMPORTANT: guest-suspend-ram requires working wakeup support in +# QEMU. You *must* check QMP command query-current-machine returns +# wakeup-suspend-support: true before issuing this command. Failure in +# doing so can result in a suspended guest that QEMU will not be able to +# awaken, forcing the user to power cycle the guest to bring it back. # # This command does NOT return a response on success. There are two options # to check for success: @@ -594,9 +596,11 @@ # # This command requires the pm-utils package to be installed in the guest. # -# IMPORTANT: guest-suspend-hybrid requires QEMU to support the 'system_wakeup' -# command. Thus, it's *required* to query QEMU for the presence of the -# 'system_wakeup' command before issuing guest-suspend-hybrid. +# IMPORTANT: guest-suspend-hybrid requires working wakeup support in +# QEMU. You *must* check QMP command query-current-machine returns +# wakeup-suspend-support: true before issuing this command. Failure in +# doing so can result in a suspended guest that QEMU will not be able to +# awaken, forcing the user to power cycle the guest to bring it back. # # This command does NOT return a response on success. There are two options # to check for success: