| Message ID | 20181124235553.17371-2-cota@braap.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hardfloat | expand |
Emilio G. Cota <cota@braap.org> writes: > This gets rid of the muladd errors due to not raising the invalid flag. > > - Before: > Errors found in f64_mulAdd, rounding near_even, tininess before rounding: > +000.0000000000000 +7FF.0000000000000 +7FF.FFFFFFFFFFFFF > => +7FF.FFFFFFFFFFFFF ..... expected -7FF.FFFFFFFFFFFFF v.... > [...] > > - After: > In 6133248 tests, no errors found in f64_mulAdd, rounding near_even, tininess before rounding. > [...] > > Signed-off-by: Emilio G. Cota <cota@braap.org> Reviewed-by: Alex Bennée <alex.bennee@linaro.org> Tested-by: Alex Bennée <alex.bennee@linaro.org> > --- > tests/fp/Makefile | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tests/fp/Makefile b/tests/fp/Makefile > index d649a5a1db..49cdcd1bd2 100644 > --- a/tests/fp/Makefile > +++ b/tests/fp/Makefile > @@ -29,6 +29,9 @@ QEMU_INCLUDES += -I$(TF_SOURCE_DIR) > > # work around TARGET_* poisoning > QEMU_CFLAGS += -DHW_POISON_H > +# define a target to match testfloat's implementation-defined choices, such as > +# whether to raise the invalid flag when dealing with NaNs in muladd. > +QEMU_CFLAGS += -DTARGET_ARM > > # capstone has a platform.h file that clashes with softfloat's > QEMU_CFLAGS := $(filter-out %capstone, $(QEMU_CFLAGS)) -- Alex Bennée
diff --git a/tests/fp/Makefile b/tests/fp/Makefile index d649a5a1db..49cdcd1bd2 100644 --- a/tests/fp/Makefile +++ b/tests/fp/Makefile @@ -29,6 +29,9 @@ QEMU_INCLUDES += -I$(TF_SOURCE_DIR) # work around TARGET_* poisoning QEMU_CFLAGS += -DHW_POISON_H +# define a target to match testfloat's implementation-defined choices, such as +# whether to raise the invalid flag when dealing with NaNs in muladd. +QEMU_CFLAGS += -DTARGET_ARM # capstone has a platform.h file that clashes with softfloat's QEMU_CFLAGS := $(filter-out %capstone, $(QEMU_CFLAGS))
This gets rid of the muladd errors due to not raising the invalid flag. - Before: Errors found in f64_mulAdd, rounding near_even, tininess before rounding: +000.0000000000000 +7FF.0000000000000 +7FF.FFFFFFFFFFFFF => +7FF.FFFFFFFFFFFFF ..... expected -7FF.FFFFFFFFFFFFF v.... [...] - After: In 6133248 tests, no errors found in f64_mulAdd, rounding near_even, tininess before rounding. [...] Signed-off-by: Emilio G. Cota <cota@braap.org> --- tests/fp/Makefile | 3 +++ 1 file changed, 3 insertions(+)