| Message ID | 20181125205000.10324-8-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | MAINTAINERS: Add various missing entries | expand |
On 25.11.18. 21:49, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Stefan Markovic <smarkovic@wavecomp.com> > diff --git a/MAINTAINERS b/MAINTAINERS > index aa17e9bbd3..81a22b2ccf 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -864,6 +864,7 @@ R: Stefan Markovic <smarkovic@wavecomp.com> > S: Odd Fixes > F: hw/mips/mips_fulong2e.c > F: hw/isa/vt82c686.c > +F: hw/pci-host/bonito.c > > F: include/hw/isa/vt82c686.h >
On 2018-11-25 21:49, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index aa17e9bbd3..81a22b2ccf 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -864,6 +864,7 @@ R: Stefan Markovic <smarkovic@wavecomp.com> > S: Odd Fixes > F: hw/mips/mips_fulong2e.c > F: hw/isa/vt82c686.c > +F: hw/pci-host/bonito.c > > F: include/hw/isa/vt82c686.h Please remove the empty line between bonito.c and vt82c686.h - or we could use my patch here from last Thursday instead: https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg04526.html Thomas
I like better the patch that Thomas linked to. I think Philippe should have included Thomas' patch, rather than creating new, overlapping, patches. Confusion about straitforward things! Aleksandar
On 27/11/18 10:58, Aleksandar Markovic wrote: [moving Aleksandar reply down to avoid top-posting on technical list] > From: Thomas Huth <thuth@redhat.com> > On 2018-11-25 21:49, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> >> --- >> MAINTAINERS | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index aa17e9bbd3..81a22b2ccf 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -864,6 +864,7 @@ R: Stefan Markovic <smarkovic@wavecomp.com> >> S: Odd Fixes >> F: hw/mips/mips_fulong2e.c >> F: hw/isa/vt82c686.c >> +F: hw/pci-host/bonito.c >> >> F: include/hw/isa/vt82c686.h > > Please remove the empty line between bonito.c and vt82c686.h - or we > could use my patch here from last Thursday instead: > > https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg04526.html > I like better the patch that Thomas linked to. I think Philippe should have included Thomas' patch, rather than creating new, overlapping, patches. Confusion about straitforward things! Aleksandar Yes you are right, I missed Thomas's patch, so please disregard mine. Thanks! Phil. > > Thomas > >
diff --git a/MAINTAINERS b/MAINTAINERS index aa17e9bbd3..81a22b2ccf 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -864,6 +864,7 @@ R: Stefan Markovic <smarkovic@wavecomp.com> S: Odd Fixes F: hw/mips/mips_fulong2e.c F: hw/isa/vt82c686.c +F: hw/pci-host/bonito.c F: include/hw/isa/vt82c686.h
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+)