From patchwork Wed Dec 5 19:47:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Henrique Barboza X-Patchwork-Id: 10714783 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0AFEE157A for ; Wed, 5 Dec 2018 19:51:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F260F2E356 for ; Wed, 5 Dec 2018 19:51:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F08FB2E361; Wed, 5 Dec 2018 19:51:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 758AC2E356 for ; Wed, 5 Dec 2018 19:51:07 +0000 (UTC) Received: from localhost ([::1]:36467 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gUdCM-0006Pn-Qd for patchwork-qemu-devel@patchwork.kernel.org; Wed, 05 Dec 2018 14:51:06 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60634) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gUd8t-000257-0c for qemu-devel@nongnu.org; Wed, 05 Dec 2018 14:47:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gUd8q-0008Ia-Vm for qemu-devel@nongnu.org; Wed, 05 Dec 2018 14:47:30 -0500 Received: from mail-qk1-x742.google.com ([2607:f8b0:4864:20::742]:43723) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gUd8q-0008DG-Of for qemu-devel@nongnu.org; Wed, 05 Dec 2018 14:47:28 -0500 Received: by mail-qk1-x742.google.com with SMTP id r71so12601697qkr.10 for ; Wed, 05 Dec 2018 11:47:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rH647j70gDId6fAK8kjEbEY5mr5GDdJcVB18MHmW+kY=; b=XaN8+mg/gJ9vjnykgm+8MDQSZQJGFspMVUoCj0tsxGzAG8rXRfeR2EuvHzlXVVM5ly EWivcc8B/kp5MbSZqzAOkSi7PTyimlj91jCtf9XWOeNjMnPbQ37vINgsEKtu07VxJMQ0 ICMwNMuylnFMsq4Q+Tv/7DISPH+LMXRypRgfhPA8bIZVfNn9HE7QROAMXUif9efByEJx nhkIT/XkQbnOdelMfYkLGRT3oBJJVqWQa+aJTbchrbzSXznRIWAgQQ3FxYWd5u5z7Yls XeXpwTouEiaSLBwniydHwdt6WS4qiFEnH6hAQDUhcq0f+KEB3c/XHPwQBKat6z8f9mBy 4zXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rH647j70gDId6fAK8kjEbEY5mr5GDdJcVB18MHmW+kY=; b=srVqGpqi0SuQLEiDMuJoLGNwg7Rr32P6daGDJEIrXcDmYJcnSktWwwwLVfLchuHjEi KA7Lu33evyUmHhEzTz09ygKIBI6Gvg9xoLw13cFwPRNFH+3XlVv498g3aLz0DhjUcbOJ W1+tPvYmqlFJ8U/CLFQ2rzor+9Y5XY6p+e14xAckTSWtLG7B7kqo8scI6brSDn1S0UEq gh939cQB9mHlZsQwxVcXEyFfZ7oYCgS3yVXN0dwpqeSfsMX7UYXhmnbMu1STpcpxabYK APbJHb2PFwrZUeBy7as5hN10AT2mDNsUvJHC2eszOmYDMhfENs+3fXm/9RyTpNU63Pg2 eV4A== X-Gm-Message-State: AA+aEWa4ZvDRBDI5+yqH/lyN50zGZ9LE1M0t0Tl7G6SWlv26VDLF5Kpr jZK9gY3vh3PAgBWPBbwBc8btKtEZOGA= X-Google-Smtp-Source: AFSGD/UgYeMaEn/3VIl1xxcqEKzVotVk7SojLHu6RGb/0P/y6S+JVA0as3csL9RZXA7WKXPkptITDA== X-Received: by 2002:a37:ea0a:: with SMTP id t10mr23089222qkj.273.1544039240812; Wed, 05 Dec 2018 11:47:20 -0800 (PST) Received: from localhost.localdomain ([2804:431:f700:5b3d:a6d3:486e:8166:3fca]) by smtp.gmail.com with ESMTPSA id q72sm12446248qki.24.2018.12.05.11.47.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 05 Dec 2018 11:47:20 -0800 (PST) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Date: Wed, 5 Dec 2018 17:47:00 -0200 Message-Id: <20181205194701.17836-3-danielhb413@gmail.com> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181205194701.17836-1-danielhb413@gmail.com> References: <20181205194701.17836-1-danielhb413@gmail.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::742 Subject: [Qemu-devel] [PATCH v11 2/3] qga: update guest-suspend-ram and guest-suspend-hybrid descriptions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ehabkost@redhat.com, mst@redhat.com, Daniel Henrique Barboza , armbru@redhat.com, mdroth@linux.vnet.ibm.com, imammedo@redhat.com Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP This patch updates the descriptions of 'guest-suspend-ram' and 'guest-suspend-hybrid' to mention that both commands relies now on the proper support for wake up from suspend, retrieved by the 'wakeup-suspend-support' attribute of the 'query-current-machine' QMP command. Reported-by: Balamuruhan S Signed-off-by: Daniel Henrique Barboza Reviewed-by: Michael Roth Reviewed-by: Markus Armbruster --- qga/qapi-schema.json | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json index c6725b3ec8..a4ff5b8fc9 100644 --- a/qga/qapi-schema.json +++ b/qga/qapi-schema.json @@ -567,9 +567,11 @@ # For the best results it's strongly recommended to have the pm-utils # package installed in the guest. # -# IMPORTANT: guest-suspend-ram requires QEMU to support the 'system_wakeup' -# command. Thus, it's *required* to query QEMU for the presence of the -# 'system_wakeup' command before issuing guest-suspend-ram. +# IMPORTANT: guest-suspend-ram requires working wakeup support in +# QEMU. You should check QMP command query-current-machine returns +# wakeup-suspend-support: true before issuing this command. Failure in +# doing so can result in a suspended guest that QEMU will not be able to +# awaken, forcing the user to power cycle the guest to bring it back. # # This command does NOT return a response on success. There are two options # to check for success: @@ -594,9 +596,11 @@ # # This command requires the pm-utils package to be installed in the guest. # -# IMPORTANT: guest-suspend-hybrid requires QEMU to support the 'system_wakeup' -# command. Thus, it's *required* to query QEMU for the presence of the -# 'system_wakeup' command before issuing guest-suspend-hybrid. +# IMPORTANT: guest-suspend-hybrid requires working wakeup support in +# QEMU. You should check QMP command query-current-machine returns +# wakeup-suspend-support: true before issuing this command. Failure in +# doing so can result in a suspended guest that QEMU will not be able to +# awaken, forcing the user to power cycle the guest to bring it back. # # This command does NOT return a response on success. There are two options # to check for success: