Message ID | 20181206232333.22408-2-pbonzini@redhat.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | qemu/queue.h usage cleanup, improved QTAILQ API | expand |
Paolo Bonzini <pbonzini@redhat.com> writes: > Use the QTAILQ_IN_USE macro instead, it does the same thing but the next > patch will change it to a different definition. > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > blockdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/blockdev.c b/blockdev.c > index 81f95d920b..7604b2183b 100644 > --- a/blockdev.c > +++ b/blockdev.c > @@ -4259,7 +4259,7 @@ void qmp_blockdev_del(const char *node_name, Error **errp) > goto out; > } > > - if (!bs->monitor_list.tqe_prev) { > + if (!QTAILQ_IN_USE(bs, monitor_list)) { > error_setg(errp, "Node %s is not owned by the monitor", > bs->node_name); > goto out; Reviewed-by: Markus Armbruster <armbru@redhat.com>
On 12/7/18 12:23 AM, Paolo Bonzini wrote: > Use the QTAILQ_IN_USE macro instead, it does the same thing but the next > patch will change it to a different definition. > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > blockdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/blockdev.c b/blockdev.c > index 81f95d920b..7604b2183b 100644 > --- a/blockdev.c > +++ b/blockdev.c > @@ -4259,7 +4259,7 @@ void qmp_blockdev_del(const char *node_name, Error **errp) > goto out; > } > > - if (!bs->monitor_list.tqe_prev) { > + if (!QTAILQ_IN_USE(bs, monitor_list)) { > error_setg(errp, "Node %s is not owned by the monitor", > bs->node_name); > goto out; >
diff --git a/blockdev.c b/blockdev.c index 81f95d920b..7604b2183b 100644 --- a/blockdev.c +++ b/blockdev.c @@ -4259,7 +4259,7 @@ void qmp_blockdev_del(const char *node_name, Error **errp) goto out; } - if (!bs->monitor_list.tqe_prev) { + if (!QTAILQ_IN_USE(bs, monitor_list)) { error_setg(errp, "Node %s is not owned by the monitor", bs->node_name); goto out;
Use the QTAILQ_IN_USE macro instead, it does the same thing but the next patch will change it to a different definition. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- blockdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)