diff mbox series

block: Replace qdict_put() by qdict_put_obj() where appropriate

Message ID 20181213175154.5242-1-armbru@redhat.com (mailing list archive)
State New, archived
Headers show
Series block: Replace qdict_put() by qdict_put_obj() where appropriate | expand

Commit Message

Markus Armbruster Dec. 13, 2018, 5:51 p.m. UTC
Patch created mechanically by rerunning:

  $  spatch --sp-file scripts/coccinelle/qobject.cocci \
	    --macro-file scripts/cocci-macro-file.h \
	    --dir block --in-place

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 block/blklogwrites.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Eric Blake Dec. 13, 2018, 9:28 p.m. UTC | #1
On 12/13/18 11:51 AM, Markus Armbruster wrote:
> Patch created mechanically by rerunning:
> 
>    $  spatch --sp-file scripts/coccinelle/qobject.cocci \
> 	    --macro-file scripts/cocci-macro-file.h \
> 	    --dir block --in-place
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>   block/blklogwrites.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>
Alberto Garcia Dec. 14, 2018, 8:13 a.m. UTC | #2
On Thu 13 Dec 2018 06:51:54 PM CET, Markus Armbruster wrote:
> Patch created mechanically by rerunning:
>
>   $  spatch --sp-file scripts/coccinelle/qobject.cocci \
> 	    --macro-file scripts/cocci-macro-file.h \
> 	    --dir block --in-place
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Reviewed-by: Alberto Garcia <berto@igalia.com>

Berto
Kevin Wolf Jan. 8, 2019, 7:06 p.m. UTC | #3
Am 13.12.2018 um 18:51 hat Markus Armbruster geschrieben:
> Patch created mechanically by rerunning:
> 
>   $  spatch --sp-file scripts/coccinelle/qobject.cocci \
> 	    --macro-file scripts/cocci-macro-file.h \
> 	    --dir block --in-place
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Thanks, applied to the block branch.

Kevin
diff mbox series

Patch

diff --git a/block/blklogwrites.c b/block/blklogwrites.c
index ff98cd5533..d2e01bdb1d 100644
--- a/block/blklogwrites.c
+++ b/block/blklogwrites.c
@@ -295,10 +295,9 @@  static void blk_log_writes_refresh_filename(BlockDriverState *bs,
         qdict_put_str(opts, "driver", "blklogwrites");
 
         qobject_ref(bs->file->bs->full_open_options);
-        qdict_put_obj(opts, "file", QOBJECT(bs->file->bs->full_open_options));
+        qdict_put(opts, "file", bs->file->bs->full_open_options);
         qobject_ref(s->log_file->bs->full_open_options);
-        qdict_put_obj(opts, "log",
-                      QOBJECT(s->log_file->bs->full_open_options));
+        qdict_put(opts, "log", s->log_file->bs->full_open_options);
         qdict_put_int(opts, "log-sector-size", s->sectorsize);
 
         bs->full_open_options = opts;