| Message ID | 20181219151917.3874-1-pbonzini@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, 19 Dec 2018 at 15:21, Paolo Bonzini <pbonzini@redhat.com> wrote: > > The following changes since commit e85c577158a2e8e252414959da9ef15c12eec63d: > > Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2018-12-17' into staging (2018-12-18 14:31:06 +0000) > > are available in the Git repository at: > > git://github.com/bonzini/qemu.git tags/for-upstream > > for you to fetch changes up to b4e8bbb9ae50045160957e7ab66c4f1cae535ea4: > > avoid TABs in files that only contain a few (2018-12-19 16:03:22 +0100) > > ---------------------------------------------------------------- > * HAX support for Linux hosts (Alejandro) > * esp bugfixes (Guenter) > * Windows build cleanup (Marc-André) > * checkpatch logic improvements (Paolo) > * coalesced range bugfix (Paolo) > * switch testsuite to TAP (Paolo) > * QTAILQ rewrite (Paolo) > * block/iscsi.c cancellation fixes (Stefan) > * improve selection of the default accelerator (Thomas) > > ---------------------------------------------------------------- I get a compile failure on my OSX system: CC tests/test-crypto-pbkdf.o /Users/pm215/src/qemu-for-merges/tests/test-crypto-pbkdf.c:444:17: error: too few arguments to function call, single argument 'msg' was not specified g_test_skip(); ~~~~~~~~~~~ ^ /usr/local/Cellar/glib/2.58.1/include/glib-2.0/glib/gtestutils.h:209:1: note: 'g_test_skip' declared here GLIB_AVAILABLE_IN_2_38 ^ /usr/local/Cellar/glib/2.58.1/include/glib-2.0/glib/gversionmacros.h:394:49: note: expanded from macro 'GLIB_AVAILABLE_IN_2_38' # define GLIB_AVAILABLE_IN_2_38 _GLIB_EXTERN ^ /usr/local/Cellar/glib/2.58.1/include/glib-2.0/glib/gmacros.h:456:22: note: expanded from macro '_GLIB_EXTERN' #define _GLIB_EXTERN extern ^ 1 error generated. I also get this splat trying to do 'make check-tcg': make: Entering directory '/home/petmay01/linaro/qemu-for-merges/build/all-linux-static' BUILD debian9 The command '/bin/sh -c DEBIAN_FRONTEND=noninteractive eatmydata apt install -y --no-install-recommends bison build-essential ca-certificates clang flex gettext git libtest-harness-perl pkg-config psmisc python texinfo $(apt-get -s build-dep qemu | egrep ^Inst | fgrep '[all]' | cut -d\ -f2)' returned a non-zero code: 100 Traceback (most recent call last): File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", line 563, in <module> sys.exit(main()) File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", line 560, in main return args.cmdobj.run(args, argv) File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", line 376, in run extra_files_cksum=cksum) File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", line 254, in build_image quiet=quiet) File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", line 181, in _do_check return subprocess.check_call(self._command + cmd, **kwargs) File "/usr/lib/python2.7/subprocess.py", line 541, in check_call raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '['docker', 'build', '-t', 'qemu:debian9', '-f', '/tmp/docker_buildsvtS6R/tmp74LVkj.docker', '/tmp/docker_buildsvtS6R']' returned non-zero exit status 100 /home/petmay01/linaro/qemu-for-merges/tests/docker/Makefile.include:53: recipe for target 'docker-image-debian9' failed make: *** [docker-image-debian9] Error 1 thanks -- PMM
On 20/12/18 00:10, Peter Maydell wrote: > I get a compile failure on my OSX system: > > CC tests/test-crypto-pbkdf.o > /Users/pm215/src/qemu-for-merges/tests/test-crypto-pbkdf.c:444:17: > error: too few arguments to function call, single argument 'msg' was > not specified > g_test_skip(); > ~~~~~~~~~~~ ^ > /usr/local/Cellar/glib/2.58.1/include/glib-2.0/glib/gtestutils.h:209:1: > note: 'g_test_skip' declared here > GLIB_AVAILABLE_IN_2_38 > ^ > /usr/local/Cellar/glib/2.58.1/include/glib-2.0/glib/gversionmacros.h:394:49: > note: expanded from macro 'GLIB_AVAILABLE_IN_2_38' > # define GLIB_AVAILABLE_IN_2_38 _GLIB_EXTERN > ^ > /usr/local/Cellar/glib/2.58.1/include/glib-2.0/glib/gmacros.h:456:22: > note: expanded from macro '_GLIB_EXTERN' > #define _GLIB_EXTERN extern > ^ > 1 error generated. Sorry, I forgot to commit the fix. > > I also get this splat trying to do 'make check-tcg': > > make: Entering directory > '/home/petmay01/linaro/qemu-for-merges/build/all-linux-static' > BUILD debian9 > The command '/bin/sh -c DEBIAN_FRONTEND=noninteractive eatmydata > apt install -y --no-install-recommends bison > build-essential ca-certificates clang flex > gettext git libtest-harness-perl > pkg-config psmisc python texinfo > $(apt-get -s build-dep qemu | egrep ^Inst | fgrep '[all]' | cut -d\ > -f2)' returned a non-zero code: 100 > Traceback (most recent call last): > File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", > line 563, in <module> > sys.exit(main()) > File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", > line 560, in main > return args.cmdobj.run(args, argv) > File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", > line 376, in run > extra_files_cksum=cksum) > File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", > line 254, in build_image > quiet=quiet) > File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", > line 181, in _do_check > return subprocess.check_call(self._command + cmd, **kwargs) > File "/usr/lib/python2.7/subprocess.py", line 541, in check_call > raise CalledProcessError(retcode, cmd) > subprocess.CalledProcessError: Command '['docker', 'build', '-t', > 'qemu:debian9', '-f', '/tmp/docker_buildsvtS6R/tmp74LVkj.docker', > '/tmp/docker_buildsvtS6R']' returned non-zero exit status 100 > /home/petmay01/linaro/qemu-for-merges/tests/docker/Makefile.include:53: > recipe for target 'docker-image-debian9' failed > make: *** [docker-image-debian9] Error 1 I'll try it too. Paolo
On 12/20/18 12:10 AM, Peter Maydell wrote: > On Wed, 19 Dec 2018 at 15:21, Paolo Bonzini <pbonzini@redhat.com> wrote: >> >> The following changes since commit e85c577158a2e8e252414959da9ef15c12eec63d: >> >> Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2018-12-17' into staging (2018-12-18 14:31:06 +0000) >> >> are available in the Git repository at: >> >> git://github.com/bonzini/qemu.git tags/for-upstream >> >> for you to fetch changes up to b4e8bbb9ae50045160957e7ab66c4f1cae535ea4: >> >> avoid TABs in files that only contain a few (2018-12-19 16:03:22 +0100) >> >> ---------------------------------------------------------------- >> * HAX support for Linux hosts (Alejandro) >> * esp bugfixes (Guenter) >> * Windows build cleanup (Marc-André) >> * checkpatch logic improvements (Paolo) >> * coalesced range bugfix (Paolo) >> * switch testsuite to TAP (Paolo) >> * QTAILQ rewrite (Paolo) >> * block/iscsi.c cancellation fixes (Stefan) >> * improve selection of the default accelerator (Thomas) >> >> ---------------------------------------------------------------- [...] > I also get this splat trying to do 'make check-tcg': > > make: Entering directory > '/home/petmay01/linaro/qemu-for-merges/build/all-linux-static' > BUILD debian9 > The command '/bin/sh -c DEBIAN_FRONTEND=noninteractive eatmydata > apt install -y --no-install-recommends bison > build-essential ca-certificates clang flex > gettext git libtest-harness-perl > pkg-config psmisc python texinfo > $(apt-get -s build-dep qemu | egrep ^Inst | fgrep '[all]' | cut -d\ > -f2)' returned a non-zero code: 100 > Traceback (most recent call last): > File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", > line 563, in <module> > sys.exit(main()) > File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", > line 560, in main > return args.cmdobj.run(args, argv) > File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", > line 376, in run > extra_files_cksum=cksum) > File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", > line 254, in build_image > quiet=quiet) > File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", > line 181, in _do_check > return subprocess.check_call(self._command + cmd, **kwargs) > File "/usr/lib/python2.7/subprocess.py", line 541, in check_call > raise CalledProcessError(retcode, cmd) > subprocess.CalledProcessError: Command '['docker', 'build', '-t', > 'qemu:debian9', '-f', '/tmp/docker_buildsvtS6R/tmp74LVkj.docker', > '/tmp/docker_buildsvtS6R']' returned non-zero exit status 100 > /home/petmay01/linaro/qemu-for-merges/tests/docker/Makefile.include:53: > recipe for target 'docker-image-debian9' failed > make: *** [docker-image-debian9] Error 1 This looks an unrelated error. The Debian mirror you are using might be out of sync (or syncing), or the filesystem where you store your Docker image is full?
On 20/12/18 12:43, Philippe Mathieu-Daudé wrote: >> subprocess.CalledProcessError: Command '['docker', 'build', '-t', >> 'qemu:debian9', '-f', '/tmp/docker_buildsvtS6R/tmp74LVkj.docker', >> '/tmp/docker_buildsvtS6R']' returned non-zero exit status 100 >> /home/petmay01/linaro/qemu-for-merges/tests/docker/Makefile.include:53: >> recipe for target 'docker-image-debian9' failed >> make: *** [docker-image-debian9] Error 1 > > This looks an unrelated error. The Debian mirror you are using might be > out of sync (or syncing), or the filesystem where you store your Docker > image is full? Indeed I cannot reproduce it. I'll send the pull request with g_test_skip fixed (well, removed -- the harness notes 0 tests run and declares it a SKIP anyway). Paolo
Patchew URL: https://patchew.org/QEMU/20181219151917.3874-1-pbonzini@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20181219151917.3874-1-pbonzini@redhat.com
Type: series
Subject: [Qemu-devel] [PULL v2 00/35] Misc patches for 2018-12-18
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
27038c1 avoid TABs in files that only contain a few
8380bfa remove space-tab sequences
dfd008b scripts: add script to convert multiline comments into 4-line format
b882f38 hw/watchdog/wdt_i6300esb: remove a unnecessary comment
623f846 checkpatch: warn about qemu/queue.h head structs that are not typedef-ed
d02ffd9 qemu/queue.h: simplify reverse access to QTAILQ
3810871 qemu/queue.h: reimplement QTAILQ without pointer-to-pointers
2008a06 qemu/queue.h: remove Q_TAILQ_{HEAD, ENTRY}
47cf78f qemu/queue.h: typedef QTAILQ heads
20e1b87 qemu/queue.h: leave head structs anonymous unless necessary
f23f8d2 vfio: make vfio_address_spaces static
cc4e7ee qemu/queue.h: do not access tqe_prev directly
d563f32 test: replace gtester with a TAP driver
602d090 test: execute g_test_run when tests are skipped
19c5978 qga: drop < Vista compatibility
7ab6ef5 build-sys: build with Vista API by default
9597923 build-sys: move windows defines in osdep.h header
f00ee90 build-sys: don't include windows.h, osdep.h does it
d397fb2 scsi: esp: Defer command completion until previous interrupts have been handled
5868a6a esp-pci: Fix status register write erase control
21c3d03 block/iscsi: cancel libiscsi task when ABORT TASK TMF completes
04719ab block/iscsi: fix ioctl cancel use-after-free
a43e64e block/iscsi: take iscsilun->mutex in iscsi_timed_check_events()
67cce60 block/iscsi: drop unused IscsiAIOCB->buf field
6359fe7 hax: Support for Linux hosts
9a32ae1 memory: update coalesced_range on transaction_commit
8ddf23e memory: avoid unnecessary coalesced_io_del operations
922cf0d memory: extract flat_range_coalesced_io_{del, add}
2b40f43 pam: wrap MemoryRegion initialization in a transaction
a01d8ca6 checkpatch: colorize output to terminal
0848388 checkpatch: improve handling of multiple patches or files
9ca8c73 checkpatch: check Signed-off-by in --mailback mode
35c41e7 checkpatch: fix premature exit when no input or --mailback
d2ba5b1 vhost-user-bridge: fix "unknown type name" compilation error
60fb207 accel: Improve selection of the default accelerator
=== OUTPUT BEGIN ===
Checking PATCH 1/35: accel: Improve selection of the default accelerator...
Checking PATCH 2/35: vhost-user-bridge: fix "unknown type name" compilation error...
Checking PATCH 3/35: checkpatch: fix premature exit when no input or --mailback...
Checking PATCH 4/35: checkpatch: check Signed-off-by in --mailback mode...
Checking PATCH 5/35: checkpatch: improve handling of multiple patches or files...
ERROR: line over 90 characters
#33: FILE: scripts/checkpatch.pl:344:
+ open($HASH, "-|", "git", "log", "--reverse", "--no-merges", "--format=%H %s", $ARGV[0]) ||
ERROR: line over 90 characters
#34: FILE: scripts/checkpatch.pl:345:
+ die "$P: git log --reverse --no-merges --format='%H %s' $ARGV[0] failed - $!\n";
WARNING: line over 80 characters
#65: FILE: scripts/checkpatch.pl:372:
+ $vname = substr($hash, 0, 12) . ' (' . $git_commits{$hash} . ')';
total: 2 errors, 1 warnings, 62 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 6/35: checkpatch: colorize output to terminal...
Checking PATCH 7/35: pam: wrap MemoryRegion initialization in a transaction...
Checking PATCH 8/35: memory: extract flat_range_coalesced_io_{del, add}...
Checking PATCH 9/35: memory: avoid unnecessary coalesced_io_del operations...
Checking PATCH 10/35: memory: update coalesced_range on transaction_commit...
Checking PATCH 11/35: hax: Support for Linux hosts...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#62:
rename from target/i386/hax-darwin.c
total: 0 errors, 1 warnings, 31 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 12/35: block/iscsi: drop unused IscsiAIOCB->buf field...
Checking PATCH 13/35: block/iscsi: take iscsilun->mutex in iscsi_timed_check_events()...
Checking PATCH 14/35: block/iscsi: fix ioctl cancel use-after-free...
Checking PATCH 15/35: block/iscsi: cancel libiscsi task when ABORT TASK TMF completes...
Checking PATCH 16/35: esp-pci: Fix status register write erase control...
Checking PATCH 17/35: scsi: esp: Defer command completion until previous interrupts have been handled...
WARNING: Block comments use a leading /* on a separate line
#95: FILE: hw/scsi/esp.c:317:
+ /* Defer handling command complete until the previous
total: 0 errors, 1 warnings, 89 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 18/35: build-sys: don't include windows.h, osdep.h does it...
Checking PATCH 19/35: build-sys: move windows defines in osdep.h header...
WARNING: architecture specific defines should be avoided
#61: FILE: include/qemu/osdep.h:96:
+#ifdef __MINGW32__
total: 0 errors, 1 warnings, 39 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 20/35: build-sys: build with Vista API by default...
Checking PATCH 21/35: qga: drop < Vista compatibility...
Checking PATCH 22/35: test: execute g_test_run when tests are skipped...
Checking PATCH 23/35: test: replace gtester with a TAP driver...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#25:
deleted file mode 100755
total: 0 errors, 1 warnings, 618 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 24/35: qemu/queue.h: do not access tqe_prev directly...
Checking PATCH 25/35: vfio: make vfio_address_spaces static...
Checking PATCH 26/35: qemu/queue.h: leave head structs anonymous unless necessary...
Checking PATCH 27/35: qemu/queue.h: typedef QTAILQ heads...
Checking PATCH 28/35: qemu/queue.h: remove Q_TAILQ_{HEAD, ENTRY}...
WARNING: Block comments use a leading /* on a separate line
#26: FILE: include/qemu/queue.h:355:
+ type *tqh_first; /* first element */ \
WARNING: Block comments use a leading /* on a separate line
#27: FILE: include/qemu/queue.h:356:
+ type **tqh_last; /* addr of last next element */ \
WARNING: Block comments use a leading /* on a separate line
#39: FILE: include/qemu/queue.h:364:
+ type *tqe_next; /* next element */ \
WARNING: Block comments use a leading /* on a separate line
#40: FILE: include/qemu/queue.h:365:
+ type **tqe_prev; /* address of previous next element */ \
total: 0 errors, 4 warnings, 50 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 29/35: qemu/queue.h: reimplement QTAILQ without pointer-to-pointers...
WARNING: Block comments use a leading /* on a separate line
#61: FILE: include/qemu/queue.h:360:
+ struct type *tqh_first; /* first element */ \
WARNING: Block comments use a leading /* on a separate line
#62: FILE: include/qemu/queue.h:361:
+ QTailQLink tqh_circ; /* link for circular backwards list */ \
WARNING: Block comments use a leading /* on a separate line
#74: FILE: include/qemu/queue.h:369:
+ struct type *tqe_next; /* next element */ \
WARNING: Block comments use a leading /* on a separate line
#75: FILE: include/qemu/queue.h:370:
+ QTailQLink tqe_circ; /* link for circular backwards list */ \
WARNING: line over 80 characters
#176: FILE: include/qemu/queue.h:451:
+#define QTAILQ_IN_USE(elm, field) ((elm)->field.tqe_circ.tql_prev != NULL)
WARNING: line over 80 characters
#185: FILE: include/qemu/queue.h:458:
+ ((typeof((elm)->field.tqe_next)) QTAILQ_LINK_PREV((elm)->field.tqe_circ))
WARNING: line over 80 characters
#257: FILE: include/qemu/queue.h:489:
+#define QTAILQ_RAW_INSERT_TAIL(head, elm, entry) do { \
WARNING: line over 80 characters
#258: FILE: include/qemu/queue.h:490:
+ *QTAILQ_RAW_NEXT(elm, entry) = NULL; \
WARNING: line over 80 characters
#259: FILE: include/qemu/queue.h:491:
+ QTAILQ_RAW_TQE_CIRC(elm, entry)->tql_prev = QTAILQ_RAW_TQH_CIRC(head)->tql_prev; \
WARNING: line over 80 characters
#260: FILE: include/qemu/queue.h:492:
+ QTAILQ_RAW_TQH_CIRC(head)->tql_prev->tql_next = (elm); \
WARNING: line over 80 characters
#261: FILE: include/qemu/queue.h:493:
+ QTAILQ_RAW_TQH_CIRC(head)->tql_prev = QTAILQ_RAW_TQE_CIRC(elm, entry); \
WARNING: Block comments use a leading /* on a separate line
#323: FILE: include/qemu/rcu_queue.h:242:
+} while (/*CONSTCOND*/0)
WARNING: line over 80 characters
#336: FILE: include/qemu/rcu_queue.h:251:
+ atomic_set(&(elm)->field.tqe_circ.tql_prev->tql_next, (elm)->field.tqe_next); \
WARNING: Block comments use a leading /* on a separate line
#353: FILE: scripts/cocci-macro-file.h:97:
+ struct type *tqh_first; /* first element */ \
WARNING: Block comments use a leading /* on a separate line
#354: FILE: scripts/cocci-macro-file.h:98:
+ QTailQLink tqh_circ; /* link for last element */ \
WARNING: Block comments use a leading /* on a separate line
#366: FILE: scripts/cocci-macro-file.h:106:
+ struct type *tqe_next; /* next element */ \
WARNING: Block comments use a leading /* on a separate line
#367: FILE: scripts/cocci-macro-file.h:107:
+ QTailQLink tqe_circ; /* link for prev element */ \
total: 0 errors, 17 warnings, 315 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 30/35: qemu/queue.h: simplify reverse access to QTAILQ...
Checking PATCH 31/35: checkpatch: warn about qemu/queue.h head structs that are not typedef-ed...
WARNING: line over 80 characters
#21: FILE: scripts/checkpatch.pl:2313:
+ if ($line =~ /^.\s*(Q(?:S?LIST|SIMPLEQ|TAILQ)_HEAD)\s*\(\s*[^,]/ &&
WARNING: line over 80 characters
#23: FILE: scripts/checkpatch.pl:2315:
+ ERROR("named $1 should be typedefed separately\n" . $herecurr);
total: 0 errors, 2 warnings, 11 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 32/35: hw/watchdog/wdt_i6300esb: remove a unnecessary comment...
Checking PATCH 33/35: scripts: add script to convert multiline comments into 4-line format...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20:
new file mode 100755
total: 0 errors, 1 warnings, 62 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 34/35: remove space-tab sequences...
ERROR: code indent should never use tabs
#25: FILE: bsd-user/x86_64/target_syscall.h:15:
+^Iabi_ulong r11;$
ERROR: code indent should never use tabs
#38: FILE: crypto/aes.c:1074:
+^Iint i = 0;$
ERROR: code indent should never use tabs
#47: FILE: crypto/aes.c:1163:
+^I^I}$
ERROR: code indent should never use tabs
#56: FILE: crypto/aes.c:1250:
+^I/* round 2: */$
ERROR: code indent should never use tabs
#65: FILE: crypto/aes.c:1260:
+^I/* round 4: */$
ERROR: code indent should never use tabs
#74: FILE: crypto/aes.c:1270:
+^I/* round 6: */$
ERROR: code indent should never use tabs
#83: FILE: crypto/aes.c:1280:
+^I/* round 8: */$
ERROR: code indent should never use tabs
#92: FILE: crypto/aes.c:1572:
+^Is0 =$
ERROR: code indent should never use tabs
#98: FILE: crypto/aes.c:1577:
+^I^Irk[0];$
ERROR: code indent should never use tabs
#101: FILE: crypto/aes.c:1579:
+^Is1 =$
ERROR: code indent should never use tabs
#107: FILE: crypto/aes.c:1584:
+^I^Irk[1];$
ERROR: code indent should never use tabs
#110: FILE: crypto/aes.c:1586:
+^Is2 =$
ERROR: code indent should never use tabs
#116: FILE: crypto/aes.c:1591:
+^I^Irk[2];$
ERROR: code indent should never use tabs
#119: FILE: crypto/aes.c:1593:
+^Is3 =$
ERROR: code indent should never use tabs
#125: FILE: crypto/aes.c:1598:
+^I^Irk[3];$
ERROR: code indent should never use tabs
#138: FILE: disas/alpha.c:675:
+^I^Iwhich bits in the actual opcode must match OPCODE.$
ERROR: code indent should never use tabs
#147: FILE: disas/alpha.c:702:
+^I^Ibut with defined results on previous implementations.$
ERROR: code indent should never use tabs
#151: FILE: disas/alpha.c:705:
+^I^Ipresumably undefined results on previous implementations$
ERROR: code indent should never use tabs
#160: FILE: disas/alpha.c:835:
+^I^I^I0xFFFFFFE0, BASE, { RC } },^I^I/* ev56 but */$
ERROR: code indent should never use tabs
#173: FILE: disas/arm.c:1080:
+^I^I^I^I(top bit of range being the sign bit)$
ERROR: code indent should never use tabs
#186: FILE: disas/i386.c:6078:
+^I}$
ERROR: code indent should never use tabs
#195: FILE: disas/i386.c:6115:
+^I}$
ERROR: code indent should never use tabs
#208: FILE: disas/m68k.c:353:
+^I^I^I^I^I^I(not 0,1,7.2-4)$
ERROR: space required after that ',' (ctx:VxV)
#208: FILE: disas/m68k.c:353:
+ (not 0,1,7.2-4)
^
ERROR: space required after that ',' (ctx:VxV)
#208: FILE: disas/m68k.c:353:
+ (not 0,1,7.2-4)
^
ERROR: spaces required around that '-' (ctx:VxV)
#208: FILE: disas/m68k.c:353:
+ (not 0,1,7.2-4)
^
ERROR: code indent should never use tabs
#217: FILE: disas/m68k.c:1650:
+^I case 0x18: name = "%psr"; break;$
ERROR: trailing statements should be on next line
#217: FILE: disas/m68k.c:1650:
+ case 0x18: name = "%psr"; break;
ERROR: code indent should never use tabs
#245: FILE: include/hw/elf_ops.h:346:
+^I*pentry = (uint64_t)(elf_sword)ehdr.e_entry;$
ERROR: code indent should never use tabs
#258: FILE: linux-user/linuxload.c:57:
+^Ibprm->e_uid = st.st_uid;$
ERROR: code indent should never use tabs
#271: FILE: linux-user/syscall.c:905:
+^Ireturn target_brk;$
ERROR: code indent should never use tabs
#284: FILE: linux-user/syscall_defs.h:1810:
+^Iabi_long^Ist_blocks;^I/* Number 512-byte blocks allocated. */$
ERROR: code indent should never use tabs
#293: FILE: linux-user/syscall_defs.h:1819:
+^Iabi_long^I__unused[3];$
ERROR: code indent should never use tabs
#306: FILE: linux-user/x86_64/target_syscall.h:15:
+^Iabi_ulong r11;$
ERROR: suspect code indent for conditional statements (24, 27)
#317: FILE: slirp/ip_input.c:195:
if (fp)
+ ip_freef(slirp, fp);
ERROR: code indent should never use tabs
#319: FILE: slirp/ip_input.c:196:
+^I^I^I ip_freef(slirp, fp);$
ERROR: code indent should never use tabs
#328: FILE: slirp/ip_input.c:540:
+^I^I^I if ((ia = (INA)ifa_ifwithdstaddr((SA)&ipaddr)) == 0)$
ERROR: spaces required around that '&' (ctx:VxV)
#328: FILE: slirp/ip_input.c:540:
+ if ((ia = (INA)ifa_ifwithdstaddr((SA)&ipaddr)) == 0)
^
ERROR: do not use assignment in if condition
#328: FILE: slirp/ip_input.c:540:
+ if ((ia = (INA)ifa_ifwithdstaddr((SA)&ipaddr)) == 0)
ERROR: braces {} are necessary for all arms of this statement
#328: FILE: slirp/ip_input.c:540:
+ if ((ia = (INA)ifa_ifwithdstaddr((SA)&ipaddr)) == 0)
[...]
ERROR: code indent should never use tabs
#341: FILE: slirp/tcp_input.c:77:
+^I^I sbappend((so), (m)); \$
ERROR: code indent should never use tabs
#350: FILE: slirp/tcp_input.c:1178:
+^I^I/*$
ERROR: code indent should never use tabs
#359: FILE: slirp/tcp_input.c:1328:
+^I^I/*$
ERROR: code indent should never use tabs
#368: FILE: slirp/tcp_input.c:1340:
+^I^I/*$
ERROR: code indent should never use tabs
#377: FILE: slirp/tcp_input.c:1348:
+^I^I/*$
ERROR: code indent should never use tabs
#390: FILE: slirp/tcp_output.c:278:
+^I}$
ERROR: code indent should never use tabs
#393: FILE: slirp/tcp_output.c:280:
+^Ihdrlen += optlen;$
ERROR: code indent should never use tabs
#406: FILE: slirp/tcp_timer.c:266:
+^I^I^Iif (tp->t_idle >= TCPTV_KEEP_IDLE + TCP_MAXIDLE)$
ERROR: braces {} are necessary for all arms of this statement
#406: FILE: slirp/tcp_timer.c:266:
+ if (tp->t_idle >= TCPTV_KEEP_IDLE + TCP_MAXIDLE)
[...]
ERROR: code indent should never use tabs
#419: FILE: slirp/udp.c:313:
+^I^I^Iso->so_emu = udptos[i].emu;$
WARNING: line over 80 characters
#434: FILE: tests/tcg/arm/hello-arm.c:81:
+ : "=r" (__res) \
ERROR: code indent should never use tabs
#434: FILE: tests/tcg/arm/hello-arm.c:81:
+^I: "=r" (__res)^I^I^I^I^I^I^I^I^I\$
WARNING: line over 80 characters
#435: FILE: tests/tcg/arm/hello-arm.c:82:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)) \
ERROR: code indent should never use tabs
#435: FILE: tests/tcg/arm/hello-arm.c:82:
+^I: "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4))^I\$
ERROR: space required after that ',' (ctx:VxV)
#435: FILE: tests/tcg/arm/hello-arm.c:82:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)) \
^
ERROR: space required after that ',' (ctx:VxV)
#435: FILE: tests/tcg/arm/hello-arm.c:82:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)) \
^
ERROR: space required after that ',' (ctx:VxV)
#435: FILE: tests/tcg/arm/hello-arm.c:82:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)) \
^
WARNING: line over 80 characters
#436: FILE: tests/tcg/arm/hello-arm.c:83:
+ : "r0","r1","r2","r3","lr"); \
ERROR: code indent should never use tabs
#436: FILE: tests/tcg/arm/hello-arm.c:83:
+^I: "r0","r1","r2","r3","lr");^I^I^I^I^I^I^I\$
ERROR: space required after that ',' (ctx:VxV)
#436: FILE: tests/tcg/arm/hello-arm.c:83:
+ : "r0","r1","r2","r3","lr"); \
^
ERROR: space required after that ',' (ctx:VxV)
#436: FILE: tests/tcg/arm/hello-arm.c:83:
+ : "r0","r1","r2","r3","lr"); \
^
ERROR: space required after that ',' (ctx:VxV)
#436: FILE: tests/tcg/arm/hello-arm.c:83:
+ : "r0","r1","r2","r3","lr"); \
^
ERROR: space required after that ',' (ctx:VxV)
#436: FILE: tests/tcg/arm/hello-arm.c:83:
+ : "r0","r1","r2","r3","lr"); \
^
WARNING: line over 80 characters
#446: FILE: tests/tcg/arm/hello-arm.c:99:
+ : "=r" (__res) \
ERROR: code indent should never use tabs
#446: FILE: tests/tcg/arm/hello-arm.c:99:
+^I: "=r" (__res)^I^I^I^I^I^I^I^I^I\$
WARNING: line over 80 characters
#447: FILE: tests/tcg/arm/hello-arm.c:100:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)), \
ERROR: code indent should never use tabs
#447: FILE: tests/tcg/arm/hello-arm.c:100:
+^I: "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)),^I\$
ERROR: space required after that ',' (ctx:VxV)
#447: FILE: tests/tcg/arm/hello-arm.c:100:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)), \
^
ERROR: space required after that ',' (ctx:VxV)
#447: FILE: tests/tcg/arm/hello-arm.c:100:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)), \
^
ERROR: space required after that ',' (ctx:VxV)
#447: FILE: tests/tcg/arm/hello-arm.c:100:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)), \
^
total: 65 errors, 5 warnings, 328 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 35/35: avoid TABs in files that only contain a few...
ERROR: braces {} are necessary for all arms of this statement
#536: FILE: hw/char/xen_console.c:89:
+ if (buffer->consumed > buffer->max_capacity - over)
[...]
ERROR: braces {} are necessary for all arms of this statement
#640: FILE: hw/core/loader.c:249:
+ if (size < 0)
[...]
ERROR: braces {} are necessary for all arms of this statement
#652: FILE: hw/core/loader.c:257:
+ if (size < 0)
[...]
ERROR: braces {} are necessary for all arms of this statement
#660: FILE: hw/core/loader.c:261:
+ if (ret < 0)
[...]
ERROR: space prohibited before that close parenthesis ')'
#716: FILE: hw/display/vga.c:91:
+ (((uint32_t)(__x) & (uint32_t)0xff000000UL) >> 24) ))
ERROR: braces {} are necessary for all arms of this statement
#755: FILE: hw/dma/pxa2xx_dma.c:286:
+ if (s->chan[channel].request)
[...]
ERROR: braces {} are necessary for all arms of this statement
#873: FILE: hw/ide/core.c:1191:
+ if (!s->nsector)
[...]
WARNING: Block comments use a trailing */ on a separate line
#1019: FILE: hw/input/pckbd.c:58:
+ initiated by the auxiliary device */
ERROR: braces {} are necessary for all arms of this statement
#1045: FILE: hw/intc/apic.c:445:
+ if (apic && apic->id == dest)
[...]
ERROR: code indent should never use tabs
#1111: FILE: hw/misc/max111x.c:46:
+ ((((v) >> (2 + (b0))) & 4) |^I\$
ERROR: code indent should never use tabs
#1112: FILE: hw/misc/max111x.c:47:
+ (((v) >> (3 + (b1))) & 2) |^I\$
ERROR: code indent should never use tabs
#1141: FILE: hw/net/mipsnet.c:115:
+ ret = be32_to_cpu(0x4d495053);^I^I/* MIPS */$
ERROR: code indent should never use tabs
#1145: FILE: hw/net/mipsnet.c:118:
+ ret = be32_to_cpu(0x4e455430);^I^I/* NET0 */$
ERROR: code indent should never use tabs
#1238: FILE: hw/net/ne2000.c:430:
+ ret = 0;^I^I/* 10baseT media */$
ERROR: code indent should never use tabs
#1241: FILE: hw/net/ne2000.c:433:
+ ret = 0x40;^I^I/* 10baseT active */$
ERROR: code indent should never use tabs
#1244: FILE: hw/net/ne2000.c:436:
+ ret = 0x40;^I^I/* Full duplex */$
ERROR: consider using qemu_strtoul in preference to strtoul
#1375: FILE: hw/pci/pci.c:631:
+ val = strtoul(p, &e, 16);
ERROR: braces {} are necessary for all arms of this statement
#1376: FILE: hw/pci/pci.c:632:
+ if (e == p)
[...]
ERROR: consider using qemu_strtoul in preference to strtoul
#1382: FILE: hw/pci/pci.c:638:
+ val = strtoul(p, &e, 16);
ERROR: braces {} are necessary for all arms of this statement
#1383: FILE: hw/pci/pci.c:639:
+ if (e == p)
[...]
ERROR: code indent should never use tabs
#1574: FILE: hw/usb/dev-hub.c:150:
+ 0x00,^I^I^I/* u8 bLength; patched in later */$
ERROR: code indent should never use tabs
#1575: FILE: hw/usb/dev-hub.c:151:
+ 0x29,^I^I^I/* u8 bDescriptorType; Hub-descriptor */$
ERROR: code indent should never use tabs
#1576: FILE: hw/usb/dev-hub.c:152:
+ 0x00,^I^I^I/* u8 bNbrPorts; (patched later) */$
ERROR: code indent should never use tabs
#1577: FILE: hw/usb/dev-hub.c:153:
+ 0x0a,^I^I^I/* u16 wHubCharacteristics; */$
ERROR: code indent should never use tabs
#1578: FILE: hw/usb/dev-hub.c:154:
+ 0x00,^I^I^I/* (per-port OC, no power switching) */$
ERROR: code indent should never use tabs
#1579: FILE: hw/usb/dev-hub.c:155:
+ 0x01,^I^I^I/* u8 bPwrOn2pwrGood; 2ms */$
ERROR: code indent should never use tabs
#1580: FILE: hw/usb/dev-hub.c:156:
+ 0x00^I^I^I/* u8 bHubContrCurrent; 0 mA */$
ERROR: space required after that ',' (ctx:VxV)
#1621: FILE: hw/xenpv/xen_domainbuild.c:85:
+ snprintf(path, sizeof(path), "cpu/%d/availability",i);
^
WARNING: Block comments use a trailing */ on a separate line
#1635: FILE: include/elf.h:785:
+ in the input to a link step */
WARNING: Block comments use a trailing */ on a separate line
#1640: FILE: include/elf.h:789:
+ addressed by the static base */
WARNING: Block comments use a trailing */ on a separate line
#1649: FILE: include/elf.h:1050:
+ offset to GOT */
WARNING: Block comments use a trailing */ on a separate line
#1658: FILE: include/elf.h:1073:
+ prediction. */
WARNING: Block comments use a trailing */ on a separate line
#1667: FILE: include/elf.h:1086:
+ symbols in ANSI C. */
ERROR: code indent should never use tabs
#1768: FILE: include/hw/xen/io/ring.h:238:
+ /* Use volatile to force the copy into _req. */^I^I^I\$
WARNING: Block comments use a leading /* on a separate line
#1768: FILE: include/hw/xen/io/ring.h:238:
+ /* Use volatile to force the copy into _req. */ \
ERROR: code indent should never use tabs
#1769: FILE: include/hw/xen/io/ring.h:239:
+ *(_req) = *(volatile typeof(_req))RING_GET_REQUEST(_r, _idx);^I\$
WARNING: Block comments use a trailing */ on a separate line
#1825: FILE: include/scsi/constants.h:215:
+ * - treated as TYPE_DISK */
ERROR: return is not a function, parentheses are not required
#1851: FILE: linux-user/linuxload.c:41:
+ return(-errno);
ERROR: return is not a function, parentheses are not required
#1857: FILE: linux-user/linuxload.c:46:
+ return(-EACCES);
ERROR: return is not a function, parentheses are not required
#1861: FILE: linux-user/linuxload.c:49:
+ return(-EACCES);
ERROR: code indent should never use tabs
#1936: FILE: linux-user/qemu.h:53:
+ int^I^Ipersonality;$
ERROR: braces {} are necessary for all arms of this statement
#1969: FILE: linux-user/signal.c:740:
+ if (on_sig_stack(sp))
[...]
ERROR: spaces required around that '+' (ctx:VxV)
#2061: FILE: net/checksum.c:46:
+ sum = (sum & 0xFFFF)+(sum >> 16);
^
ERROR: code indent should never use tabs
#2279: FILE: tests/tcg/arm/hello-arm.c:14:
+ return (type) (res);^I^I^I^I^I^I\$
ERROR: code indent should never use tabs
#2288: FILE: tests/tcg/arm/hello-arm.c:36:
+ : "r0","lr");^I^I^I^I^I^I^I\$
ERROR: space required after that ',' (ctx:VxV)
#2288: FILE: tests/tcg/arm/hello-arm.c:36:
+ : "r0","lr"); \
^
ERROR: code indent should never use tabs
#2297: FILE: tests/tcg/arm/hello-arm.c:50:
+ : "r0","r1","lr");^I^I^I^I^I^I\$
ERROR: space required after that ',' (ctx:VxV)
#2297: FILE: tests/tcg/arm/hello-arm.c:50:
+ : "r0","r1","lr"); \
^
ERROR: space required after that ',' (ctx:VxV)
#2297: FILE: tests/tcg/arm/hello-arm.c:50:
+ : "r0","r1","lr"); \
^
WARNING: line over 80 characters
#2308: FILE: tests/tcg/arm/hello-arm.c:81:
+ : "=r" (__res) \
ERROR: code indent should never use tabs
#2308: FILE: tests/tcg/arm/hello-arm.c:81:
+ : "=r" (__res)^I^I^I^I^I^I^I^I^I\$
WARNING: line over 80 characters
#2309: FILE: tests/tcg/arm/hello-arm.c:82:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)) \
ERROR: code indent should never use tabs
#2309: FILE: tests/tcg/arm/hello-arm.c:82:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4))^I\$
ERROR: space required after that ',' (ctx:VxV)
#2309: FILE: tests/tcg/arm/hello-arm.c:82:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)) \
^
ERROR: space required after that ',' (ctx:VxV)
#2309: FILE: tests/tcg/arm/hello-arm.c:82:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)) \
^
ERROR: space required after that ',' (ctx:VxV)
#2309: FILE: tests/tcg/arm/hello-arm.c:82:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)) \
^
WARNING: line over 80 characters
#2310: FILE: tests/tcg/arm/hello-arm.c:83:
+ : "r0","r1","r2","r3","lr"); \
ERROR: code indent should never use tabs
#2310: FILE: tests/tcg/arm/hello-arm.c:83:
+ : "r0","r1","r2","r3","lr");^I^I^I^I^I^I^I\$
ERROR: space required after that ',' (ctx:VxV)
#2310: FILE: tests/tcg/arm/hello-arm.c:83:
+ : "r0","r1","r2","r3","lr"); \
^
ERROR: space required after that ',' (ctx:VxV)
#2310: FILE: tests/tcg/arm/hello-arm.c:83:
+ : "r0","r1","r2","r3","lr"); \
^
ERROR: space required after that ',' (ctx:VxV)
#2310: FILE: tests/tcg/arm/hello-arm.c:83:
+ : "r0","r1","r2","r3","lr"); \
^
ERROR: space required after that ',' (ctx:VxV)
#2310: FILE: tests/tcg/arm/hello-arm.c:83:
+ : "r0","r1","r2","r3","lr"); \
^
WARNING: line over 80 characters
#2322: FILE: tests/tcg/arm/hello-arm.c:99:
+ : "=r" (__res) \
ERROR: code indent should never use tabs
#2322: FILE: tests/tcg/arm/hello-arm.c:99:
+ : "=r" (__res)^I^I^I^I^I^I^I^I^I\$
WARNING: line over 80 characters
#2323: FILE: tests/tcg/arm/hello-arm.c:100:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)), \
ERROR: code indent should never use tabs
#2323: FILE: tests/tcg/arm/hello-arm.c:100:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)),^I\$
ERROR: space required after that ',' (ctx:VxV)
#2323: FILE: tests/tcg/arm/hello-arm.c:100:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)), \
^
ERROR: space required after that ',' (ctx:VxV)
#2323: FILE: tests/tcg/arm/hello-arm.c:100:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)), \
^
ERROR: space required after that ',' (ctx:VxV)
#2323: FILE: tests/tcg/arm/hello-arm.c:100:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)), \
^
WARNING: line over 80 characters
#2324: FILE: tests/tcg/arm/hello-arm.c:101:
+ "r" ((long)(arg5)) \
ERROR: code indent should never use tabs
#2324: FILE: tests/tcg/arm/hello-arm.c:101:
+ "r" ((long)(arg5))^I^I^I^I^I^I^I^I\$
WARNING: line over 80 characters
#2325: FILE: tests/tcg/arm/hello-arm.c:102:
+ : "r0","r1","r2","r3","r4","lr"); \
ERROR: code indent should never use tabs
#2325: FILE: tests/tcg/arm/hello-arm.c:102:
+ : "r0","r1","r2","r3","r4","lr");^I^I^I^I^I^I\$
ERROR: space required after that ',' (ctx:VxV)
#2325: FILE: tests/tcg/arm/hello-arm.c:102:
+ : "r0","r1","r2","r3","r4","lr"); \
^
ERROR: space required after that ',' (ctx:VxV)
#2325: FILE: tests/tcg/arm/hello-arm.c:102:
+ : "r0","r1","r2","r3","r4","lr"); \
^
ERROR: space required after that ',' (ctx:VxV)
#2325: FILE: tests/tcg/arm/hello-arm.c:102:
+ : "r0","r1","r2","r3","r4","lr"); \
^
ERROR: space required after that ',' (ctx:VxV)
#2325: FILE: tests/tcg/arm/hello-arm.c:102:
+ : "r0","r1","r2","r3","r4","lr"); \
^
ERROR: space required after that ',' (ctx:VxV)
#2325: FILE: tests/tcg/arm/hello-arm.c:102:
+ : "r0","r1","r2","r3","r4","lr"); \
^
ERROR: braces {} are necessary for all arms of this statement
#2341: FILE: tests/tcg/cris/check_glibc_kernelversion.c:112:
+ if (version < __LINUX_KERNEL_VERSION)
[...]
ERROR: space prohibited between function name and open parenthesis '('
#2368: FILE: tests/tcg/cris/check_openpf1.c:22:
+ abort ();
ERROR: Use of volatile is usually wrong, please add a comment
#2381: FILE: tests/tcg/cris/check_settls1.c:38:
+ * (volatile int *) 0 = 0;
ERROR: space required after that ',' (ctx:VxV)
#2396: FILE: tests/tcg/i386/hello-i386.c:8:
+ : "=a" (__res) : "0" (__NR_exit),"c" ((long)(status)));
^
ERROR: line over 90 characters
#2412: FILE: tests/tcg/i386/hello-i386.c:19:
+ : "0" (__NR_write),"S" ((long)(fd)),"c" ((long)(buf)),"d" ((long)(len)));
ERROR: space required after that ',' (ctx:VxV)
#2412: FILE: tests/tcg/i386/hello-i386.c:19:
+ : "0" (__NR_write),"S" ((long)(fd)),"c" ((long)(buf)),"d" ((long)(len)));
^
ERROR: space required after that ',' (ctx:VxV)
#2412: FILE: tests/tcg/i386/hello-i386.c:19:
+ : "0" (__NR_write),"S" ((long)(fd)),"c" ((long)(buf)),"d" ((long)(len)));
^
ERROR: space required after that ',' (ctx:VxV)
#2412: FILE: tests/tcg/i386/hello-i386.c:19:
+ : "0" (__NR_write),"S" ((long)(fd)),"c" ((long)(buf)),"d" ((long)(len)));
^
ERROR: unnecessary whitespace before a quoted newline
#2421: FILE: tests/tcg/mips/hello-mips.c:24:
" syscall \n"
ERROR: braces {} are necessary for all arms of this statement
#2468: FILE: tests/tcg/multiarch/sha1.c:192:
+ for (j = 0; j < 4; t >>= 8, j++)
[...]
WARNING: line over 80 characters
#2492: FILE: tests/vhost-user-test.c:357:
+ g_assert_cmpint(msg.payload.u64 & (0x1ULL << VHOST_USER_F_PROTOCOL_FEATURES),
ERROR: "foo* bar" should be "foo *bar"
#2507: FILE: ui/keymaps.h:31:
+ const char* name;
ERROR: space required after that ',' (ctx:VxV)
#2602: FILE: util/qemu-sockets.c:273:
+ uaddr,INET6_ADDRSTRLEN,uport,32,
^
ERROR: space required after that ',' (ctx:VxV)
#2602: FILE: util/qemu-sockets.c:273:
+ uaddr,INET6_ADDRSTRLEN,uport,32,
^
ERROR: space required after that ',' (ctx:VxV)
#2602: FILE: util/qemu-sockets.c:273:
+ uaddr,INET6_ADDRSTRLEN,uport,32,
^
total: 77 errors, 16 warnings, 1903 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20181219151917.3874-1-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
The following changes since commit e85c577158a2e8e252414959da9ef15c12eec63d: Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2018-12-17' into staging (2018-12-18 14:31:06 +0000) are available in the Git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to b4e8bbb9ae50045160957e7ab66c4f1cae535ea4: avoid TABs in files that only contain a few (2018-12-19 16:03:22 +0100) ---------------------------------------------------------------- * HAX support for Linux hosts (Alejandro) * esp bugfixes (Guenter) * Windows build cleanup (Marc-André) * checkpatch logic improvements (Paolo) * coalesced range bugfix (Paolo) * switch testsuite to TAP (Paolo) * QTAILQ rewrite (Paolo) * block/iscsi.c cancellation fixes (Stefan) * improve selection of the default accelerator (Thomas) ---------------------------------------------------------------- v1->v2: more g_test_run fixes do not force-enable colors Alexandro Sanchez Bach (1): hax: Support for Linux hosts Guenter Roeck (2): esp-pci: Fix status register write erase control scsi: esp: Defer command completion until previous interrupts have been handled Marc-André Lureau (5): vhost-user-bridge: fix "unknown type name" compilation error build-sys: don't include windows.h, osdep.h does it build-sys: move windows defines in osdep.h header build-sys: build with Vista API by default qga: drop < Vista compatibility Paolo Bonzini (21): checkpatch: fix premature exit when no input or --mailback checkpatch: check Signed-off-by in --mailback mode checkpatch: improve handling of multiple patches or files checkpatch: colorize output to terminal pam: wrap MemoryRegion initialization in a transaction memory: extract flat_range_coalesced_io_{del,add} memory: avoid unnecessary coalesced_io_del operations memory: update coalesced_range on transaction_commit test: execute g_test_run when tests are skipped test: replace gtester with a TAP driver qemu/queue.h: do not access tqe_prev directly vfio: make vfio_address_spaces static qemu/queue.h: leave head structs anonymous unless necessary qemu/queue.h: typedef QTAILQ heads qemu/queue.h: remove Q_TAILQ_{HEAD,ENTRY} qemu/queue.h: reimplement QTAILQ without pointer-to-pointers qemu/queue.h: simplify reverse access to QTAILQ checkpatch: warn about qemu/queue.h head structs that are not typedef-ed scripts: add script to convert multiline comments into 4-line format remove space-tab sequences avoid TABs in files that only contain a few Peng Hao (1): hw/watchdog/wdt_i6300esb: remove a unnecessary comment Stefan Hajnoczi (4): block/iscsi: drop unused IscsiAIOCB->buf field block/iscsi: take iscsilun->mutex in iscsi_timed_check_events() block/iscsi: fix ioctl cancel use-after-free block/iscsi: cancel libiscsi task when ABORT TASK TMF completes Thomas Huth (1): accel: Improve selection of the default accelerator accel/accel.c | 18 +- accel/kvm/kvm-all.c | 4 +- accel/tcg/translate-all.c | 4 - block/bochs.c | 22 +- block/file-posix.c | 2 +- block/file-win32.c | 8 +- block/gluster.c | 2 +- block/iscsi.c | 47 +++- block/linux-aio.c | 4 +- block/mirror.c | 2 +- block/qcow2-bitmap.c | 4 +- block/qcow2-cluster.c | 2 +- block/qcow2.h | 5 +- block/sheepdog.c | 6 +- block/vhdx.h | 2 +- block/vpc.c | 2 +- blockdev.c | 4 +- bsd-user/elfload.c | 2 +- bsd-user/x86_64/target_syscall.h | 2 +- configure | 3 - contrib/elf2dmp/main.c | 2 +- contrib/ivshmem-client/ivshmem-client.h | 4 +- contrib/ivshmem-server/ivshmem-server.h | 5 +- cpus-common.c | 2 +- crypto/aes.c | 28 +- disas/alpha.c | 8 +- disas/arm.c | 2 +- disas/i386.c | 4 +- disas/m68k.c | 4 +- dump.c | 2 +- exec.c | 5 +- fsdev/qemu-fsdev.c | 2 +- hw/alpha/typhoon.c | 12 +- hw/arm/stellaris.c | 2 +- hw/block/nvme.h | 8 +- hw/block/xen_disk.c | 6 +- hw/char/sh_serial.c | 18 +- hw/char/virtio-serial-bus.c | 2 +- hw/char/xen_console.c | 58 ++-- hw/core/loader.c | 28 +- hw/core/qdev.c | 4 +- hw/core/reset.c | 2 +- hw/display/tc6393xb.c | 6 +- hw/display/vga.c | 8 +- hw/display/virtio-gpu-3d.c | 6 +- hw/dma/pxa2xx_dma.c | 4 +- hw/dma/soc_dma.c | 2 +- hw/gpio/max7310.c | 2 +- hw/i386/xen/xen-hvm.c | 4 +- hw/i386/xen/xen-mapcache.c | 2 +- hw/ide/core.c | 94 +++---- hw/input/lm832x.c | 2 +- hw/input/pckbd.c | 2 +- hw/input/tsc210x.c | 2 +- hw/intc/apic.c | 2 +- hw/mips/gt64xxx_pci.c | 6 +- hw/mips/mips_r4k.c | 4 +- hw/misc/max111x.c | 6 +- hw/misc/omap_l4.c | 4 +- hw/net/mipsnet.c | 16 +- hw/net/ne2000.c | 44 ++-- hw/net/rocker/rocker.c | 2 +- hw/net/virtio-net.c | 4 +- hw/net/vmxnet3.c | 6 +- hw/pci-host/pam.c | 2 + hw/pci/msix.c | 2 +- hw/pci/pci.c | 44 ++-- hw/pci/pci_bridge.c | 2 +- hw/ppc/ppc405_uc.c | 2 +- hw/ppc/prep.c | 4 +- hw/ppc/spapr_iommu.c | 2 +- hw/scsi/esp-pci.c | 10 +- hw/scsi/esp.c | 33 ++- hw/scsi/lsi53c895a.c | 6 +- hw/scsi/scsi-bus.c | 2 +- hw/scsi/trace-events | 1 + hw/sh4/r2d.c | 16 +- hw/usb/ccid-card-emulated.c | 4 +- hw/usb/combined-packet.c | 2 +- hw/usb/dev-bluetooth.c | 2 +- hw/usb/dev-hid.c | 6 +- hw/usb/dev-hub.c | 14 +- hw/usb/dev-mtp.c | 4 +- hw/usb/dev-network.c | 2 +- hw/usb/hcd-ehci.c | 2 +- hw/usb/hcd-ehci.h | 2 +- hw/usb/hcd-uhci.c | 8 +- hw/usb/xen-usb.c | 6 +- hw/vfio/common.c | 4 +- hw/watchdog/watchdog.c | 2 +- hw/watchdog/wdt_i6300esb.c | 1 - hw/xen/xen_devconfig.c | 2 +- hw/xen/xen_pvdev.c | 4 +- hw/xenpv/xen_domainbuild.c | 8 +- include/elf.h | 10 +- include/exec/memory.h | 6 +- include/hw/acpi/acpi.h | 14 +- include/hw/elf_ops.h | 2 +- include/hw/ide/internal.h | 2 +- include/hw/qdev-core.h | 2 +- include/hw/scsi/esp.h | 2 + include/hw/sh4/sh_intc.h | 20 +- include/hw/usb.h | 2 +- include/hw/vfio/vfio-common.h | 4 +- include/hw/vfio/vfio-platform.h | 2 +- include/hw/xen/io/ring.h | 4 +- include/net/net.h | 2 +- include/qemu/acl.h | 14 +- include/qemu/iov.h | 2 +- include/qemu/option_int.h | 2 +- include/qemu/osdep.h | 17 ++ include/qemu/queue.h | 153 +++++------ include/qemu/rcu_queue.h | 45 ++-- include/qom/cpu.h | 9 +- include/scsi/constants.h | 2 +- include/sysemu/accel.h | 2 +- include/sysemu/balloon.h | 2 +- include/sysemu/kvm.h | 2 - include/sysemu/memory_mapping.h | 2 +- include/sysemu/rng.h | 2 +- linux-user/elfload.c | 2 +- linux-user/linuxload.c | 14 +- linux-user/main.c | 4 +- linux-user/mmap.c | 10 +- linux-user/qemu.h | 4 +- linux-user/signal.c | 16 +- linux-user/strace.c | 4 +- linux-user/syscall.c | 2 +- linux-user/syscall_defs.h | 4 +- linux-user/uaccess.c | 2 +- linux-user/vm86.c | 2 +- linux-user/x86_64/target_syscall.h | 2 +- memory.c | 97 ++++--- memory_mapping.c | 2 +- migration/block-dirty-bitmap.c | 2 +- migration/block.c | 4 +- migration/ram.c | 2 +- monitor.c | 4 +- nbd/client.c | 2 +- net/checksum.c | 2 +- net/filter.c | 2 +- net/net.c | 2 +- net/queue.c | 2 +- net/slirp.c | 2 +- qga/commands-posix.c | 2 +- qga/commands-win32.c | 70 +---- qtest.c | 4 +- scripts/checkpatch.pl | 95 +++++-- scripts/cocci-macro-file.h | 24 +- scripts/fix-multiline-comments.sh | 62 +++++ scripts/gtester-cat | 26 -- scripts/tap-driver.pl | 378 +++++++++++++++++++++++++++ scripts/tap-merge.pl | 110 ++++++++ slirp/ip_input.c | 4 +- slirp/slirp.c | 2 +- slirp/tcp_input.c | 10 +- slirp/tcp_output.c | 4 +- slirp/tcp_timer.c | 2 +- slirp/udp.c | 2 +- target/alpha/translate.c | 2 +- target/arm/kvm.c | 2 +- target/cris/helper.c | 2 +- target/cris/mmu.h | 10 +- target/cris/translate_v10.inc.c | 2 +- target/i386/Makefile.objs | 6 +- target/i386/hax-i386.h | 6 +- target/i386/hax-mem.c | 2 +- target/i386/{hax-darwin.c => hax-posix.c} | 0 target/i386/{hax-darwin.h => hax-posix.h} | 0 target/i386/translate.c | 12 +- target/mips/translate.c | 2 +- target/tilegx/translate.c | 2 +- tcg/i386/tcg-target.inc.c | 4 +- tcg/tcg.c | 2 +- tcg/tcg.h | 6 +- tests/Makefile.include | 54 ++-- tests/cdrom-test.c | 2 +- tests/docker/dockerfiles/centos7.docker | 1 + tests/docker/dockerfiles/debian-amd64.docker | 1 + tests/docker/dockerfiles/debian-ports.docker | 1 + tests/docker/dockerfiles/debian-sid.docker | 1 + tests/docker/dockerfiles/debian8.docker | 1 + tests/docker/dockerfiles/debian9.docker | 1 + tests/docker/dockerfiles/fedora.docker | 1 + tests/docker/dockerfiles/ubuntu.docker | 1 + tests/ivshmem-test.c | 5 +- tests/libqos/malloc.c | 2 +- tests/migration-test.c | 8 +- tests/tcg/alpha/test-cond.c | 4 +- tests/tcg/arm/hello-arm.c | 20 +- tests/tcg/cris/check_glibc_kernelversion.c | 8 +- tests/tcg/cris/check_mmap3.c | 2 +- tests/tcg/cris/check_openpf1.c | 2 +- tests/tcg/cris/check_settls1.c | 2 +- tests/tcg/i386/hello-i386.c | 14 +- tests/tcg/mips/hello-mips.c | 10 +- tests/tcg/multiarch/sha1.c | 12 +- tests/test-crypto-pbkdf.c | 4 +- tests/test-rcu-list.c | 2 +- tests/test-vmstate.c | 8 +- tests/vhost-user-bridge.c | 3 +- tests/vhost-user-test.c | 4 +- ui/console.c | 4 +- ui/input.c | 14 +- ui/keymaps.h | 4 +- ui/qemu-pixman.c | 2 +- ui/vnc-enc-zywrle-template.c | 4 +- ui/vnc.c | 4 +- util/bitops.c | 4 +- util/osdep.c | 4 +- util/qemu-option.c | 4 +- util/qemu-sockets.c | 4 +- util/qemu-thread-win32.c | 4 - vl.c | 4 +- 214 files changed, 1487 insertions(+), 893 deletions(-) create mode 100755 scripts/fix-multiline-comments.sh delete mode 100755 scripts/gtester-cat create mode 100755 scripts/tap-driver.pl create mode 100755 scripts/tap-merge.pl rename target/i386/{hax-darwin.c => hax-posix.c} (100%) rename target/i386/{hax-darwin.h => hax-posix.h} (100%)