Message ID | 20190103172151.24706-1-philmd@redhat.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | docker: Use stable git tag for virglrenderer | expand |
On Thu, Jan 3, 2019 at 6:22 PM Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > > Use a stable tag instead of some random commit from mainstream > development, to avoid unexpected build failures. > > This fixes: > > CC virglrenderer.lo > virglrenderer.c: In function 'virgl_has_gl_colorspace': > virglrenderer.c:208:11: error: implicit declaration of function 'virgl_has_egl_khr_gl_colorspace' [-Werror=implicit-function-declaration] > virgl_has_egl_khr_gl_colorspace(egl_info)); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > virglrenderer.c:208:43: error: 'egl_info' undeclared (first use in this function) > virgl_has_egl_khr_gl_colorspace(egl_info)); > ^~~~~~~~ > virglrenderer.c:208:43: note: each undeclared identifier is reported only once for each function it appears in > cc1: some warnings being treated as errors > > As of this commit 'git virglrenderer-0.7.0' is the last stable tag. > (virglrenderer commit breaking: fb4f7577f7ef) Success on Shippable: https://app.shippable.com/github/philmd/qemu/runs/310/summary/console
Philippe Mathieu-Daudé <philmd@redhat.com> writes: > Use a stable tag instead of some random commit from mainstream > development, to avoid unexpected build failures. > <snip> Queued to testing/next, thanks. -- Alex Bennée
diff --git a/tests/docker/dockerfiles/debian-amd64.docker b/tests/docker/dockerfiles/debian-amd64.docker index 24b113b76f..47a30adbdb 100644 --- a/tests/docker/dockerfiles/debian-amd64.docker +++ b/tests/docker/dockerfiles/debian-amd64.docker @@ -24,7 +24,8 @@ RUN DEBIAN_FRONTEND=noninteractive eatmydata \ libegl1-mesa-dev \ libepoxy-dev \ libgbm-dev -RUN git clone https://anongit.freedesktop.org/git/virglrenderer.git /usr/src/virglrenderer +RUN git clone https://anongit.freedesktop.org/git/virglrenderer.git /usr/src/virglrenderer && \ + cd /usr/src/virglrenderer && git checkout virglrenderer-0.7.0 RUN cd /usr/src/virglrenderer && ./autogen.sh && ./configure --with-glx --disable-tests && make install # netmap
Use a stable tag instead of some random commit from mainstream development, to avoid unexpected build failures. This fixes: CC virglrenderer.lo virglrenderer.c: In function 'virgl_has_gl_colorspace': virglrenderer.c:208:11: error: implicit declaration of function 'virgl_has_egl_khr_gl_colorspace' [-Werror=implicit-function-declaration] virgl_has_egl_khr_gl_colorspace(egl_info)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ virglrenderer.c:208:43: error: 'egl_info' undeclared (first use in this function) virgl_has_egl_khr_gl_colorspace(egl_info)); ^~~~~~~~ virglrenderer.c:208:43: note: each undeclared identifier is reported only once for each function it appears in cc1: some warnings being treated as errors As of this commit 'git virglrenderer-0.7.0' is the last stable tag. (virglrenderer commit breaking: fb4f7577f7ef) Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- tests/docker/dockerfiles/debian-amd64.docker | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)