diff mbox series

[3/3] contrib/rdmacm-mux: fix clang compilation

Message ID 20190112150225.20294-4-marcel.apfelbaum@gmail.com (mailing list archive)
State New, archived
Headers show
Series contrib/rdmacm-mux: fix clang compilation | expand

Commit Message

Marcel Apfelbaum Jan. 12, 2019, 3:02 p.m. UTC
Fix Commit a5d2f6f877 (contrib/rdmacm-mux: Add implementation
                       of RDMA User MAD multiplexer).

The above commit introduces a new contrib target, adding a global dependency
to libumad library in case pvrdma configuration option is enabled.
Clang forbids it:
    clang-6.0: error: -libumad: 'linker' input unused
              [-Werror,-Wunused-command-line-argument]

Fix by limiting the scope to the rdmacm-mux target itself.

Reported-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
---
 Makefile                         | 2 ++
 contrib/rdmacm-mux/Makefile.objs | 1 -
 2 files changed, 2 insertions(+), 1 deletion(-)

Comments

Yuval Shaia Jan. 13, 2019, 7:26 p.m. UTC | #1
On Sat, Jan 12, 2019 at 05:02:25PM +0200, Marcel Apfelbaum wrote:
> Fix Commit a5d2f6f877 (contrib/rdmacm-mux: Add implementation
>                        of RDMA User MAD multiplexer).
> 
> The above commit introduces a new contrib target, adding a global dependency
> to libumad library in case pvrdma configuration option is enabled.
> Clang forbids it:
>     clang-6.0: error: -libumad: 'linker' input unused
>               [-Werror,-Wunused-command-line-argument]
> 
> Fix by limiting the scope to the rdmacm-mux target itself.
> 
> Reported-by: Cornelia Huck <cohuck@redhat.com>
> Signed-off-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
> ---
>  Makefile                         | 2 ++
>  contrib/rdmacm-mux/Makefile.objs | 1 -
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index a9ac16d94e..31e87e0c2d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -580,6 +580,8 @@ vhost-user-scsi$(EXESUF): $(vhost-user-scsi-obj-y) libvhost-user.a
>  	$(call LINK, $^)
>  vhost-user-blk$(EXESUF): $(vhost-user-blk-obj-y) libvhost-user.a
>  	$(call LINK, $^)
> +
> +rdmacm-mux$(EXESUF): LIBS += "-libumad"
>  rdmacm-mux$(EXESUF): $(rdmacm-mux-obj-y) $(COMMON_LDADDS)
>  	$(call LINK, $^)
>  
> diff --git a/contrib/rdmacm-mux/Makefile.objs b/contrib/rdmacm-mux/Makefile.objs
> index e1ff4fe569..3df744af89 100644
> --- a/contrib/rdmacm-mux/Makefile.objs
> +++ b/contrib/rdmacm-mux/Makefile.objs
> @@ -1,4 +1,3 @@
>  ifdef CONFIG_PVRDMA
> -CFLAGS += -libumad

My bad, thanks for doing it the right way.

Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>

>  rdmacm-mux-obj-y = main.o
>  endif
> -- 
> 2.17.1
>
diff mbox series

Patch

diff --git a/Makefile b/Makefile
index a9ac16d94e..31e87e0c2d 100644
--- a/Makefile
+++ b/Makefile
@@ -580,6 +580,8 @@  vhost-user-scsi$(EXESUF): $(vhost-user-scsi-obj-y) libvhost-user.a
 	$(call LINK, $^)
 vhost-user-blk$(EXESUF): $(vhost-user-blk-obj-y) libvhost-user.a
 	$(call LINK, $^)
+
+rdmacm-mux$(EXESUF): LIBS += "-libumad"
 rdmacm-mux$(EXESUF): $(rdmacm-mux-obj-y) $(COMMON_LDADDS)
 	$(call LINK, $^)
 
diff --git a/contrib/rdmacm-mux/Makefile.objs b/contrib/rdmacm-mux/Makefile.objs
index e1ff4fe569..3df744af89 100644
--- a/contrib/rdmacm-mux/Makefile.objs
+++ b/contrib/rdmacm-mux/Makefile.objs
@@ -1,4 +1,3 @@ 
 ifdef CONFIG_PVRDMA
-CFLAGS += -libumad
 rdmacm-mux-obj-y = main.o
 endif