From patchwork Sat Jan 12 15:02:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcel Apfelbaum X-Patchwork-Id: 10760991 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3D2636C2 for ; Sat, 12 Jan 2019 15:03:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1E1CF29472 for ; Sat, 12 Jan 2019 15:03:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0EA7129476; Sat, 12 Jan 2019 15:03:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9E3E529472 for ; Sat, 12 Jan 2019 15:03:45 +0000 (UTC) Received: from localhost ([127.0.0.1]:55367 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1giKp6-0004Ql-On for patchwork-qemu-devel@patchwork.kernel.org; Sat, 12 Jan 2019 10:03:44 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54408) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1giKo1-0003n7-UR for qemu-devel@nongnu.org; Sat, 12 Jan 2019 10:02:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1giKo1-0002sV-7b for qemu-devel@nongnu.org; Sat, 12 Jan 2019 10:02:37 -0500 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:39405) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1giKnz-0002qM-9b; Sat, 12 Jan 2019 10:02:37 -0500 Received: by mail-wr1-x444.google.com with SMTP id t27so18222112wra.6; Sat, 12 Jan 2019 07:02:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ESlTEmI6Aw9aJ76EYNe8rR1OwpCmlzJAkPyrd6Y4qMA=; b=USTqb//IUjwVAjywPfT0xXYJEr8g4VWx1/uqBn8GFI0l2E9Q3n4pCqbOSBpzAWZAV/ BlyurYK1XyRowyWCXIPfy8eK+Y6JA6zEEmhPKuh7YeiAWibhlcZRErhYDEdMaHIXxfH4 86S9NSPPkSOlyhAMlrLF1YuSMjrEcZjmdTA4EdMgcOfOxgZOKUZowyQtMgJOIuqJFg3X kB9tBHRMVL1lGzA4j/rpAOAisypAMeUdkdWTNZiKK3kQ9ziZmV9vGuESdjIDdk7Rz10H f3MM0UejHVAtZdIXVEpiGKOCucV97Mk8mp3+pds8PAT+xzK7z11QYm2zV/KACPRgQKec 5HaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ESlTEmI6Aw9aJ76EYNe8rR1OwpCmlzJAkPyrd6Y4qMA=; b=YDkMc4uYsfMv4jWwm7rziePZN5IhXhFYKVGDQaAZBQ9kLSng7h4vYlWh+gNQZ13TFa w04qAwM2+Xu34iwb6krQQQJgKc0nm9m0zyFfYAqAFIqw+AkX0BzYxBONegVbgs3eepG7 CSMharnsKwUzNrlugL1Wq9CaIH4KJhD1OQF3ovnSF1XSXaoqTpf7Ti/3528EgjPRgIST effl30kQYxS3kcKBN7+GgpW3Vlt40kJgxZwlMOrmqcI042Z6k9OmcKp5Noisecyffsot /tuxd3YQxJ3zPTXGdyLTpb1sT7fO2WcJlfsJgBTEVTxi11GGs5iMyqpq7ulMILt/VkFM Z2qQ== X-Gm-Message-State: AJcUukfTi16r7y86lcuSIoMrNsex6V8ieUEfcAVRvNJgNnP82fKEUjHR D5vW8PA1rFFCEXVSacfJxKv5UDyp X-Google-Smtp-Source: ALg8bN6UPGQLZX7/rlpM9C6GAdTfD0hNryWAruM++8Ltq+VY0pRISY/WzayuV4qltfr+XXdDySV/MA== X-Received: by 2002:adf:e9d1:: with SMTP id l17mr16636167wrn.73.1547305352053; Sat, 12 Jan 2019 07:02:32 -0800 (PST) Received: from localhost.localdomain ([176.228.155.165]) by smtp.gmail.com with ESMTPSA id o81sm38222581wmd.10.2019.01.12.07.02.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 12 Jan 2019 07:02:31 -0800 (PST) From: Marcel Apfelbaum To: qemu-devel@nongnu.org Date: Sat, 12 Jan 2019 17:02:25 +0200 Message-Id: <20190112150225.20294-4-marcel.apfelbaum@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190112150225.20294-1-marcel.apfelbaum@gmail.com> References: <20190112150225.20294-1-marcel.apfelbaum@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 Subject: [Qemu-devel] [PATCH 3/3] contrib/rdmacm-mux: fix clang compilation X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cohuck@redhat.com, qemu-stable@nongnu.org, yuval.shaia@oracle.com Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Fix Commit a5d2f6f877 (contrib/rdmacm-mux: Add implementation of RDMA User MAD multiplexer). The above commit introduces a new contrib target, adding a global dependency to libumad library in case pvrdma configuration option is enabled. Clang forbids it: clang-6.0: error: -libumad: 'linker' input unused [-Werror,-Wunused-command-line-argument] Fix by limiting the scope to the rdmacm-mux target itself. Reported-by: Cornelia Huck Signed-off-by: Marcel Apfelbaum Reviewed-by: Yuval Shaia --- Makefile | 2 ++ contrib/rdmacm-mux/Makefile.objs | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index a9ac16d94e..31e87e0c2d 100644 --- a/Makefile +++ b/Makefile @@ -580,6 +580,8 @@ vhost-user-scsi$(EXESUF): $(vhost-user-scsi-obj-y) libvhost-user.a $(call LINK, $^) vhost-user-blk$(EXESUF): $(vhost-user-blk-obj-y) libvhost-user.a $(call LINK, $^) + +rdmacm-mux$(EXESUF): LIBS += "-libumad" rdmacm-mux$(EXESUF): $(rdmacm-mux-obj-y) $(COMMON_LDADDS) $(call LINK, $^) diff --git a/contrib/rdmacm-mux/Makefile.objs b/contrib/rdmacm-mux/Makefile.objs index e1ff4fe569..3df744af89 100644 --- a/contrib/rdmacm-mux/Makefile.objs +++ b/contrib/rdmacm-mux/Makefile.objs @@ -1,4 +1,3 @@ ifdef CONFIG_PVRDMA -CFLAGS += -libumad rdmacm-mux-obj-y = main.o endif