From patchwork Fri Jan 18 12:46:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcel Apfelbaum X-Patchwork-Id: 10770031 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 19F736C2 for ; Fri, 18 Jan 2019 12:57:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 05E3D2918A for ; Fri, 18 Jan 2019 12:57:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EE5AD2926E; Fri, 18 Jan 2019 12:57:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9B36D2918A for ; Fri, 18 Jan 2019 12:57:29 +0000 (UTC) Received: from localhost ([127.0.0.1]:38437 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkTiD-0003YC-2L for patchwork-qemu-devel@patchwork.kernel.org; Fri, 18 Jan 2019 07:57:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33985) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkTXm-0003W5-Ba for qemu-devel@nongnu.org; Fri, 18 Jan 2019 07:46:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gkTXj-0008DH-V4 for qemu-devel@nongnu.org; Fri, 18 Jan 2019 07:46:42 -0500 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:41964) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gkTXh-00082S-HC; Fri, 18 Jan 2019 07:46:39 -0500 Received: by mail-wr1-x443.google.com with SMTP id x10so14868200wrs.8; Fri, 18 Jan 2019 04:46:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=9zGtyxheSJbBEb3liniqHLckKnDLz5V3hbTZEj54pc0=; b=ndHW/vSmAXCIEiKqZ2lhZvAt3sPyYk+x7EOxtWF17A2hXcnCJLomYNOIDu40iIYPLn ajRMnC4I4w8FFa6zk6GiwsZo7nVYRiHqz5sTKrEQ/+1N41kM6xN+p3LUnfxFTpf7nDZO 6M4Z8Eo/CG+rPtjcrvsZVS4m/cpx/HC5SI/CWfP7YypC4QkJd3sGb7N/mIjKW+TyCMU+ xiiLT0RFbYQDNaslBuvnq6ZL//O45LR0T8/1VCMz4yjhi8hOWm+0aqe58WVCriK2rtYM /23V+NojI3wZ3UWrozlgF9iCD4H6CD2g2zrJo1kDV49SqGKOQaO8QUi+eJP7l2nNp2y1 A3Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=9zGtyxheSJbBEb3liniqHLckKnDLz5V3hbTZEj54pc0=; b=OK6hlmMKwPJhCHD3yewGolEORMvbQb3GZCI4kP3/OLhpjqKKZYqGnktyJoBKzuIvxO R/YG6OGJcEX1zYz+O2K2aBsl6DOZ/OBwcJ5mqGy+rmFOcD4B7/8s45xMB7cm+Q7L6ZJA BIIV67FTZVlcrDqf0+AZ4BMyyrOufYnlPOpqI0vZtl6NQ8AXNyK2/Pv150OCRm4APvdk Hv9CmRvjcR9UvRR3IpBwLLyE1NwSHR2hSuMCaUTZ+CIK/ULeUWTketoS6kUOXJbTJYw+ ZAMwgs3SbWFGor5S4PYFN1kHmjq3UCD+qWhfvadxF5wsrL8z5G9EyeOp4uK1epvjusBS 9gjg== X-Gm-Message-State: AJcUukcm/jIZMbOuAskicmRT9F5vKxzwszsTMDRcuQmQOCHyVxRxVmIG ED4dZ52iestVCjJRXZM1GxKNC7sa X-Google-Smtp-Source: ALg8bN4Z5FjztBK8OE2fE5Fq5iNX26G1FdlGuxR2RZTKa1FUMxoC4354TqMm46BTeq7edGewZW9/FA== X-Received: by 2002:adf:e6ce:: with SMTP id y14mr17063501wrm.239.1547815581981; Fri, 18 Jan 2019 04:46:21 -0800 (PST) Received: from localhost.localdomain ([176.228.155.165]) by smtp.gmail.com with ESMTPSA id n15sm69542124wrt.21.2019.01.18.04.46.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 18 Jan 2019 04:46:21 -0800 (PST) From: Marcel Apfelbaum To: qemu-devel@nongnu.org Date: Fri, 18 Jan 2019 14:46:14 +0200 Message-Id: <20190118124614.24548-4-marcel.apfelbaum@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190118124614.24548-1-marcel.apfelbaum@gmail.com> References: <20190118124614.24548-1-marcel.apfelbaum@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::443 Subject: [Qemu-devel] [PATCH v2 3/3] contrib/rdmacm-mux: fix clang compilation X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cohuck@redhat.com, qemu-stable@nongnu.org, yuval.shaia@oracle.com Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Fix Commit a5d2f6f877 (contrib/rdmacm-mux: Add implementation of RDMA User MAD multiplexer). The above commit introduces a new contrib target, adding a global dependency to libumad library in case pvrdma configuration option is enabled. Clang forbids it: clang-6.0: error: -libumad: 'linker' input unused [-Werror,-Wunused-command-line-argument] Fix by limiting the scope to the rdmacm-mux target itself. Reported-by: Cornelia Huck Reviewed-by: Yuval Shaia Tested-by: Cornelia Huck Signed-off-by: Marcel Apfelbaum --- Makefile | 2 ++ contrib/rdmacm-mux/Makefile.objs | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index dccba1dca2..c9bdb67274 100644 --- a/Makefile +++ b/Makefile @@ -581,6 +581,8 @@ vhost-user-scsi$(EXESUF): $(vhost-user-scsi-obj-y) libvhost-user.a $(call LINK, $^) vhost-user-blk$(EXESUF): $(vhost-user-blk-obj-y) libvhost-user.a $(call LINK, $^) + +rdmacm-mux$(EXESUF): LIBS += "-libumad" rdmacm-mux$(EXESUF): $(rdmacm-mux-obj-y) $(COMMON_LDADDS) $(call LINK, $^) diff --git a/contrib/rdmacm-mux/Makefile.objs b/contrib/rdmacm-mux/Makefile.objs index e1ff4fe569..3df744af89 100644 --- a/contrib/rdmacm-mux/Makefile.objs +++ b/contrib/rdmacm-mux/Makefile.objs @@ -1,4 +1,3 @@ ifdef CONFIG_PVRDMA -CFLAGS += -libumad rdmacm-mux-obj-y = main.o endif