mbox

[PULL,00/10] RDMA queue

Message ID 20190119100315.23985-1-marcel.apfelbaum@gmail.com (mailing list archive)
State New, archived
Headers show

Pull-request

https://github.com/marcel-apf/qemu tags/rdma-pull-request

Message

Marcel Apfelbaum Jan. 19, 2019, 10:03 a.m. UTC
The following changes since commit a8d2b0685681e2f291faaa501efbbd76875f8ec8:

  Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190118' into staging (2019-01-18 16:56:15 +0000)

are available in the Git repository at:

  https://github.com/marcel-apf/qemu tags/rdma-pull-request

for you to fetch changes up to 0f645ba16c6b76ccf2076d38460aa998198893bc:

  contrib/rdmacm-mux: fix clang compilation (2019-01-19 11:01:57 +0200)

----------------------------------------------------------------
RDMA queue
 * Clang compilation fix
 * Coverity fix
 * Various fixes for the pvrdma device

----------------------------------------------------------------
Kamal Heib (1):
      docs/pvrdma: Update rdmacm-mux documentation

Li Qiang (1):
      hw: rdma: fix an off-by-one issue

Marcel Apfelbaum (3):
      contrib/rdmacm-mux: remove Wno-format-truncation flag
      hw/rdma: modify struct initialization
      contrib/rdmacm-mux: fix clang compilation

Yuval Shaia (5):
      hw/pvrdma: Remove max-sge command-line param
      hw/rdma: Delete unused struct member
      hw/pvrdma: Post CQE when receive invalid gid index
      hw/pvrdma: Make function pvrdma_qp_send/recv return void.
      hw/rdma: Verify that ptr is not NULL before freeing

 Makefile                         |  2 ++
 contrib/rdmacm-mux/Makefile.objs |  1 -
 contrib/rdmacm-mux/main.c        | 12 ++++----
 docs/pvrdma.txt                  |  4 ++-
 hw/rdma/rdma_backend.c           | 63 +++++++++++++++-------------------------
 hw/rdma/rdma_backend.h           | 12 ++++++++
 hw/rdma/rdma_backend_defs.h      |  1 -
 hw/rdma/rdma_rm.c                |  9 ++++--
 hw/rdma/vmw/pvrdma_main.c        | 10 +++----
 hw/rdma/vmw/pvrdma_qp_ops.c      | 44 +++++++++++++++++++++-------
 hw/rdma/vmw/pvrdma_qp_ops.h      |  4 +--
 11 files changed, 96 insertions(+), 66 deletions(-)

Comments

Li Qiang Jan. 20, 2019, 6:04 a.m. UTC | #1
Hi Marcel,
Seems you lost another:


hw: pvrdma: fix memory leak in error path
-->http://lists.gnu.org/archive/html/qemu-devel/2019-01/msg01217.html



At 2019-01-19 18:03:05, "Marcel Apfelbaum" <marcel.apfelbaum@gmail.com> wrote:
>The following changes since commit a8d2b0685681e2f291faaa501efbbd76875f8ec8:
>
>  Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190118' into staging (2019-01-18 16:56:15 +0000)
>
>are available in the Git repository at:
>
>  https://github.com/marcel-apf/qemu tags/rdma-pull-request
>
>for you to fetch changes up to 0f645ba16c6b76ccf2076d38460aa998198893bc:
>
>  contrib/rdmacm-mux: fix clang compilation (2019-01-19 11:01:57 +0200)
>
>----------------------------------------------------------------
>RDMA queue
> * Clang compilation fix
> * Coverity fix
> * Various fixes for the pvrdma device
>
>----------------------------------------------------------------
>Kamal Heib (1):
>      docs/pvrdma: Update rdmacm-mux documentation
>
>Li Qiang (1):
>      hw: rdma: fix an off-by-one issue
>
>Marcel Apfelbaum (3):
>      contrib/rdmacm-mux: remove Wno-format-truncation flag
>      hw/rdma: modify struct initialization
>      contrib/rdmacm-mux: fix clang compilation
>
>Yuval Shaia (5):
>      hw/pvrdma: Remove max-sge command-line param
>      hw/rdma: Delete unused struct member
>      hw/pvrdma: Post CQE when receive invalid gid index
>      hw/pvrdma: Make function pvrdma_qp_send/recv return void.
>      hw/rdma: Verify that ptr is not NULL before freeing
>
> Makefile                         |  2 ++
> contrib/rdmacm-mux/Makefile.objs |  1 -
> contrib/rdmacm-mux/main.c        | 12 ++++----
> docs/pvrdma.txt                  |  4 ++-
> hw/rdma/rdma_backend.c           | 63 +++++++++++++++-------------------------
> hw/rdma/rdma_backend.h           | 12 ++++++++
> hw/rdma/rdma_backend_defs.h      |  1 -
> hw/rdma/rdma_rm.c                |  9 ++++--
> hw/rdma/vmw/pvrdma_main.c        | 10 +++----
> hw/rdma/vmw/pvrdma_qp_ops.c      | 44 +++++++++++++++++++++-------
> hw/rdma/vmw/pvrdma_qp_ops.h      |  4 +--
> 11 files changed, 96 insertions(+), 66 deletions(-)
>-- 
>2.17.1
Marcel Apfelbaum Jan. 20, 2019, 6:08 a.m. UTC | #2
Hi,

On 1/20/19 8:04 AM, 李强 wrote:
>
> Hi Marcel,
> Seems you lost another:
>

No,  I did not, please see below.

> hw: pvrdma: fix memory leak in error path
> -->http://lists.gnu.org/archive/html/qemu-devel/2019-01/msg01217.html
>

Please see this mail thread, you were cc--ed:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg588766.html

Basically the following patch makes the the mentioned one obsolete.
https://patchew.org/QEMU/20190109201559.3906-1-yuval.shaia@oracle.com/

Thanks,
Marcel

> At 2019-01-19 18:03:05, "Marcel Apfelbaum" <marcel.apfelbaum@gmail.com> wrote:
> >The following changes since commit a8d2b0685681e2f291faaa501efbbd76875f8ec8:
> >
> >  Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190118' into staging (2019-01-18 16:56:15 +0000)
> >
> >are available in the Git repository at:
> >
> >  https://github.com/marcel-apf/qemu tags/rdma-pull-request
> >
> >for you to fetch changes up to 0f645ba16c6b76ccf2076d38460aa998198893bc:
> >
> >  contrib/rdmacm-mux: fix clang compilation (2019-01-19 11:01:57 +0200)
> >
> >----------------------------------------------------------------
> >RDMA queue
> > * Clang compilation fix
> > * Coverity fix
> > * Various fixes for the pvrdma device
> >
> >----------------------------------------------------------------
> >Kamal Heib (1):
> >      docs/pvrdma: Update rdmacm-mux documentation
> >
> >Li Qiang (1):
> >      hw: rdma: fix an off-by-one issue
> >
> >Marcel Apfelbaum (3):
> >      contrib/rdmacm-mux: remove Wno-format-truncation flag
> >      hw/rdma: modify struct initialization
> >      contrib/rdmacm-mux: fix clang compilation
> >
> >Yuval Shaia (5):
> >      hw/pvrdma: Remove max-sge command-line param
> >      hw/rdma: Delete unused struct member
> >      hw/pvrdma: Post CQE when receive invalid gid index
> >      hw/pvrdma: Make function pvrdma_qp_send/recv return void.
> >      hw/rdma: Verify that ptr is not NULL before freeing
> >
> > Makefile                         |  2 ++
> > contrib/rdmacm-mux/Makefile.objs |  1 -
> > contrib/rdmacm-mux/main.c        | 12 ++++----
> > docs/pvrdma.txt                  |  4 ++-
> > hw/rdma/rdma_backend.c           | 63 +++++++++++++++-------------------------
> > hw/rdma/rdma_backend.h           | 12 ++++++++
> > hw/rdma/rdma_backend_defs.h      |  1 -
> > hw/rdma/rdma_rm.c                |  9 ++++--
> > hw/rdma/vmw/pvrdma_main.c        | 10 +++----
> > hw/rdma/vmw/pvrdma_qp_ops.c      | 44 +++++++++++++++++++++-------
> > hw/rdma/vmw/pvrdma_qp_ops.h      |  4 +--
> > 11 files changed, 96 insertions(+), 66 deletions(-)
> >-- 
> >2.17.1
>
>
Marcel Apfelbaum Jan. 20, 2019, 6:18 a.m. UTC | #3
On 1/20/19 8:16 AM, 李强 wrote:
> At 2019-01-20 14:08:57, "Marcel Apfelbaum" <marcel.apfelbaum@gmail.com> wrote:
> >Hi,
> >
> >On 1/20/19 8:04 AM, 李强 wrote:
> >>
> >> Hi Marcel,
> >> Seems you lost another:
> >>
> >
> >No,  I did not, please see below.
> Yes, I just read the patch.
> >> hw: pvrdma: fix memory leak in error path
> >> -->http://lists.gnu.org/archive/html/qemu-devel/2019-01/msg01217.html
> >>
> >
> >Please see this mail thread, you were cc--ed:
> >https://www.mail-archive.com/qemu-devel@nongnu.org/msg588766.html   <https://www.mail-archive.com/qemu-devel@nongnu.org/msg588766.html
> >>
> > <https://www.mail-archive.com/qemu-devel@nongnu.org/msg588766.html >>
> I think you're right my patch "hw: pvrdma: fix memory leak in error path"
> is redundant.
> Sorry for the late reply.

No problem, thanks for the contribution!
Marcel

> Thanks,
> Li Qiang
> >Basically the following patch makes the the mentioned one obsolete.
> >https://patchew.org/QEMU/20190109201559.3906-1-yuval.shaia@oracle.com/
> >
> >Thanks,
> >Marcel
> >
> >> At 2019-01-19 18:03:05, "Marcel Apfelbaum" <marcel.apfelbaum@gmail.com> wrote:
> >> >The following changes since commit a8d2b0685681e2f291faaa501efbbd76875f8ec8:
> >> >
> >> >  Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190118' into staging (2019-01-18 16:56:15 +0000)
> >> >
> >> >are available in the Git repository at:
> >> >
> >> >  https://github.com/marcel-apf/qemu tags/rdma-pull-request
> >> >
> >> >for you to fetch changes up to 0f645ba16c6b76ccf2076d38460aa998198893bc:
> >> >
> >> >  contrib/rdmacm-mux: fix clang compilation (2019-01-19 11:01:57 +0200)
> >> >
> >> >----------------------------------------------------------------
> >> >RDMA queue
> >> > * Clang compilation fix
> >> > * Coverity fix
> >> > * Various fixes for the pvrdma device
> >> >
> >> >----------------------------------------------------------------
> >> >Kamal Heib (1):
> >> >      docs/pvrdma: Update rdmacm-mux documentation
> >> >
> >> >Li Qiang (1):
> >> >      hw: rdma: fix an off-by-one issue
> >> >
> >> >Marcel Apfelbaum (3):
> >> >      contrib/rdmacm-mux: remove Wno-format-truncation flag
> >> >      hw/rdma: modify struct initialization
> >> >      contrib/rdmacm-mux: fix clang compilation
> >> >
> >> >Yuval Shaia (5):
> >> >      hw/pvrdma: Remove max-sge command-line param
> >> >      hw/rdma: Delete unused struct member
> >> >      hw/pvrdma: Post CQE when receive invalid gid index
> >> >      hw/pvrdma: Make function pvrdma_qp_send/recv return void.
> >> >      hw/rdma: Verify that ptr is not NULL before freeing
> >> >
> >> > Makefile                         |  2 ++
> >> > contrib/rdmacm-mux/Makefile.objs |  1 -
> >> > contrib/rdmacm-mux/main.c        | 12 ++++----
> >> > docs/pvrdma.txt                  |  4 ++-
> >> > hw/rdma/rdma_backend.c           | 63 +++++++++++++++-------------------------
> >> > hw/rdma/rdma_backend.h           | 12 ++++++++
> >> > hw/rdma/rdma_backend_defs.h      |  1 -
> >> > hw/rdma/rdma_rm.c                |  9 ++++--
> >> > hw/rdma/vmw/pvrdma_main.c        | 10 +++----
> >> > hw/rdma/vmw/pvrdma_qp_ops.c      | 44 +++++++++++++++++++++-------
> >> > hw/rdma/vmw/pvrdma_qp_ops.h      |  4 +--
> >> > 11 files changed, 96 insertions(+), 66 deletions(-)
> >> >-- 
> >> >2.17.1
> >>
> >>
>
>
Peter Maydell Jan. 22, 2019, 9:48 a.m. UTC | #4
On Sat, 19 Jan 2019 at 10:03, Marcel Apfelbaum
<marcel.apfelbaum@gmail.com> wrote:
>
> The following changes since commit a8d2b0685681e2f291faaa501efbbd76875f8ec8:
>
>   Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190118' into staging (2019-01-18 16:56:15 +0000)
>
> are available in the Git repository at:
>
>   https://github.com/marcel-apf/qemu tags/rdma-pull-request
>
> for you to fetch changes up to 0f645ba16c6b76ccf2076d38460aa998198893bc:
>
>   contrib/rdmacm-mux: fix clang compilation (2019-01-19 11:01:57 +0200)
>
> ----------------------------------------------------------------
> RDMA queue
>  * Clang compilation fix
>  * Coverity fix
>  * Various fixes for the pvrdma device
>
> ----------------------------------------------------------------

Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/4.0
for any user-visible changes.

-- PMM