From patchwork Sat Jan 19 10:03:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcel Apfelbaum X-Patchwork-Id: 10771979 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B0A896C2 for ; Sat, 19 Jan 2019 10:10:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 96B2C2E32A for ; Sat, 19 Jan 2019 10:10:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8B3102E40C; Sat, 19 Jan 2019 10:10:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3113A2E32A for ; Sat, 19 Jan 2019 10:10:49 +0000 (UTC) Received: from localhost ([127.0.0.1]:53831 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gknaS-0007Sw-5R for patchwork-qemu-devel@patchwork.kernel.org; Sat, 19 Jan 2019 05:10:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55303) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gknTa-0001Mg-Pt for qemu-devel@nongnu.org; Sat, 19 Jan 2019 05:03:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gknTZ-00083Q-Nt for qemu-devel@nongnu.org; Sat, 19 Jan 2019 05:03:42 -0500 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:33739) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gknTZ-0007tZ-Ge for qemu-devel@nongnu.org; Sat, 19 Jan 2019 05:03:41 -0500 Received: by mail-wr1-x444.google.com with SMTP id c14so17960877wrr.0 for ; Sat, 19 Jan 2019 02:03:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=LCVOGzUYrR6148m8WdfYBWlea+KS1E6E2RI4GN4WWkk=; b=S9XmUjCvlj6Vu0gLRwNH8HpDDKcOOUwy2GuXGzfiG0GxCQbkiDDgEEVnTzFZXw5Wlw rosT4jxqxZEATE5gMAXWgbsx87Bqd5as4jL4wErItytlQrOq+/vxK6h/adosuKiNCC9i fAorDMgeZv/pLa2Ho+uG1WOe1qFeDx7OVLBh92B03k0Yv2I2oCyBSxhAi93+0SG7VF6T X8dn6LncAFjU5tIp/N9m8Zd5g++PtpZ53GsUsttyZVLhPcZWnxdHg15PpNkbWqgJfy33 gAqD7y/j4whjkJjVk0KErOqkJSBXn84otlLD2/1ba+0wr+mXUxbpSRB6KUmZJhHC93kL Yq1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=LCVOGzUYrR6148m8WdfYBWlea+KS1E6E2RI4GN4WWkk=; b=NjU3L+yQsC/fBU4w8sLE5cmVU8L2RNYh/9Tajm/GDAbYIDjqLksvFrHdaF1dF6jF5l ty1UBlMz1Ik7vNoPuP3O4joaIKRkMSJnL7H8LFmf7Ks3A31TRdF4RnjeVkEEwPpZDYlR KoGSY2J8Zh9tods08txgi3WrlvwJI6F96hGDNKeO4AkkMDzQJ8EK/a3vGWLtNKNCxbEa IyUM6JpTiQrhNiUdr5r62URdqLlGwcwqFN+0SnEXaRp2eHL3OlY3Ag+Bf9tQfdJ6zF/Q IJxf+3JgEsyNy3neYj/sWvPxQNyTrUOmC2OpPz/PDdyKct2OgCeL572kUmtr8huEQL8E 3sUw== X-Gm-Message-State: AJcUukdDpf0hotkATDLByqPa2S0KVGlKey5NNFaRBF12WP0W7ZPIE25A SnbUbyN1uqu4LudEXTR4JP8WNuU5 X-Google-Smtp-Source: ALg8bN4aO+xEIfuiOISbiD6UYYbnNDXApWLoYiIyT0A34lhUG3ZHBtIytGLSLQs2623VGo3WVdM5jw== X-Received: by 2002:adf:dd06:: with SMTP id a6mr20899551wrm.2.1547892205399; Sat, 19 Jan 2019 02:03:25 -0800 (PST) Received: from localhost.localdomain ([176.228.155.165]) by smtp.gmail.com with ESMTPSA id j8sm113868847wmd.0.2019.01.19.02.03.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 19 Jan 2019 02:03:24 -0800 (PST) From: Marcel Apfelbaum To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Sat, 19 Jan 2019 12:03:09 +0200 Message-Id: <20190119100315.23985-5-marcel.apfelbaum@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190119100315.23985-1-marcel.apfelbaum@gmail.com> References: <20190119100315.23985-1-marcel.apfelbaum@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 Subject: [Qemu-devel] [PATCH PULL 04/10] hw/pvrdma: Post CQE when receive invalid gid index X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cohuck@redhat.com, liq3ea@163.com, yuval.shaia@oracle.com, kamalheib1@gmail.com, philmd@redhat.com Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Yuval Shaia This error should propagate back to guest. Spotted by Coverity: CID 1398595 Fixes: 2b05705dc8 Reported-by: Li Qiang Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum Signed-off-by: Marcel Apfelbaum --- hw/rdma/rdma_backend.h | 1 + hw/rdma/vmw/pvrdma_qp_ops.c | 6 ++++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/rdma/rdma_backend.h b/hw/rdma/rdma_backend.h index a9ba40ae48..5114c90e67 100644 --- a/hw/rdma/rdma_backend.h +++ b/hw/rdma/rdma_backend.h @@ -32,6 +32,7 @@ #define VENDOR_ERR_INVLKEY 0x207 #define VENDOR_ERR_MR_SMALL 0x208 #define VENDOR_ERR_INV_MAD_BUFF 0x209 +#define VENDOR_ERR_INV_GID_IDX 0x210 /* Add definition for QP0 and QP1 as there is no userspace enums for them */ enum ibv_special_qp_type { diff --git a/hw/rdma/vmw/pvrdma_qp_ops.c b/hw/rdma/vmw/pvrdma_qp_ops.c index 465bee8641..0565eba981 100644 --- a/hw/rdma/vmw/pvrdma_qp_ops.c +++ b/hw/rdma/vmw/pvrdma_qp_ops.c @@ -178,7 +178,8 @@ int pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle) sgid = rdma_rm_get_gid(&dev->rdma_dev_res, wqe->hdr.wr.ud.av.gid_index); if (!sgid) { pr_dbg("Fail to get gid for idx %d\n", wqe->hdr.wr.ud.av.gid_index); - return -EIO; + complete_with_error(VENDOR_ERR_INV_GID_IDX, comp_ctx); + continue; } pr_dbg("sgid_id=%d, sgid=0x%llx\n", wqe->hdr.wr.ud.av.gid_index, sgid->global.interface_id); @@ -189,7 +190,8 @@ int pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle) if (sgid_idx <= 0) { pr_dbg("Fail to get bk sgid_idx for sgid_idx %d\n", wqe->hdr.wr.ud.av.gid_index); - return -EIO; + complete_with_error(VENDOR_ERR_INV_GID_IDX, comp_ctx); + continue; } if (wqe->hdr.num_sge > dev->dev_attr.max_sge) {