Message ID | 20190125192719.15339-4-philmd@redhat.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | OpenBSD fixes | expand |
On 2019-01-25 20:27, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > tests/vm/openbsd | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/tests/vm/openbsd b/tests/vm/openbsd > index cfe0572c59..de907dd21c 100755 > --- a/tests/vm/openbsd > +++ b/tests/vm/openbsd > @@ -25,9 +25,7 @@ class OpenBSDVM(basevm.BaseVM): > cd $(mktemp -d /var/tmp/qemu-test.XXXXXX); > tar -xf /dev/rsd1c; > ./configure --cc=x86_64-unknown-openbsd6.1-gcc-4.9.4 --python=python2.7 {configure_opts}; > - gmake --output-sync -j{jobs} {verbose}; > - # XXX: "gmake check" seems to always hang or fail > - #gmake --output-sync -j{jobs} check {verbose}; > + gmake --output-sync -j{jobs} check {verbose}; > """ > > def build_image(self, img): > Please add a proper patch description and remove the WIP from the subject. Thanks, Thomas
On 1/28/19 9:44 AM, Thomas Huth wrote: > On 2019-01-25 20:27, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> >> --- >> tests/vm/openbsd | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/tests/vm/openbsd b/tests/vm/openbsd >> index cfe0572c59..de907dd21c 100755 >> --- a/tests/vm/openbsd >> +++ b/tests/vm/openbsd >> @@ -25,9 +25,7 @@ class OpenBSDVM(basevm.BaseVM): >> cd $(mktemp -d /var/tmp/qemu-test.XXXXXX); >> tar -xf /dev/rsd1c; >> ./configure --cc=x86_64-unknown-openbsd6.1-gcc-4.9.4 --python=python2.7 {configure_opts}; >> - gmake --output-sync -j{jobs} {verbose}; >> - # XXX: "gmake check" seems to always hang or fail >> - #gmake --output-sync -j{jobs} check {verbose}; >> + gmake --output-sync -j{jobs} check {verbose}; >> """ >> >> def build_image(self, img): >> > > Please add a proper patch description and remove the WIP from the subject. Oops :/ I thought about renaming this also NOTFORMERGE. The description could be: OpenBSD tests are still failing, but this patch help to test the improvement of the previous 2 patches (disable W^X, disable assert(fcntl)).
diff --git a/tests/vm/openbsd b/tests/vm/openbsd index cfe0572c59..de907dd21c 100755 --- a/tests/vm/openbsd +++ b/tests/vm/openbsd @@ -25,9 +25,7 @@ class OpenBSDVM(basevm.BaseVM): cd $(mktemp -d /var/tmp/qemu-test.XXXXXX); tar -xf /dev/rsd1c; ./configure --cc=x86_64-unknown-openbsd6.1-gcc-4.9.4 --python=python2.7 {configure_opts}; - gmake --output-sync -j{jobs} {verbose}; - # XXX: "gmake check" seems to always hang or fail - #gmake --output-sync -j{jobs} check {verbose}; + gmake --output-sync -j{jobs} check {verbose}; """ def build_image(self, img):
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- tests/vm/openbsd | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)