diff mbox series

[v2,3/6] mips: Express dependencies of the r4k platform with kconfig

Message ID 20190204202609.26956-4-philmd@redhat.com (mailing list archive)
State New, archived
Headers show
Series Kconfig dependencies for MIPS machines (but Malta) | expand

Commit Message

Philippe Mathieu-Daudé Feb. 4, 2019, 8:26 p.m. UTC
This platform use standard PC devices connected to an ISA bus.
Networking is provided by a ne2000 chipset.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/mips/Kconfig | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Thomas Huth Feb. 5, 2019, 4:11 a.m. UTC | #1
On 2019-02-04 21:26, Philippe Mathieu-Daudé wrote:
> This platform use standard PC devices connected to an ISA bus.
> Networking is provided by a ne2000 chipset.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  hw/mips/Kconfig | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/hw/mips/Kconfig b/hw/mips/Kconfig
> index ab006477c7..ee6290d497 100644
> --- a/hw/mips/Kconfig
> +++ b/hw/mips/Kconfig
> @@ -1,5 +1,15 @@
>  config R4K
>      bool
> +    select ISA_BUS
> +    select SERIAL_ISA
> +    select I8259
> +    select I8254
> +    select MC146818RTC
> +    select VGA_ISA
> +    select NE2000_ISA
> +    select IDE_ISA
> +    # I8042
> +    select PCKBD

I think you can now also remove "CONFIG_NE2000_ISA=y" from
default-configs/mips-softmmu-common.mak.

 Thomas
Philippe Mathieu-Daudé Feb. 5, 2019, 11:58 a.m. UTC | #2
On 2/5/19 5:11 AM, Thomas Huth wrote:
> On 2019-02-04 21:26, Philippe Mathieu-Daudé wrote:
>> This platform use standard PC devices connected to an ISA bus.
>> Networking is provided by a ne2000 chipset.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>>  hw/mips/Kconfig | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/hw/mips/Kconfig b/hw/mips/Kconfig
>> index ab006477c7..ee6290d497 100644
>> --- a/hw/mips/Kconfig
>> +++ b/hw/mips/Kconfig
>> @@ -1,5 +1,15 @@
>>  config R4K
>>      bool
>> +    select ISA_BUS
>> +    select SERIAL_ISA
>> +    select I8259
>> +    select I8254
>> +    select MC146818RTC
>> +    select VGA_ISA
>> +    select NE2000_ISA
>> +    select IDE_ISA
>> +    # I8042
>> +    select PCKBD
> 
> I think you can now also remove "CONFIG_NE2000_ISA=y" from
> default-configs/mips-softmmu-common.mak.

Correct!

Thanks,

Phil.
diff mbox series

Patch

diff --git a/hw/mips/Kconfig b/hw/mips/Kconfig
index ab006477c7..ee6290d497 100644
--- a/hw/mips/Kconfig
+++ b/hw/mips/Kconfig
@@ -1,5 +1,15 @@ 
 config R4K
     bool
+    select ISA_BUS
+    select SERIAL_ISA
+    select I8259
+    select I8254
+    select MC146818RTC
+    select VGA_ISA
+    select NE2000_ISA
+    select IDE_ISA
+    # I8042
+    select PCKBD
 
 config MALTA
     bool