diff mbox series

[02/12] virtio-blk: Increase in_flight for request restart BH

Message ID 20190218161822.3573-3-kwolf@redhat.com
State New
Headers show
Series block: bdrv_set_aio_context() related fixes | expand

Commit Message

Kevin Wolf Feb. 18, 2019, 4:18 p.m. UTC
virtio_blk_dma_restart_bh() submits new requests, so in order to make
sure that these requests are not started inside a drained section of the
attached BlockBackend, we need to make sure that draining the
BlockBackend waits for the BH to be executed.

This BH is still questionable because its scheduled in the main thread
instead of the configured iothread. Leave a FIXME comment for this.

But with this fix, enabling the data plane at least waits for these
requests (in bdrv_set_aio_context()) instead of changing the AioContext
under their feet and making them run in the wrong thread, causing
crashes and failures (e.g. due to missing locking).

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
 hw/block/virtio-blk.c | 4 ++++
 1 file changed, 4 insertions(+)
diff mbox series


diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index cf7f47eaba..e11e6e45d0 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -675,6 +675,7 @@  static void virtio_blk_dma_restart_bh(void *opaque)
     if (mrb.num_reqs) {
         virtio_blk_submit_multireq(s->blk, &mrb);
+    blk_dec_in_flight(s->conf.conf.blk);
@@ -688,8 +689,11 @@  static void virtio_blk_dma_restart_cb(void *opaque, int running,
     if (!s->bh) {
+        /* FIXME The data plane is not started yet, so these requests are
+         * processed in the main thread. */
         s->bh = aio_bh_new(blk_get_aio_context(s->conf.conf.blk),
                            virtio_blk_dma_restart_bh, s);
+        blk_inc_in_flight(s->conf.conf.blk);