diff mbox series

[v3,17/25] net/filter-mirror: Use size_t

Message ID 20190220010232.18731-18-philmd@redhat.com (mailing list archive)
State New, archived
Headers show
Series chardev: Convert qemu_chr_write() to take a size_t argument | expand

Commit Message

Philippe Mathieu-Daudé Feb. 20, 2019, 1:02 a.m. UTC
Since iov_size() returns a size_t, no need to use a signed type.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 net/filter-mirror.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Marc-André Lureau Feb. 20, 2019, 11:23 a.m. UTC | #1
Hi

On Wed, Feb 20, 2019 at 2:07 AM Philippe Mathieu-Daudé
<philmd@redhat.com> wrote:
>
> Since iov_size() returns a size_t, no need to use a signed type.

And it is the variable only purpose.

>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>


Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>


> ---
>  net/filter-mirror.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/filter-mirror.c b/net/filter-mirror.c
> index 3a61cf21e8..97b52d0544 100644
> --- a/net/filter-mirror.c
> +++ b/net/filter-mirror.c
> @@ -48,7 +48,7 @@ static int filter_send(MirrorState *s,
>  {
>      NetFilterState *nf = NETFILTER(s);
>      int ret = 0;
> -    ssize_t size = 0;
> +    size_t size = 0;
>      uint32_t len = 0;
>      char *buf;
>
> --
> 2.20.1
>
diff mbox series

Patch

diff --git a/net/filter-mirror.c b/net/filter-mirror.c
index 3a61cf21e8..97b52d0544 100644
--- a/net/filter-mirror.c
+++ b/net/filter-mirror.c
@@ -48,7 +48,7 @@  static int filter_send(MirrorState *s,
 {
     NetFilterState *nf = NETFILTER(s);
     int ret = 0;
-    ssize_t size = 0;
+    size_t size = 0;
     uint32_t len = 0;
     char *buf;