diff mbox series

[1/1] hw/i386: update copyright notice

Message ID 20190223105421.1290-2-davidkiarie4@gmail.com (mailing list archive)
State New, archived
Headers show
Series update copyright notice | expand

Commit Message

David Kiarie Feb. 23, 2019, 10:54 a.m. UTC
Signed-off-by: David Kiarie <davidkiarie4@gmail.com>
---
 hw/i386/amd_iommu.c | 2 +-
 hw/i386/amd_iommu.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Daniel P. Berrangé Feb. 25, 2019, 10:38 a.m. UTC | #1
On Sat, Feb 23, 2019 at 01:54:21PM +0300, David Kiarie wrote:
> Signed-off-by: David Kiarie <davidkiarie4@gmail.com>
> ---
>  hw/i386/amd_iommu.c | 2 +-
>  hw/i386/amd_iommu.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
David Kiarie March 4, 2019, 11:22 a.m. UTC | #2
On Mon, Feb 25, 2019 at 1:39 PM Daniel P. Berrangé <berrange@redhat.com>
wrote:

> On Sat, Feb 23, 2019 at 01:54:21PM +0300, David Kiarie wrote:
> > Signed-off-by: David Kiarie <davidkiarie4@gmail.com>
> > ---
> >  hw/i386/amd_iommu.c | 2 +-
> >  hw/i386/amd_iommu.h | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>

hello,

i expected this really simple patch to probably get merged right away.

i don't have time to follow up on old issues and not in the mood to be
losing any of my work to sluggishness.
David Kiarie March 4, 2019, 11:41 a.m. UTC | #3
On Mon, Mar 4, 2019 at 2:22 PM David Kiarie <davidkiarie4@gmail.com> wrote:

>
>
>
> On Mon, Feb 25, 2019 at 1:39 PM Daniel P. Berrangé <berrange@redhat.com>
> wrote:
>
>> On Sat, Feb 23, 2019 at 01:54:21PM +0300, David Kiarie wrote:
>> > Signed-off-by: David Kiarie <davidkiarie4@gmail.com>
>> > ---
>> >  hw/i386/amd_iommu.c | 2 +-
>> >  hw/i386/amd_iommu.h | 2 +-
>> >  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>>
>
> hello,
>
> i expected this really simple patch to probably get merged right away.
>
> i don't have time to follow up on old issues and not in the mood to be
> losing any of my work to sluggishness.
>

or, maybe this sounds a lot better, someone see to this very small issue or
just take down the relevant files.
Paolo Bonzini March 4, 2019, 11:44 a.m. UTC | #4
On 04/03/19 12:22, David Kiarie wrote:
> 
> 
> 
> On Mon, Feb 25, 2019 at 1:39 PM Daniel P. Berrangé <berrange@redhat.com
> <mailto:berrange@redhat.com>> wrote:
> 
>     On Sat, Feb 23, 2019 at 01:54:21PM +0300, David Kiarie wrote:
>     > Signed-off-by: David Kiarie <davidkiarie4@gmail.com
>     <mailto:davidkiarie4@gmail.com>>
>     > ---
>     >  hw/i386/amd_iommu.c | 2 +-
>     >  hw/i386/amd_iommu.h | 2 +-
>     >  2 files changed, 2 insertions(+), 2 deletions(-)
> 
>     Reviewed-by: Daniel P. Berrangé <berrange@redhat.com
>     <mailto:berrange@redhat.com>>
> 
> 
> hello, 
> 
> i expected this really simple patch to probably get merged right away.

Patches are usually bundled by maintainers, they do not get merged right
away unless they fix a broken build.

In any case I've queued the patch now.

Paolo

> i don't have time to follow up on old issues and not in the mood to be
> losing any of my work to sluggishness.
David Kiarie March 4, 2019, 11:46 a.m. UTC | #5
On Mon, Mar 4, 2019 at 2:45 PM Paolo Bonzini <pbonzini@redhat.com> wrote:

> On 04/03/19 12:22, David Kiarie wrote:
> >
> >
> >
> > On Mon, Feb 25, 2019 at 1:39 PM Daniel P. Berrangé <berrange@redhat.com
> > <mailto:berrange@redhat.com>> wrote:
> >
> >     On Sat, Feb 23, 2019 at 01:54:21PM +0300, David Kiarie wrote:
> >     > Signed-off-by: David Kiarie <davidkiarie4@gmail.com
> >     <mailto:davidkiarie4@gmail.com>>
> >     > ---
> >     >  hw/i386/amd_iommu.c | 2 +-
> >     >  hw/i386/amd_iommu.h | 2 +-
> >     >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> >     Reviewed-by: Daniel P. Berrangé <berrange@redhat.com
> >     <mailto:berrange@redhat.com>>
> >
> >
> > hello,
> >
> > i expected this really simple patch to probably get merged right away.
>
> Patches are usually bundled by maintainers, they do not get merged right
> away unless they fix a broken build.
>

i see.


>
> In any case I've queued the patch now.


thanks.


>
>
Paolo
>
> > i don't have time to follow up on old issues and not in the mood to be
> > losing any of my work to sluggishness.
>
>
Philippe Mathieu-Daudé March 4, 2019, 11:57 a.m. UTC | #6
Hi David,

On 2/23/19 11:54 AM, David Kiarie wrote:
> Signed-off-by: David Kiarie <davidkiarie4@gmail.com>
> ---
>  hw/i386/amd_iommu.c | 2 +-
>  hw/i386/amd_iommu.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
> index 8ad707a..4f179da 100644
> --- a/hw/i386/amd_iommu.c
> +++ b/hw/i386/amd_iommu.c
> @@ -2,7 +2,7 @@
>   * QEMU emulation of AMD IOMMU (AMD-Vi)
>   *
>   * Copyright (C) 2011 Eduard - Gabriel Munteanu
> - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com>
> + * Copyright (C) 2016 David Kiarie Kahurani

Why do you change the year? Because your work was merged in 2016?

>   *
>   * This program is free software; you can redistribute it and/or modify
>   * it under the terms of the GNU General Public License as published by
> diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h
> index c52886f..cb258a7 100644
> --- a/hw/i386/amd_iommu.h
> +++ b/hw/i386/amd_iommu.h
> @@ -2,7 +2,7 @@
>   * QEMU emulation of an AMD IOMMU (AMD-Vi)
>   *
>   * Copyright (C) 2011 Eduard - Gabriel Munteanu
> - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com>
> + * Copyright (C) 2016 David Kiarie Kahurani
>   *
>   * This program is free software; you can redistribute it and/or modify
>   * it under the terms of the GNU General Public License as published by
>
David Kiarie March 4, 2019, 12:57 p.m. UTC | #7
On Mon, Mar 4, 2019 at 2:57 PM Philippe Mathieu-Daudé <philmd@redhat.com>
wrote:

> Hi David,
>
> On 2/23/19 11:54 AM, David Kiarie wrote:
> > Signed-off-by: David Kiarie <davidkiarie4@gmail.com>
> > ---
> >  hw/i386/amd_iommu.c | 2 +-
> >  hw/i386/amd_iommu.h | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
> > index 8ad707a..4f179da 100644
> > --- a/hw/i386/amd_iommu.c
> > +++ b/hw/i386/amd_iommu.c
> > @@ -2,7 +2,7 @@
> >   * QEMU emulation of AMD IOMMU (AMD-Vi)
> >   *
> >   * Copyright (C) 2011 Eduard - Gabriel Munteanu
> > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com>
> > + * Copyright (C) 2016 David Kiarie Kahurani
>
> Why do you change the year? Because your work was merged in 2016?
>

no.


>
> >   *
> >   * This program is free software; you can redistribute it and/or modify
> >   * it under the terms of the GNU General Public License as published by
> > diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h
> > index c52886f..cb258a7 100644
> > --- a/hw/i386/amd_iommu.h
> > +++ b/hw/i386/amd_iommu.h
> > @@ -2,7 +2,7 @@
> >   * QEMU emulation of an AMD IOMMU (AMD-Vi)
> >   *
> >   * Copyright (C) 2011 Eduard - Gabriel Munteanu
> > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com>
> > + * Copyright (C) 2016 David Kiarie Kahurani
> >   *
> >   * This program is free software; you can redistribute it and/or modify
> >   * it under the terms of the GNU General Public License as published by
> >
>
David Kiarie March 4, 2019, 1:42 p.m. UTC | #8
On Mon, Mar 4, 2019 at 3:57 PM David Kiarie <davidkiarie4@gmail.com> wrote:

>
>
> On Mon, Mar 4, 2019 at 2:57 PM Philippe Mathieu-Daudé <philmd@redhat.com>
> wrote:
>
>> Hi David,
>>
>> On 2/23/19 11:54 AM, David Kiarie wrote:
>> > Signed-off-by: David Kiarie <davidkiarie4@gmail.com>
>> > ---
>> >  hw/i386/amd_iommu.c | 2 +-
>> >  hw/i386/amd_iommu.h | 2 +-
>> >  2 files changed, 2 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
>> > index 8ad707a..4f179da 100644
>> > --- a/hw/i386/amd_iommu.c
>> > +++ b/hw/i386/amd_iommu.c
>> > @@ -2,7 +2,7 @@
>> >   * QEMU emulation of AMD IOMMU (AMD-Vi)
>> >   *
>> >   * Copyright (C) 2011 Eduard - Gabriel Munteanu
>> > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com>
>> > + * Copyright (C) 2016 David Kiarie Kahurani
>>
>> Why do you change the year? Because your work was merged in 2016?
>>
>
> no.
>
>

though, if you have a legitimate issue with the change, you can always air
it.


>
>> >   *
>> >   * This program is free software; you can redistribute it and/or modify
>> >   * it under the terms of the GNU General Public License as published by
>> > diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h
>> > index c52886f..cb258a7 100644
>> > --- a/hw/i386/amd_iommu.h
>> > +++ b/hw/i386/amd_iommu.h
>> > @@ -2,7 +2,7 @@
>> >   * QEMU emulation of an AMD IOMMU (AMD-Vi)
>> >   *
>> >   * Copyright (C) 2011 Eduard - Gabriel Munteanu
>> > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com>
>> > + * Copyright (C) 2016 David Kiarie Kahurani
>> >   *
>> >   * This program is free software; you can redistribute it and/or modify
>> >   * it under the terms of the GNU General Public License as published by
>> >
>>
>
David Kiarie March 4, 2019, 2:10 p.m. UTC | #9
On Mon, Mar 4, 2019 at 4:42 PM David Kiarie <davidkiarie4@gmail.com> wrote:

>
>
> On Mon, Mar 4, 2019 at 3:57 PM David Kiarie <davidkiarie4@gmail.com>
> wrote:
>
>>
>>
>> On Mon, Mar 4, 2019 at 2:57 PM Philippe Mathieu-Daudé <philmd@redhat.com>
>> wrote:
>>
>>> Hi David,
>>>
>>> On 2/23/19 11:54 AM, David Kiarie wrote:
>>> > Signed-off-by: David Kiarie <davidkiarie4@gmail.com>
>>> > ---
>>> >  hw/i386/amd_iommu.c | 2 +-
>>> >  hw/i386/amd_iommu.h | 2 +-
>>> >  2 files changed, 2 insertions(+), 2 deletions(-)
>>> >
>>> > diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
>>> > index 8ad707a..4f179da 100644
>>> > --- a/hw/i386/amd_iommu.c
>>> > +++ b/hw/i386/amd_iommu.c
>>> > @@ -2,7 +2,7 @@
>>> >   * QEMU emulation of AMD IOMMU (AMD-Vi)
>>> >   *
>>> >   * Copyright (C) 2011 Eduard - Gabriel Munteanu
>>> > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com>
>>> > + * Copyright (C) 2016 David Kiarie Kahurani
>>>
>>> Why do you change the year? Because your work was merged in 2016?
>>>
>>
>> no.
>>
>>
>
> though, if you have a legitimate issue with the change, you can always air
> it.
>

you might think random emails are weird but Paolo, i don't expect to see
any activity from you, on Qemu repo before this issue is sorted ;-)


>
>
>>
>>> >   *
>>> >   * This program is free software; you can redistribute it and/or
>>> modify
>>> >   * it under the terms of the GNU General Public License as published
>>> by
>>> > diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h
>>> > index c52886f..cb258a7 100644
>>> > --- a/hw/i386/amd_iommu.h
>>> > +++ b/hw/i386/amd_iommu.h
>>> > @@ -2,7 +2,7 @@
>>> >   * QEMU emulation of an AMD IOMMU (AMD-Vi)
>>> >   *
>>> >   * Copyright (C) 2011 Eduard - Gabriel Munteanu
>>> > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com>
>>> > + * Copyright (C) 2016 David Kiarie Kahurani
>>> >   *
>>> >   * This program is free software; you can redistribute it and/or
>>> modify
>>> >   * it under the terms of the GNU General Public License as published
>>> by
>>> >
>>>
>>
David Kiarie March 4, 2019, 2:36 p.m. UTC | #10
On Mon, Mar 4, 2019 at 5:10 PM David Kiarie <davidkiarie4@gmail.com> wrote:

>
>
> On Mon, Mar 4, 2019 at 4:42 PM David Kiarie <davidkiarie4@gmail.com>
> wrote:
>
>>
>>
>> On Mon, Mar 4, 2019 at 3:57 PM David Kiarie <davidkiarie4@gmail.com>
>> wrote:
>>
>>>
>>>
>>> On Mon, Mar 4, 2019 at 2:57 PM Philippe Mathieu-Daudé <philmd@redhat.com>
>>> wrote:
>>>
>>>> Hi David,
>>>>
>>>> On 2/23/19 11:54 AM, David Kiarie wrote:
>>>> > Signed-off-by: David Kiarie <davidkiarie4@gmail.com>
>>>> > ---
>>>> >  hw/i386/amd_iommu.c | 2 +-
>>>> >  hw/i386/amd_iommu.h | 2 +-
>>>> >  2 files changed, 2 insertions(+), 2 deletions(-)
>>>> >
>>>> > diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
>>>> > index 8ad707a..4f179da 100644
>>>> > --- a/hw/i386/amd_iommu.c
>>>> > +++ b/hw/i386/amd_iommu.c
>>>> > @@ -2,7 +2,7 @@
>>>> >   * QEMU emulation of AMD IOMMU (AMD-Vi)
>>>> >   *
>>>> >   * Copyright (C) 2011 Eduard - Gabriel Munteanu
>>>> > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com>
>>>> > + * Copyright (C) 2016 David Kiarie Kahurani
>>>>
>>>> Why do you change the year? Because your work was merged in 2016?
>>>>
>>>
>>> no.
>>>
>>>
>>
>> though, if you have a legitimate issue with the change, you can always
>> air it.
>>
>
> you might think random emails are weird but Paolo, i don't expect to see
> any activity from you, on Qemu repo before this issue is sorted ;-)
>

i mostly don't care about this code but i *wrote* it. if i am not allowed
even make such minor(which i not a routine), why shouldn't i ask you to
take the files down?


>
>
>>
>>
>>>
>>>> >   *
>>>> >   * This program is free software; you can redistribute it and/or
>>>> modify
>>>> >   * it under the terms of the GNU General Public License as published
>>>> by
>>>> > diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h
>>>> > index c52886f..cb258a7 100644
>>>> > --- a/hw/i386/amd_iommu.h
>>>> > +++ b/hw/i386/amd_iommu.h
>>>> > @@ -2,7 +2,7 @@
>>>> >   * QEMU emulation of an AMD IOMMU (AMD-Vi)
>>>> >   *
>>>> >   * Copyright (C) 2011 Eduard - Gabriel Munteanu
>>>> > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com>
>>>> > + * Copyright (C) 2016 David Kiarie Kahurani
>>>> >   *
>>>> >   * This program is free software; you can redistribute it and/or
>>>> modify
>>>> >   * it under the terms of the GNU General Public License as published
>>>> by
>>>> >
>>>>
>>>
David Kiarie March 4, 2019, 2:40 p.m. UTC | #11
On Mon, Mar 4, 2019 at 5:36 PM David Kiarie <davidkiarie4@gmail.com> wrote:

>
>
> On Mon, Mar 4, 2019 at 5:10 PM David Kiarie <davidkiarie4@gmail.com>
> wrote:
>
>>
>>
>> On Mon, Mar 4, 2019 at 4:42 PM David Kiarie <davidkiarie4@gmail.com>
>> wrote:
>>
>>>
>>>
>>> On Mon, Mar 4, 2019 at 3:57 PM David Kiarie <davidkiarie4@gmail.com>
>>> wrote:
>>>
>>>>
>>>>
>>>> On Mon, Mar 4, 2019 at 2:57 PM Philippe Mathieu-Daudé <
>>>> philmd@redhat.com> wrote:
>>>>
>>>>> Hi David,
>>>>>
>>>>> On 2/23/19 11:54 AM, David Kiarie wrote:
>>>>> > Signed-off-by: David Kiarie <davidkiarie4@gmail.com>
>>>>> > ---
>>>>> >  hw/i386/amd_iommu.c | 2 +-
>>>>> >  hw/i386/amd_iommu.h | 2 +-
>>>>> >  2 files changed, 2 insertions(+), 2 deletions(-)
>>>>> >
>>>>> > diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
>>>>> > index 8ad707a..4f179da 100644
>>>>> > --- a/hw/i386/amd_iommu.c
>>>>> > +++ b/hw/i386/amd_iommu.c
>>>>> > @@ -2,7 +2,7 @@
>>>>> >   * QEMU emulation of AMD IOMMU (AMD-Vi)
>>>>> >   *
>>>>> >   * Copyright (C) 2011 Eduard - Gabriel Munteanu
>>>>> > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com>
>>>>> > + * Copyright (C) 2016 David Kiarie Kahurani
>>>>>
>>>>> Why do you change the year? Because your work was merged in 2016?
>>>>>
>>>>
>>>> no.
>>>>
>>>>
>>>
>>> though, if you have a legitimate issue with the change, you can always
>>> air it.
>>>
>>
>> you might think random emails are weird but Paolo, i don't expect to see
>> any activity from you, on Qemu repo before this issue is sorted ;-)
>>
>
> i mostly don't care about this code but i *wrote* it. if i am not allowed
> even make such minor(which i not a routine), why shouldn't i ask you to
> take the files down?
>

or, rather, a small issue turns into a scene about how clean Qemu is. why
not take down all my dirty code?


>
>
>>
>>
>>>
>>>
>>>>
>>>>> >   *
>>>>> >   * This program is free software; you can redistribute it and/or
>>>>> modify
>>>>> >   * it under the terms of the GNU General Public License as
>>>>> published by
>>>>> > diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h
>>>>> > index c52886f..cb258a7 100644
>>>>> > --- a/hw/i386/amd_iommu.h
>>>>> > +++ b/hw/i386/amd_iommu.h
>>>>> > @@ -2,7 +2,7 @@
>>>>> >   * QEMU emulation of an AMD IOMMU (AMD-Vi)
>>>>> >   *
>>>>> >   * Copyright (C) 2011 Eduard - Gabriel Munteanu
>>>>> > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com>
>>>>> > + * Copyright (C) 2016 David Kiarie Kahurani
>>>>> >   *
>>>>> >   * This program is free software; you can redistribute it and/or
>>>>> modify
>>>>> >   * it under the terms of the GNU General Public License as
>>>>> published by
>>>>> >
>>>>>
>>>>
David Kiarie March 4, 2019, 3:06 p.m. UTC | #12
On Mon, Mar 4, 2019 at 5:40 PM David Kiarie <davidkiarie4@gmail.com> wrote:

>
>
> On Mon, Mar 4, 2019 at 5:36 PM David Kiarie <davidkiarie4@gmail.com>
> wrote:
>
>>
>>
>> On Mon, Mar 4, 2019 at 5:10 PM David Kiarie <davidkiarie4@gmail.com>
>> wrote:
>>
>>>
>>>
>>> On Mon, Mar 4, 2019 at 4:42 PM David Kiarie <davidkiarie4@gmail.com>
>>> wrote:
>>>
>>>>
>>>>
>>>> On Mon, Mar 4, 2019 at 3:57 PM David Kiarie <davidkiarie4@gmail.com>
>>>> wrote:
>>>>
>>>>>
>>>>>
>>>>> On Mon, Mar 4, 2019 at 2:57 PM Philippe Mathieu-Daudé <
>>>>> philmd@redhat.com> wrote:
>>>>>
>>>>>> Hi David,
>>>>>>
>>>>>> On 2/23/19 11:54 AM, David Kiarie wrote:
>>>>>> > Signed-off-by: David Kiarie <davidkiarie4@gmail.com>
>>>>>> > ---
>>>>>> >  hw/i386/amd_iommu.c | 2 +-
>>>>>> >  hw/i386/amd_iommu.h | 2 +-
>>>>>> >  2 files changed, 2 insertions(+), 2 deletions(-)
>>>>>> >
>>>>>> > diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
>>>>>> > index 8ad707a..4f179da 100644
>>>>>> > --- a/hw/i386/amd_iommu.c
>>>>>> > +++ b/hw/i386/amd_iommu.c
>>>>>> > @@ -2,7 +2,7 @@
>>>>>> >   * QEMU emulation of AMD IOMMU (AMD-Vi)
>>>>>> >   *
>>>>>> >   * Copyright (C) 2011 Eduard - Gabriel Munteanu
>>>>>> > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com>
>>>>>> > + * Copyright (C) 2016 David Kiarie Kahurani
>>>>>>
>>>>>> Why do you change the year? Because your work was merged in 2016?
>>>>>>
>>>>>
>>>>> no.
>>>>>
>>>>>
>>>>
>>>> though, if you have a legitimate issue with the change, you can always
>>>> air it.
>>>>
>>>
>>> you might think random emails are weird but Paolo, i don't expect to see
>>> any activity from you, on Qemu repo before this issue is sorted ;-)
>>>
>>
>> i mostly don't care about this code but i *wrote* it. if i am not allowed
>> even make such minor(which i not a routine), why shouldn't i ask you to
>> take the files down?
>>
>
> or, rather, a small issue turns into a scene about how clean Qemu is. why
> not take down all my dirty code?
>

look i'm resending this patch and next time we're having this conversation,
i'll be defacing qemu.


>
>
>>
>>
>>>
>>>
>>>>
>>>>
>>>>>
>>>>>> >   *
>>>>>> >   * This program is free software; you can redistribute it and/or
>>>>>> modify
>>>>>> >   * it under the terms of the GNU General Public License as
>>>>>> published by
>>>>>> > diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h
>>>>>> > index c52886f..cb258a7 100644
>>>>>> > --- a/hw/i386/amd_iommu.h
>>>>>> > +++ b/hw/i386/amd_iommu.h
>>>>>> > @@ -2,7 +2,7 @@
>>>>>> >   * QEMU emulation of an AMD IOMMU (AMD-Vi)
>>>>>> >   *
>>>>>> >   * Copyright (C) 2011 Eduard - Gabriel Munteanu
>>>>>> > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com>
>>>>>> > + * Copyright (C) 2016 David Kiarie Kahurani
>>>>>> >   *
>>>>>> >   * This program is free software; you can redistribute it and/or
>>>>>> modify
>>>>>> >   * it under the terms of the GNU General Public License as
>>>>>> published by
>>>>>> >
>>>>>>
>>>>>
David Kiarie March 4, 2019, 3:13 p.m. UTC | #13
>>>>>>
>>>>>> Hi David,
>>>>>>>
>>>>>>> On 2/23/19 11:54 AM, David Kiarie wrote:
>>>>>>> > Signed-off-by: David Kiarie <davidkiarie4@gmail.com>
>>>>>>> > ---
>>>>>>> >  hw/i386/amd_iommu.c | 2 +-
>>>>>>> >  hw/i386/amd_iommu.h | 2 +-
>>>>>>> >  2 files changed, 2 insertions(+), 2 deletions(-)
>>>>>>> >
>>>>>>> > diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
>>>>>>> > index 8ad707a..4f179da 100644
>>>>>>> > --- a/hw/i386/amd_iommu.c
>>>>>>> > +++ b/hw/i386/amd_iommu.c
>>>>>>> > @@ -2,7 +2,7 @@
>>>>>>> >   * QEMU emulation of AMD IOMMU (AMD-Vi)
>>>>>>> >   *
>>>>>>> >   * Copyright (C) 2011 Eduard - Gabriel Munteanu
>>>>>>> > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com>
>>>>>>> > + * Copyright (C) 2016 David Kiarie Kahurani
>>>>>>>
>>>>>>> Why do you change the year? Because your work was merged in 2016?
>>>>>>>
>>>>>>
>>>>>> no.
>>>>>>
>>>>>>
>>>>>
>>>>> though, if you have a legitimate issue with the change, you can always
>>>>> air it.
>>>>>
>>>>
>>>> you might think random emails are weird but Paolo, i don't expect to
>>>> see any activity from you, on Qemu repo before this issue is sorted ;-)
>>>>
>>>
>>> i mostly don't care about this code but i *wrote* it. if i am not
>>> allowed even make such minor(which i not a routine), why shouldn't i ask
>>> you to take the files down?
>>>
>>
>> or, rather, a small issue turns into a scene about how clean Qemu is. why
>> not take down all my dirty code?
>>
>
> look i'm resending this patch and next time we're having this
> conversation, i'll be defacing qemu.
>


either you have to update my code to what i think it should look like or
you have to take down - wtf

then you try to cook rubbish over it.


>
>
>>
>>
>>>
>>>
>>>>
>>>>
>>>>>
>>>>>
>>>>>>
>>>>>>> >   *
>>>>>>> >   * This program is free software; you can redistribute it and/or
>>>>>>> modify
>>>>>>> >   * it under the terms of the GNU General Public License as
>>>>>>> published by
>>>>>>> > diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h
>>>>>>> > index c52886f..cb258a7 100644
>>>>>>> > --- a/hw/i386/amd_iommu.h
>>>>>>> > +++ b/hw/i386/amd_iommu.h
>>>>>>> > @@ -2,7 +2,7 @@
>>>>>>> >   * QEMU emulation of an AMD IOMMU (AMD-Vi)
>>>>>>> >   *
>>>>>>> >   * Copyright (C) 2011 Eduard - Gabriel Munteanu
>>>>>>> > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com>
>>>>>>> > + * Copyright (C) 2016 David Kiarie Kahurani
>>>>>>> >   *
>>>>>>> >   * This program is free software; you can redistribute it and/or
>>>>>>> modify
>>>>>>> >   * it under the terms of the GNU General Public License as
>>>>>>> published by
>>>>>>> >
>>>>>>>
>>>>>>
David Kiarie March 4, 2019, 3:22 p.m. UTC | #14
On Mon, Mar 4, 2019 at 6:13 PM David Kiarie <davidkiarie4@gmail.com> wrote:

>
>
>
>>>>>>>
>>>>>>> Hi David,
>>>>>>>>
>>>>>>>> On 2/23/19 11:54 AM, David Kiarie wrote:
>>>>>>>> > Signed-off-by: David Kiarie <davidkiarie4@gmail.com>
>>>>>>>> > ---
>>>>>>>> >  hw/i386/amd_iommu.c | 2 +-
>>>>>>>> >  hw/i386/amd_iommu.h | 2 +-
>>>>>>>> >  2 files changed, 2 insertions(+), 2 deletions(-)
>>>>>>>> >
>>>>>>>> > diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
>>>>>>>> > index 8ad707a..4f179da 100644
>>>>>>>> > --- a/hw/i386/amd_iommu.c
>>>>>>>> > +++ b/hw/i386/amd_iommu.c
>>>>>>>> > @@ -2,7 +2,7 @@
>>>>>>>> >   * QEMU emulation of AMD IOMMU (AMD-Vi)
>>>>>>>> >   *
>>>>>>>> >   * Copyright (C) 2011 Eduard - Gabriel Munteanu
>>>>>>>> > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com>
>>>>>>>> > + * Copyright (C) 2016 David Kiarie Kahurani
>>>>>>>>
>>>>>>>> Why do you change the year? Because your work was merged in 2016?
>>>>>>>>
>>>>>>>
>>>>>>> no.
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> though, if you have a legitimate issue with the change, you can
>>>>>> always air it.
>>>>>>
>>>>>
>>>>> you might think random emails are weird but Paolo, i don't expect to
>>>>> see any activity from you, on Qemu repo before this issue is sorted ;-)
>>>>>
>>>>
>>>> i mostly don't care about this code but i *wrote* it. if i am not
>>>> allowed even make such minor(which i not a routine), why shouldn't i ask
>>>> you to take the files down?
>>>>
>>>
>>> or, rather, a small issue turns into a scene about how clean Qemu is.
>>> why not take down all my dirty code?
>>>
>>
>> look i'm resending this patch and next time we're having this
>> conversation, i'll be defacing qemu.
>>
>
>
> either you have to update my code to what i think it should look like or
> you have to take down - wtf
>
> then you try to cook rubbish over it.
>

being a maintainer makes you special but let's see if you'll have something
to maintain.



>
>
>>
>>
>>>
>>>
>>>>
>>>>
>>>>>
>>>>>
>>>>>>
>>>>>>
>>>>>>>
>>>>>>>> >   *
>>>>>>>> >   * This program is free software; you can redistribute it and/or
>>>>>>>> modify
>>>>>>>> >   * it under the terms of the GNU General Public License as
>>>>>>>> published by
>>>>>>>> > diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h
>>>>>>>> > index c52886f..cb258a7 100644
>>>>>>>> > --- a/hw/i386/amd_iommu.h
>>>>>>>> > +++ b/hw/i386/amd_iommu.h
>>>>>>>> > @@ -2,7 +2,7 @@
>>>>>>>> >   * QEMU emulation of an AMD IOMMU (AMD-Vi)
>>>>>>>> >   *
>>>>>>>> >   * Copyright (C) 2011 Eduard - Gabriel Munteanu
>>>>>>>> > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com>
>>>>>>>> > + * Copyright (C) 2016 David Kiarie Kahurani
>>>>>>>> >   *
>>>>>>>> >   * This program is free software; you can redistribute it and/or
>>>>>>>> modify
>>>>>>>> >   * it under the terms of the GNU General Public License as
>>>>>>>> published by
>>>>>>>> >
>>>>>>>>
>>>>>>>
Thomas Huth March 4, 2019, 3:23 p.m. UTC | #15
On 04/03/2019 16.13, David Kiarie wrote:
> 
>                             Hi David,
> 
>                             On 2/23/19 11:54 AM, David Kiarie wrote:
>                             > Signed-off-by: David Kiarie
>                             <davidkiarie4@gmail.com
>                             <mailto:davidkiarie4@gmail.com>>
>                             > ---
>                             >  hw/i386/amd_iommu.c | 2 +-
>                             >  hw/i386/amd_iommu.h | 2 +-
>                             >  2 files changed, 2 insertions(+), 2
>                             deletions(-)
>                             >
>                             > diff --git a/hw/i386/amd_iommu.c
>                             b/hw/i386/amd_iommu.c
>                             > index 8ad707a..4f179da 100644
>                             > --- a/hw/i386/amd_iommu.c
>                             > +++ b/hw/i386/amd_iommu.c
>                             > @@ -2,7 +2,7 @@
>                             >   * QEMU emulation of AMD IOMMU (AMD-Vi)
>                             >   *
>                             >   * Copyright (C) 2011 Eduard - Gabriel
>                             Munteanu
>                             > - * Copyright (C) 2015 David Kiarie,
>                             <davidkiarie4@gmail.com
>                             <mailto:davidkiarie4@gmail.com>>
>                             > + * Copyright (C) 2016 David Kiarie Kahurani
> 
>                             Why do you change the year? Because your
>                             work was merged in 2016?
> 
> 
>                         no.
>                          
> 
> 
>                     though, if you have a legitimate issue with the
>                     change, you can always air it.
> 
> 
>                 you might think random emails are weird but Paolo, i
>                 don't expect to see any activity from you, on Qemu repo
>                 before this issue is sorted ;-)
> 
> 
>             i mostly don't care about this code but i *wrote* it. if i
>             am not allowed even make such minor(which i not a routine),
>             why shouldn't i ask you to take the files down?
> 
> 
>         or, rather, a small issue turns into a scene about how clean
>         Qemu is. why not take down all my dirty code?
> 
> 
>     look i'm resending this patch and next time we're having this
>     conversation, i'll be defacing qemu.
> 
> either you have to update my code to what i think it should look like or
> you have to take down - wtf
> 
> then you try to cook rubbish over it.

Hey, calm down. Paolo said that he'd queue your patch, so it will
eventually get applied. But that just might take some time, the
maintainers only send PULL requests for their queued patches after a
couple of days. So relax, wait some days, and if your patch still did
not get applied in a week, then you can start complaining again.

 Thomas
David Kiarie March 4, 2019, 3:24 p.m. UTC | #16
On Mon, Mar 4, 2019 at 6:22 PM David Kiarie <davidkiarie4@gmail.com> wrote:

>
>
> On Mon, Mar 4, 2019 at 6:13 PM David Kiarie <davidkiarie4@gmail.com>
> wrote:
>
>>
>>
>>
>>>>>>>>
>>>>>>>> Hi David,
>>>>>>>>>
>>>>>>>>> On 2/23/19 11:54 AM, David Kiarie wrote:
>>>>>>>>> > Signed-off-by: David Kiarie <davidkiarie4@gmail.com>
>>>>>>>>> > ---
>>>>>>>>> >  hw/i386/amd_iommu.c | 2 +-
>>>>>>>>> >  hw/i386/amd_iommu.h | 2 +-
>>>>>>>>> >  2 files changed, 2 insertions(+), 2 deletions(-)
>>>>>>>>> >
>>>>>>>>> > diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
>>>>>>>>> > index 8ad707a..4f179da 100644
>>>>>>>>> > --- a/hw/i386/amd_iommu.c
>>>>>>>>> > +++ b/hw/i386/amd_iommu.c
>>>>>>>>> > @@ -2,7 +2,7 @@
>>>>>>>>> >   * QEMU emulation of AMD IOMMU (AMD-Vi)
>>>>>>>>> >   *
>>>>>>>>> >   * Copyright (C) 2011 Eduard - Gabriel Munteanu
>>>>>>>>> > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com>
>>>>>>>>> > + * Copyright (C) 2016 David Kiarie Kahurani
>>>>>>>>>
>>>>>>>>> Why do you change the year? Because your work was merged in 2016?
>>>>>>>>>
>>>>>>>>
>>>>>>>> no.
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>> though, if you have a legitimate issue with the change, you can
>>>>>>> always air it.
>>>>>>>
>>>>>>
>>>>>> you might think random emails are weird but Paolo, i don't expect to
>>>>>> see any activity from you, on Qemu repo before this issue is sorted ;-)
>>>>>>
>>>>>
>>>>> i mostly don't care about this code but i *wrote* it. if i am not
>>>>> allowed even make such minor(which i not a routine), why shouldn't i ask
>>>>> you to take the files down?
>>>>>
>>>>
>>>> or, rather, a small issue turns into a scene about how clean Qemu is.
>>>> why not take down all my dirty code?
>>>>
>>>
>>> look i'm resending this patch and next time we're having this
>>> conversation, i'll be defacing qemu.
>>>
>>
>>
>> either you have to update my code to what i think it should look like or
>> you have to take down - wtf
>>
>> then you try to cook rubbish over it.
>>
>
> being a maintainer makes you special but let's see if you'll have
> something to maintain.
>

because i'm the troll on Qemu ML and maintainers can professionally be
total rubbish.


>
>
>
>>
>>
>>>
>>>
>>>>
>>>>
>>>>>
>>>>>
>>>>>>
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>
>>>>>>>>> >   *
>>>>>>>>> >   * This program is free software; you can redistribute it
>>>>>>>>> and/or modify
>>>>>>>>> >   * it under the terms of the GNU General Public License as
>>>>>>>>> published by
>>>>>>>>> > diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h
>>>>>>>>> > index c52886f..cb258a7 100644
>>>>>>>>> > --- a/hw/i386/amd_iommu.h
>>>>>>>>> > +++ b/hw/i386/amd_iommu.h
>>>>>>>>> > @@ -2,7 +2,7 @@
>>>>>>>>> >   * QEMU emulation of an AMD IOMMU (AMD-Vi)
>>>>>>>>> >   *
>>>>>>>>> >   * Copyright (C) 2011 Eduard - Gabriel Munteanu
>>>>>>>>> > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com>
>>>>>>>>> > + * Copyright (C) 2016 David Kiarie Kahurani
>>>>>>>>> >   *
>>>>>>>>> >   * This program is free software; you can redistribute it
>>>>>>>>> and/or modify
>>>>>>>>> >   * it under the terms of the GNU General Public License as
>>>>>>>>> published by
>>>>>>>>> >
>>>>>>>>>
>>>>>>>>
David Kiarie March 4, 2019, 3:27 p.m. UTC | #17
On Mon, Mar 4, 2019 at 6:23 PM Thomas Huth <thuth@redhat.com> wrote:

> On 04/03/2019 16.13, David Kiarie wrote:
> >
> >                             Hi David,
> >
> >                             On 2/23/19 11:54 AM, David Kiarie wrote:
> >                             > Signed-off-by: David Kiarie
> >                             <davidkiarie4@gmail.com
> >                             <mailto:davidkiarie4@gmail.com>>
> >                             > ---
> >                             >  hw/i386/amd_iommu.c | 2 +-
> >                             >  hw/i386/amd_iommu.h | 2 +-
> >                             >  2 files changed, 2 insertions(+), 2
> >                             deletions(-)
> >                             >
> >                             > diff --git a/hw/i386/amd_iommu.c
> >                             b/hw/i386/amd_iommu.c
> >                             > index 8ad707a..4f179da 100644
> >                             > --- a/hw/i386/amd_iommu.c
> >                             > +++ b/hw/i386/amd_iommu.c
> >                             > @@ -2,7 +2,7 @@
> >                             >   * QEMU emulation of AMD IOMMU (AMD-Vi)
> >                             >   *
> >                             >   * Copyright (C) 2011 Eduard - Gabriel
> >                             Munteanu
> >                             > - * Copyright (C) 2015 David Kiarie,
> >                             <davidkiarie4@gmail.com
> >                             <mailto:davidkiarie4@gmail.com>>
> >                             > + * Copyright (C) 2016 David Kiarie
> Kahurani
> >
> >                             Why do you change the year? Because your
> >                             work was merged in 2016?
> >
> >
> >                         no.
> >
> >
> >
> >                     though, if you have a legitimate issue with the
> >                     change, you can always air it.
> >
> >
> >                 you might think random emails are weird but Paolo, i
> >                 don't expect to see any activity from you, on Qemu repo
> >                 before this issue is sorted ;-)
> >
> >
> >             i mostly don't care about this code but i *wrote* it. if i
> >             am not allowed even make such minor(which i not a routine),
> >             why shouldn't i ask you to take the files down?
> >
> >
> >         or, rather, a small issue turns into a scene about how clean
> >         Qemu is. why not take down all my dirty code?
> >
> >
> >     look i'm resending this patch and next time we're having this
> >     conversation, i'll be defacing qemu.
> >
> > either you have to update my code to what i think it should look like or
> > you have to take down - wtf
> >
> > then you try to cook rubbish over it.
>
> Hey, calm down. Paolo said that he'd queue your patch, so it will
> eventually get applied. But that just might take some time, the
> maintainers only send PULL requests for their queued patches after a
> couple of days. So relax, wait some days, and if your patch still did
> not get applied in a week, then you can start complaining again.
>

i'll not complain again, i'm make a patch to clean my code from your
codebase.


>
>  Thomas
>
David Kiarie March 4, 2019, 3:32 p.m. UTC | #18
On Mon, Mar 4, 2019 at 6:27 PM David Kiarie <davidkiarie4@gmail.com> wrote:

>
>
> On Mon, Mar 4, 2019 at 6:23 PM Thomas Huth <thuth@redhat.com> wrote:
>
>> On 04/03/2019 16.13, David Kiarie wrote:
>> >
>> >                             Hi David,
>> >
>> >                             On 2/23/19 11:54 AM, David Kiarie wrote:
>> >                             > Signed-off-by: David Kiarie
>> >                             <davidkiarie4@gmail.com
>> >                             <mailto:davidkiarie4@gmail.com>>
>> >                             > ---
>> >                             >  hw/i386/amd_iommu.c | 2 +-
>> >                             >  hw/i386/amd_iommu.h | 2 +-
>> >                             >  2 files changed, 2 insertions(+), 2
>> >                             deletions(-)
>> >                             >
>> >                             > diff --git a/hw/i386/amd_iommu.c
>> >                             b/hw/i386/amd_iommu.c
>> >                             > index 8ad707a..4f179da 100644
>> >                             > --- a/hw/i386/amd_iommu.c
>> >                             > +++ b/hw/i386/amd_iommu.c
>> >                             > @@ -2,7 +2,7 @@
>> >                             >   * QEMU emulation of AMD IOMMU (AMD-Vi)
>> >                             >   *
>> >                             >   * Copyright (C) 2011 Eduard - Gabriel
>> >                             Munteanu
>> >                             > - * Copyright (C) 2015 David Kiarie,
>> >                             <davidkiarie4@gmail.com
>> >                             <mailto:davidkiarie4@gmail.com>>
>> >                             > + * Copyright (C) 2016 David Kiarie
>> Kahurani
>> >
>> >                             Why do you change the year? Because your
>> >                             work was merged in 2016?
>> >
>> >
>> >                         no.
>> >
>> >
>> >
>> >                     though, if you have a legitimate issue with the
>> >                     change, you can always air it.
>> >
>> >
>> >                 you might think random emails are weird but Paolo, i
>> >                 don't expect to see any activity from you, on Qemu repo
>> >                 before this issue is sorted ;-)
>> >
>> >
>> >             i mostly don't care about this code but i *wrote* it. if i
>> >             am not allowed even make such minor(which i not a routine),
>> >             why shouldn't i ask you to take the files down?
>> >
>> >
>> >         or, rather, a small issue turns into a scene about how clean
>> >         Qemu is. why not take down all my dirty code?
>> >
>> >
>> >     look i'm resending this patch and next time we're having this
>> >     conversation, i'll be defacing qemu.
>> >
>> > either you have to update my code to what i think it should look like or
>> > you have to take down - wtf
>> >
>> > then you try to cook rubbish over it.
>>
>> Hey, calm down. Paolo said that he'd queue your patch, so it will
>> eventually get applied. But that just might take some time, the
>> maintainers only send PULL requests for their queued patches after a
>> couple of days. So relax, wait some days, and if your patch still did
>> not get applied in a week, then you can start complaining again.
>>
>
> i'll not complain again, i'm make a patch to clean my code from your
> codebase.
>


Qemu have never been important to me like it's important to the maintainers.



>
>
>>
>>  Thomas
>>
>
David Kiarie March 4, 2019, 3:33 p.m. UTC | #19
On Mon, Mar 4, 2019 at 6:32 PM David Kiarie <davidkiarie4@gmail.com> wrote:

>
>
> On Mon, Mar 4, 2019 at 6:27 PM David Kiarie <davidkiarie4@gmail.com>
> wrote:
>
>>
>>
>> On Mon, Mar 4, 2019 at 6:23 PM Thomas Huth <thuth@redhat.com> wrote:
>>
>>> On 04/03/2019 16.13, David Kiarie wrote:
>>> >
>>> >                             Hi David,
>>> >
>>> >                             On 2/23/19 11:54 AM, David Kiarie wrote:
>>> >                             > Signed-off-by: David Kiarie
>>> >                             <davidkiarie4@gmail.com
>>> >                             <mailto:davidkiarie4@gmail.com>>
>>> >                             > ---
>>> >                             >  hw/i386/amd_iommu.c | 2 +-
>>> >                             >  hw/i386/amd_iommu.h | 2 +-
>>> >                             >  2 files changed, 2 insertions(+), 2
>>> >                             deletions(-)
>>> >                             >
>>> >                             > diff --git a/hw/i386/amd_iommu.c
>>> >                             b/hw/i386/amd_iommu.c
>>> >                             > index 8ad707a..4f179da 100644
>>> >                             > --- a/hw/i386/amd_iommu.c
>>> >                             > +++ b/hw/i386/amd_iommu.c
>>> >                             > @@ -2,7 +2,7 @@
>>> >                             >   * QEMU emulation of AMD IOMMU (AMD-Vi)
>>> >                             >   *
>>> >                             >   * Copyright (C) 2011 Eduard - Gabriel
>>> >                             Munteanu
>>> >                             > - * Copyright (C) 2015 David Kiarie,
>>> >                             <davidkiarie4@gmail.com
>>> >                             <mailto:davidkiarie4@gmail.com>>
>>> >                             > + * Copyright (C) 2016 David Kiarie
>>> Kahurani
>>> >
>>> >                             Why do you change the year? Because your
>>> >                             work was merged in 2016?
>>> >
>>> >
>>> >                         no.
>>> >
>>> >
>>> >
>>> >                     though, if you have a legitimate issue with the
>>> >                     change, you can always air it.
>>> >
>>> >
>>> >                 you might think random emails are weird but Paolo, i
>>> >                 don't expect to see any activity from you, on Qemu repo
>>> >                 before this issue is sorted ;-)
>>> >
>>> >
>>> >             i mostly don't care about this code but i *wrote* it. if i
>>> >             am not allowed even make such minor(which i not a routine),
>>> >             why shouldn't i ask you to take the files down?
>>> >
>>> >
>>> >         or, rather, a small issue turns into a scene about how clean
>>> >         Qemu is. why not take down all my dirty code?
>>> >
>>> >
>>> >     look i'm resending this patch and next time we're having this
>>> >     conversation, i'll be defacing qemu.
>>> >
>>> > either you have to update my code to what i think it should look like
>>> or
>>> > you have to take down - wtf
>>> >
>>> > then you try to cook rubbish over it.
>>>
>>> Hey, calm down. Paolo said that he'd queue your patch, so it will
>>> eventually get applied. But that just might take some time, the
>>> maintainers only send PULL requests for their queued patches after a
>>> couple of days. So relax, wait some days, and if your patch still did
>>> not get applied in a week, then you can start complaining again.
>>>
>>
>> i'll not complain again, i'm make a patch to clean my code from your
>> codebase.
>>
>
>
> Qemu have never been important to me like it's important to the
> maintainers.
>
>
i'm sure you can write your own AMD IOMMU.


>
>
>>
>>
>>>
>>>  Thomas
>>>
>>
David Kiarie March 4, 2019, 3:39 p.m. UTC | #20
On Mon, Mar 4, 2019 at 6:33 PM David Kiarie <davidkiarie4@gmail.com> wrote:

>
>
> On Mon, Mar 4, 2019 at 6:32 PM David Kiarie <davidkiarie4@gmail.com>
> wrote:
>
>>
>>
>> On Mon, Mar 4, 2019 at 6:27 PM David Kiarie <davidkiarie4@gmail.com>
>> wrote:
>>
>>>
>>>
>>> On Mon, Mar 4, 2019 at 6:23 PM Thomas Huth <thuth@redhat.com> wrote:
>>>
>>>> On 04/03/2019 16.13, David Kiarie wrote:
>>>> >
>>>> >                             Hi David,
>>>> >
>>>> >                             On 2/23/19 11:54 AM, David Kiarie wrote:
>>>> >                             > Signed-off-by: David Kiarie
>>>> >                             <davidkiarie4@gmail.com
>>>> >                             <mailto:davidkiarie4@gmail.com>>
>>>> >                             > ---
>>>> >                             >  hw/i386/amd_iommu.c | 2 +-
>>>> >                             >  hw/i386/amd_iommu.h | 2 +-
>>>> >                             >  2 files changed, 2 insertions(+), 2
>>>> >                             deletions(-)
>>>> >                             >
>>>> >                             > diff --git a/hw/i386/amd_iommu.c
>>>> >                             b/hw/i386/amd_iommu.c
>>>> >                             > index 8ad707a..4f179da 100644
>>>> >                             > --- a/hw/i386/amd_iommu.c
>>>> >                             > +++ b/hw/i386/amd_iommu.c
>>>> >                             > @@ -2,7 +2,7 @@
>>>> >                             >   * QEMU emulation of AMD IOMMU (AMD-Vi)
>>>> >                             >   *
>>>> >                             >   * Copyright (C) 2011 Eduard - Gabriel
>>>> >                             Munteanu
>>>> >                             > - * Copyright (C) 2015 David Kiarie,
>>>> >                             <davidkiarie4@gmail.com
>>>> >                             <mailto:davidkiarie4@gmail.com>>
>>>> >                             > + * Copyright (C) 2016 David Kiarie
>>>> Kahurani
>>>> >
>>>> >                             Why do you change the year? Because your
>>>> >                             work was merged in 2016?
>>>> >
>>>> >
>>>> >                         no.
>>>> >
>>>> >
>>>> >
>>>> >                     though, if you have a legitimate issue with the
>>>> >                     change, you can always air it.
>>>> >
>>>> >
>>>> >                 you might think random emails are weird but Paolo, i
>>>> >                 don't expect to see any activity from you, on Qemu
>>>> repo
>>>> >                 before this issue is sorted ;-)
>>>> >
>>>> >
>>>> >             i mostly don't care about this code but i *wrote* it. if i
>>>> >             am not allowed even make such minor(which i not a
>>>> routine),
>>>> >             why shouldn't i ask you to take the files down?
>>>> >
>>>> >
>>>> >         or, rather, a small issue turns into a scene about how clean
>>>> >         Qemu is. why not take down all my dirty code?
>>>> >
>>>> >
>>>> >     look i'm resending this patch and next time we're having this
>>>> >     conversation, i'll be defacing qemu.
>>>> >
>>>> > either you have to update my code to what i think it should look like
>>>> or
>>>> > you have to take down - wtf
>>>> >
>>>> > then you try to cook rubbish over it.
>>>>
>>>> Hey, calm down. Paolo said that he'd queue your patch, so it will
>>>> eventually get applied. But that just might take some time, the
>>>> maintainers only send PULL requests for their queued patches after a
>>>> couple of days. So relax, wait some days, and if your patch still did
>>>> not get applied in a week, then you can start complaining again.
>>>>
>>>
>>> i'll not complain again, i'm make a patch to clean my code from your
>>> codebase.
>>>
>>
>>
>> Qemu have never been important to me like it's important to the
>> maintainers.
>>
>>
> i'm sure you can write your own AMD IOMMU.
>

in fact, i'll write the other patch then you can just choose what to merge.

you're not as important as you try to pose.


>
>
>>
>>
>>>
>>>
>>>>
>>>>  Thomas
>>>>
>>>
David Kiarie March 4, 2019, 4:29 p.m. UTC | #21
>
>
>>>>
>>>> On 04/03/2019 16.13, David Kiarie wrote:
>>>>> >
>>>>> >                             Hi David,
>>>>> >
>>>>> >                             On 2/23/19 11:54 AM, David Kiarie wrote:
>>>>> >                             > Signed-off-by: David Kiarie
>>>>> >                             <davidkiarie4@gmail.com
>>>>> >                             <mailto:davidkiarie4@gmail.com>>
>>>>> >                             > ---
>>>>> >                             >  hw/i386/amd_iommu.c | 2 +-
>>>>> >                             >  hw/i386/amd_iommu.h | 2 +-
>>>>> >                             >  2 files changed, 2 insertions(+), 2
>>>>> >                             deletions(-)
>>>>> >                             >
>>>>> >                             > diff --git a/hw/i386/amd_iommu.c
>>>>> >                             b/hw/i386/amd_iommu.c
>>>>> >                             > index 8ad707a..4f179da 100644
>>>>> >                             > --- a/hw/i386/amd_iommu.c
>>>>> >                             > +++ b/hw/i386/amd_iommu.c
>>>>> >                             > @@ -2,7 +2,7 @@
>>>>> >                             >   * QEMU emulation of AMD IOMMU
>>>>> (AMD-Vi)
>>>>> >                             >   *
>>>>> >                             >   * Copyright (C) 2011 Eduard - Gabriel
>>>>> >                             Munteanu
>>>>> >                             > - * Copyright (C) 2015 David Kiarie,
>>>>> >                             <davidkiarie4@gmail.com
>>>>> >                             <mailto:davidkiarie4@gmail.com>>
>>>>> >                             > + * Copyright (C) 2016 David Kiarie
>>>>> Kahurani
>>>>> >
>>>>> >                             Why do you change the year? Because your
>>>>> >                             work was merged in 2016?
>>>>> >
>>>>> >
>>>>> >                         no.
>>>>> >
>>>>> >
>>>>> >
>>>>> >                     though, if you have a legitimate issue with the
>>>>> >                     change, you can always air it.
>>>>> >
>>>>> >
>>>>> >                 you might think random emails are weird but Paolo, i
>>>>> >                 don't expect to see any activity from you, on Qemu
>>>>> repo
>>>>> >                 before this issue is sorted ;-)
>>>>> >
>>>>> >
>>>>> >             i mostly don't care about this code but i *wrote* it. if
>>>>> i
>>>>> >             am not allowed even make such minor(which i not a
>>>>> routine),
>>>>> >             why shouldn't i ask you to take the files down?
>>>>> >
>>>>> >
>>>>> >         or, rather, a small issue turns into a scene about how clean
>>>>> >         Qemu is. why not take down all my dirty code?
>>>>> >
>>>>> >
>>>>> >     look i'm resending this patch and next time we're having this
>>>>> >     conversation, i'll be defacing qemu.
>>>>> >
>>>>> > either you have to update my code to what i think it should look
>>>>> like or
>>>>> > you have to take down - wtf
>>>>> >
>>>>> > then you try to cook rubbish over it.
>>>>>
>>>>> Hey, calm down. Paolo said that he'd queue your patch, so it will
>>>>> eventually get applied. But that just might take some time, the
>>>>> maintainers only send PULL requests for their queued patches after a
>>>>> couple of days. So relax, wait some days, and if your patch still did
>>>>> not get applied in a week, then you can start complaining again.
>>>>>
>>>>
>>>> i'll not complain again, i'm make a patch to clean my code from your
>>>> codebase.
>>>>
>>>
>>>
>>> Qemu have never been important to me like it's important to the
>>> maintainers.
>>>
>>>
>> i'm sure you can write your own AMD IOMMU.
>>
>
> in fact, i'll write the other patch then you can just choose what to merge.
>
> you're not as important as you try to pose.
>

and, by the way, i'm totally okay with Qemu guys stripping my code from
Qemu - that would be a lot better that a maintainer posing important to me
while maintaining code i wrote.

and, mind you, YOU ARE EMPLOYED. I WROTE THIS FOR FUN.


>
>
>>
>>
>>>
>>>
>>>>
>>>>
>>>>>
>>>>>  Thomas
>>>>>
>>>>
diff mbox series

Patch

diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
index 8ad707a..4f179da 100644
--- a/hw/i386/amd_iommu.c
+++ b/hw/i386/amd_iommu.c
@@ -2,7 +2,7 @@ 
  * QEMU emulation of AMD IOMMU (AMD-Vi)
  *
  * Copyright (C) 2011 Eduard - Gabriel Munteanu
- * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com>
+ * Copyright (C) 2016 David Kiarie Kahurani
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h
index c52886f..cb258a7 100644
--- a/hw/i386/amd_iommu.h
+++ b/hw/i386/amd_iommu.h
@@ -2,7 +2,7 @@ 
  * QEMU emulation of an AMD IOMMU (AMD-Vi)
  *
  * Copyright (C) 2011 Eduard - Gabriel Munteanu
- * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com>
+ * Copyright (C) 2016 David Kiarie Kahurani
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by