| Message ID | 20190225115552.7534-3-david@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | s390x/tcg: Cleanups and refactorings for Vector | expand |
On 25/02/2019 12.55, David Hildenbrand wrote: > Let's simply initialization to 0. > > Signed-off-by: David Hildenbrand <david@redhat.com> > --- > target/s390x/translate.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/target/s390x/translate.c b/target/s390x/translate.c > index 19072efec6..c646e50eb3 100644 > --- a/target/s390x/translate.c > +++ b/target/s390x/translate.c > @@ -6091,7 +6091,7 @@ static DisasJumpType translate_one(CPUS390XState *env, DisasContext *s) > const DisasInsn *insn; > DisasJumpType ret = DISAS_NEXT; > DisasFields f; > - DisasOps o; > + DisasOps o = {}; > > /* Search for the insn in the table. */ > insn = extract_insn(env, s, &f); > @@ -6161,12 +6161,6 @@ static DisasJumpType translate_one(CPUS390XState *env, DisasContext *s) > /* Set up the strutures we use to communicate with the helpers. */ > s->insn = insn; > s->fields = &f; > - o.g_out = o.g_out2 = o.g_in1 = o.g_in2 = false; > - o.out = NULL; > - o.out2 = NULL; > - o.in1 = NULL; > - o.in2 = NULL; > - o.addr1 = NULL; > > /* Implement the instruction. */ > if (insn->help_in1) { > Reviewed-by: Thomas Huth <thuth@redhat.com>
On Mon, 25 Feb 2019 12:55:47 +0100 David Hildenbrand <david@redhat.com> wrote: > Let's simply initialization to 0. "Let's simply zero-initialize the structure." ? > > Signed-off-by: David Hildenbrand <david@redhat.com> > --- > target/s390x/translate.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-)
On 25.02.19 13:21, Cornelia Huck wrote: > On Mon, 25 Feb 2019 12:55:47 +0100 > David Hildenbrand <david@redhat.com> wrote: > >> Let's simply initialization to 0. > > "Let's simply zero-initialize the structure." ? Or "s/simply/simplify/", whatever you prefer. > >> >> Signed-off-by: David Hildenbrand <david@redhat.com> >> --- >> target/s390x/translate.c | 8 +------- >> 1 file changed, 1 insertion(+), 7 deletions(-)
On 2/25/19 3:55 AM, David Hildenbrand wrote: > Let's simply initialization to 0. > > Signed-off-by: David Hildenbrand <david@redhat.com> > --- > target/s390x/translate.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) Modulo what ever fixed language you and Connie agree upon. ;-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/target/s390x/translate.c b/target/s390x/translate.c index 19072efec6..c646e50eb3 100644 --- a/target/s390x/translate.c +++ b/target/s390x/translate.c @@ -6091,7 +6091,7 @@ static DisasJumpType translate_one(CPUS390XState *env, DisasContext *s) const DisasInsn *insn; DisasJumpType ret = DISAS_NEXT; DisasFields f; - DisasOps o; + DisasOps o = {}; /* Search for the insn in the table. */ insn = extract_insn(env, s, &f); @@ -6161,12 +6161,6 @@ static DisasJumpType translate_one(CPUS390XState *env, DisasContext *s) /* Set up the strutures we use to communicate with the helpers. */ s->insn = insn; s->fields = &f; - o.g_out = o.g_out2 = o.g_in1 = o.g_in2 = false; - o.out = NULL; - o.out2 = NULL; - o.in1 = NULL; - o.in2 = NULL; - o.addr1 = NULL; /* Implement the instruction. */ if (insn->help_in1) {
Let's simply initialization to 0. Signed-off-by: David Hildenbrand <david@redhat.com> --- target/s390x/translate.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)