| Message ID | 20190225152053.15976-1-kwolf@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Patchew URL: https://patchew.org/QEMU/20190225152053.15976-1-kwolf@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190225152053.15976-1-kwolf@redhat.com
Subject: [Qemu-devel] [PULL 00/71] Block layer patches
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
10b32f5be0 iotests: Skip 211 on insufficient memory
a05be02caa vmdk: false positive of compat6 with hwversion not set
c64025e1f5 iotests: add LUKS payload overhead to 178 qemu-img measure test
c80e628e71 qcow2: include LUKS payload overhead in qemu-img measure
6beaf9e3ab iotests.py: s/_/-/g on keys in qmp_log()
62dbee3637 iotests: Let 045 be run concurrently
24ce684632 iotests: Filter SSH paths
95eecc9714 iotests.py: Filter filename in any string value
7889a8c497 iotests.py: Add is_str()
d505dbed82 iotests: Fix 207 to use QMP filters for qmp_log
96b6f085bb iotests: Fix 232 for LUKS
dd6602fadd iotests: Remove superfluous rm from 232
10dac5f479 iotests: Fix 237 for Python 2.x
c2f383ed9a iotests: Re-add filename filters
470731a3b6 iotests: Test json:{} filenames of internal BDSs
d580ab483f block: BDS options may lack the "driver" option
64f4152927 block/null: Generate filename even with latency-ns
ee9187663b block/curl: Implement bdrv_refresh_filename()
9db1762a1a block/curl: Harmonize option defaults
f66bd55226 block/nvme: Fix bdrv_refresh_filename()
630f7fffac block: Do not copy exact_filename from format file
4e48b99d44 block: Purify .bdrv_refresh_filename()
8592be931f block: Generically refresh runtime options
78eaed8ed7 block: Add BlockDriver.bdrv_gather_child_options
8ecb70ac62 block: Add strong_runtime_opts to BlockDriver
2c2612b1ad iotests: Add quorum case to test 110
3606fa8493 block: Use bdrv_dirname() for relative filenames
c2211aa7d0 block/nfs: Implement bdrv_dirname()
2405785d83 block/nbd: Make bdrv_dirname() return NULL
976dead85d quorum: Make bdrv_dirname() return NULL
da78f0d647 blkverify: Make bdrv_dirname() return NULL
d0cdd12eeb block: Add bdrv_dirname()
ce5fba1b39 block: Fix bdrv_find_backing_image()
980761fa98 block: Add bdrv_make_absolute_filename()
685b9b0e60 block: bdrv_get_full_backing_filename's ret. val.
5d9bc79de6 block: bdrv_get_full_backing_filename_from_...'s ret. val.
6d6f623112 block: Make path_combine() return the path
f487ae593b iotests: Add test for backing file overrides
b567781927 iotests.py: Add node_info()
cad0e50e0b iotests.py: Add filter_imgfmt()
62bdce1333 block: Respect backing bs in bdrv_refresh_filename
bee568962b block: Add BDS.auto_backing_file
c501017de0 block: Skip implicit nodes for filename info
c683acac55 block: Use children list in bdrv_refresh_filename
b5a7a2b366 block: Use bdrv_refresh_filename() to pull
c5dad9864a block/nvme: Remove QEMU_PACKED from naturally aligned NVMeRegs struct
1f4652d66b qcow2: Assert that L2 table offsets fit in the L1 table
be9088d03b tests: add test-bdrv-graph-mod
d0ccc31d4b block: fix bdrv_check_perm for non-tree subgraph
101679f23a block: improve should_update_child
7aca78a67d aio-posix: Assert that aio_poll() is always called in home thread
3eb02d8d80 block: Use normal drain for bdrv_set_aio_context()
a544d77ae2 test-bdrv-drain: AioContext switch in drained section
e92fa43053 block: Fix AioContext switch for drained node
5309365338 block: Don't poll in bdrv_set_aio_context()
a36da7b9b7 nbd: Increase bs->in_flight during AioContext switch
375468b200 nbd: Use low-level QIOChannel API in nbd_read_eof()
16cef5961a nbd: Move nbd_read_eof() to nbd/client.c
00f72b298c io: Remove redundant read/write_coroutine assignments
2c8cf32209 io: Make qio_channel_yield() interruptible
20b541225e nbd: Restrict connection_co reentrance
cdad3c5441 virtio-blk: Increase in_flight for request restart BH
733e2c4b4e block-backend: Make blk_inc/dec_in_flight public
b5b7f641ba qemu-img: fix error reporting for -object
bcf8a8589e commit: Replace commit_top_bs on failure after deleting the block job
84d8dbd9a7 block: don't set the same context
7425640d2e qcow2-snapshot: remove redundant find_snapshot_by_id_and_name call
328390d7f3 block/snapshot: remove bdrv_snapshot_delete_by_id_or_name
e1c3af4a98 block/snapshot.c: eliminate use of ID input in snapshot operations
24361188ea MAINTAINERS: Remove myself as block maintainer
325eaaa06e MAINTAINERS: Replace myself with John Snow for block jobs
=== OUTPUT BEGIN ===
1/71 Checking commit 325eaaa06ec1 (MAINTAINERS: Replace myself with John Snow for block jobs)
2/71 Checking commit 24361188ea3d (MAINTAINERS: Remove myself as block maintainer)
3/71 Checking commit e1c3af4a9878 (block/snapshot.c: eliminate use of ID input in snapshot operations)
4/71 Checking commit 328390d7f386 (block/snapshot: remove bdrv_snapshot_delete_by_id_or_name)
5/71 Checking commit 7425640d2e76 (qcow2-snapshot: remove redundant find_snapshot_by_id_and_name call)
6/71 Checking commit 84d8dbd9a77c (block: don't set the same context)
7/71 Checking commit bcf8a8589e6d (commit: Replace commit_top_bs on failure after deleting the block job)
WARNING: Block comments use a leading /* on a separate line
#28: FILE: block/commit.c:373:
+ /* commit_top_bs has to be replaced after deleting the block job,
WARNING: Block comments use a trailing */ on a separate line
#29: FILE: block/commit.c:374:
+ * otherwise this would fail because of lack of permissions. */
total: 0 errors, 2 warnings, 13 lines checked
Patch 7/71 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/71 Checking commit b5b7f641ba57 (qemu-img: fix error reporting for -object)
9/71 Checking commit 733e2c4b4e0a (block-backend: Make blk_inc/dec_in_flight public)
10/71 Checking commit cdad3c54417d (virtio-blk: Increase in_flight for request restart BH)
WARNING: Block comments use a leading /* on a separate line
#39: FILE: hw/block/virtio-blk.c:856:
+ /* FIXME The data plane is not started yet, so these requests are
WARNING: Block comments use a trailing */ on a separate line
#40: FILE: hw/block/virtio-blk.c:857:
+ * processed in the main thread. */
total: 0 errors, 2 warnings, 18 lines checked
Patch 10/71 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/71 Checking commit 20b541225e54 (nbd: Restrict connection_co reentrance)
12/71 Checking commit 2c8cf32209e3 (io: Make qio_channel_yield() interruptible)
WARNING: Block comments use a leading /* on a separate line
#43: FILE: io/channel.c:473:
+ /* Allow interrupting the operation by reentering the coroutine other than
WARNING: Block comments use a trailing */ on a separate line
#44: FILE: io/channel.c:474:
+ * through the aio_fd_handlers. */
total: 0 errors, 2 warnings, 32 lines checked
Patch 12/71 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/71 Checking commit 00f72b298cfc (io: Remove redundant read/write_coroutine assignments)
14/71 Checking commit 16cef5961a11 (nbd: Move nbd_read_eof() to nbd/client.c)
WARNING: Block comments use a leading /* on a separate line
#38: FILE: nbd/client.c:1390:
+/* nbd_read_eof
total: 0 errors, 1 warnings, 67 lines checked
Patch 14/71 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/71 Checking commit 375468b20082 (nbd: Use low-level QIOChannel API in nbd_read_eof())
ERROR: "(foo*)" should be "(foo *)"
#100: FILE: nbd/client.c:1427:
+ buffer = (uint8_t*) buffer + len;
total: 1 errors, 0 warnings, 93 lines checked
Patch 15/71 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/71 Checking commit a36da7b9b7e5 (nbd: Increase bs->in_flight during AioContext switch)
WARNING: Block comments use a leading /* on a separate line
#27: FILE: block/nbd-client.c:985:
+ /* The node is still drained, so we know the coroutine has yielded in
WARNING: Block comments use a trailing */ on a separate line
#30: FILE: block/nbd-client.c:988:
+ * coroutine.*/
WARNING: Block comments use a leading /* on a separate line
#45: FILE: block/nbd-client.c:1001:
+ /* Need to wait here for the BH to run because the BH must run while the
WARNING: Block comments use a trailing */ on a separate line
#46: FILE: block/nbd-client.c:1002:
+ * node is still drained. */
total: 0 errors, 4 warnings, 32 lines checked
Patch 16/71 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/71 Checking commit 530936533806 (block: Don't poll in bdrv_set_aio_context())
18/71 Checking commit e92fa43053fe (block: Fix AioContext switch for drained node)
19/71 Checking commit a544d77ae25d (test-bdrv-drain: AioContext switch in drained section)
20/71 Checking commit 3eb02d8d80db (block: Use normal drain for bdrv_set_aio_context())
WARNING: Block comments use a leading /* on a separate line
#22: FILE: block.c:5271:
+/* The caller must own the AioContext lock for the old AioContext of bs, but it
WARNING: Block comments use a trailing */ on a separate line
#24: FILE: block.c:5273:
+ * the same as the current context of bs). */
total: 0 errors, 2 warnings, 32 lines checked
Patch 20/71 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/71 Checking commit 7aca78a67ddb (aio-posix: Assert that aio_poll() is always called in home thread)
22/71 Checking commit 101679f23a28 (block: improve should_update_child)
23/71 Checking commit d0ccc31d4b0d (block: fix bdrv_check_perm for non-tree subgraph)
24/71 Checking commit be9088d03b04 (tests: add test-bdrv-graph-mod)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#34:
new file mode 100644
total: 0 errors, 1 warnings, 212 lines checked
Patch 24/71 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
25/71 Checking commit 1f4652d66b23 (qcow2: Assert that L2 table offsets fit in the L1 table)
26/71 Checking commit c5dad9864af9 (block/nvme: Remove QEMU_PACKED from naturally aligned NVMeRegs struct)
27/71 Checking commit b5a7a2b3664e (block: Use bdrv_refresh_filename() to pull)
WARNING: Block comments use a leading /* on a separate line
#269: FILE: blockdev.c:3354:
+ /* This strcmp() is just a shortcut, there is no need to
WARNING: Block comments use a trailing */ on a separate line
#272: FILE: blockdev.c:3357:
+ * return @bs. */
total: 0 errors, 2 warnings, 246 lines checked
Patch 27/71 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
28/71 Checking commit c683acac55d9 (block: Use children list in bdrv_refresh_filename)
WARNING: Block comments use a leading /* on a separate line
#39: FILE: block.c:5546:
+ /* This BDS's file name may depend on any of its children's file names, so
WARNING: Block comments use a trailing */ on a separate line
#40: FILE: block.c:5547:
+ * refresh those first */
total: 0 errors, 2 warnings, 60 lines checked
Patch 28/71 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
29/71 Checking commit c501017de0e5 (block: Skip implicit nodes for filename info)
30/71 Checking commit bee568962b08 (block: Add BDS.auto_backing_file)
WARNING: Block comments use a leading /* on a separate line
#86: FILE: block.c:2401:
+ /* If the user specifies options that do not modify the
WARNING: Block comments use a trailing */ on a separate line
#91: FILE: block.c:2406:
+ * schema forces the user to specify everything). */
WARNING: Block comments use a leading /* on a separate line
#230: FILE: include/block/block_int.h:705:
+ /* The backing filename indicated by the image header; if we ever
WARNING: Block comments use a trailing */ on a separate line
#232: FILE: include/block/block_int.h:707:
+ * filename (i.e. after a bdrv_refresh_filename() run). */
total: 0 errors, 4 warnings, 133 lines checked
Patch 30/71 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
31/71 Checking commit 62bdce13336f (block: Respect backing bs in bdrv_refresh_filename)
WARNING: Block comments use a leading /* on a separate line
#39: FILE: block.c:5543:
+/* Note: This function may return false positives; it may return true
WARNING: Block comments use a trailing */ on a separate line
#41: FILE: block.c:5545:
+ * would result in exactly bs->backing. */
WARNING: Block comments use a leading /* on a separate line
#48: FILE: block.c:5552:
+ /* No backing BDS, so if the image header reports any backing
WARNING: Block comments use a trailing */ on a separate line
#49: FILE: block.c:5553:
+ * file, it must have been suppressed */
WARNING: Block comments use a leading /* on a separate line
#72: FILE: block.c:5604:
+ /* Without I/O, the backing file does not change anything.
WARNING: Block comments use a trailing */ on a separate line
#75: FILE: block.c:5607:
+ * it technically has been. */
total: 0 errors, 6 warnings, 136 lines checked
Patch 31/71 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
32/71 Checking commit cad0e50e0b5c (iotests.py: Add filter_imgfmt())
33/71 Checking commit b5677819277b (iotests.py: Add node_info())
34/71 Checking commit f487ae593bd8 (iotests: Add test for backing file overrides)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13:
new file mode 100755
total: 0 errors, 1 warnings, 333 lines checked
Patch 34/71 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
35/71 Checking commit 6d6f62311299 (block: Make path_combine() return the path)
WARNING: Block comments use a leading /* on a separate line
#30: FILE: block.c:155:
+/* if filename is absolute, just return its duplicate. Otherwise, build a
total: 0 errors, 1 warnings, 148 lines checked
Patch 35/71 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
36/71 Checking commit 5d9bc79de657 (block: bdrv_get_full_backing_filename_from_...'s ret. val.)
37/71 Checking commit 685b9b0e6090 (block: bdrv_get_full_backing_filename's ret. val.)
38/71 Checking commit 980761fa981a (block: Add bdrv_make_absolute_filename())
39/71 Checking commit ce5fba1b39af (block: Fix bdrv_find_backing_image())
40/71 Checking commit d0cdd12eeb46 (block: Add bdrv_dirname())
41/71 Checking commit da78f0d6478a (blkverify: Make bdrv_dirname() return NULL)
WARNING: Block comments use a leading /* on a separate line
#29: FILE: block/blkverify.c:318:
+ /* In general, there are two BDSs with different dirnames below this one;
WARNING: Block comments use a trailing */ on a separate line
#31: FILE: block/blkverify.c:320:
+ * chance). Therefore, to be consistent, just always return NULL. */
total: 0 errors, 2 warnings, 22 lines checked
Patch 41/71 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
42/71 Checking commit 976dead85d94 (quorum: Make bdrv_dirname() return NULL)
WARNING: Block comments use a leading /* on a separate line
#29: FILE: block/quorum.c:1099:
+ /* In general, there are multiple BDSs with different dirnames below this
WARNING: Block comments use a trailing */ on a separate line
#32: FILE: block/quorum.c:1102:
+ * always return NULL. */
total: 0 errors, 2 warnings, 23 lines checked
Patch 42/71 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
43/71 Checking commit 2405785d83d3 (block/nbd: Make bdrv_dirname() return NULL)
WARNING: Block comments use a leading /* on a separate line
#29: FILE: block/nbd.c:533:
+ /* The generic bdrv_dirname() implementation is able to work out some
WARNING: Block comments use a trailing */ on a separate line
#32: FILE: block/nbd.c:536:
+ * directory names. */
total: 0 errors, 2 warnings, 37 lines checked
Patch 43/71 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
44/71 Checking commit c2211aa7d0f1 (block/nfs: Implement bdrv_dirname())
45/71 Checking commit 3606fa84935d (block: Use bdrv_dirname() for relative filenames)
46/71 Checking commit 2c2612b1ad10 (iotests: Add quorum case to test 110)
47/71 Checking commit 8ecb70ac6205 (block: Add strong_runtime_opts to BlockDriver)
WARNING: Block comments use a leading /* on a separate line
#763: FILE: include/block/block_int.h:521:
+ /* Pointer to a NULL-terminated array of names of strong options
WARNING: Block comments use a trailing */ on a separate line
#767: FILE: include/block/block_int.h:525:
+ * "filename" and "driver" are always considered strong. */
total: 0 errors, 2 warnings, 599 lines checked
Patch 47/71 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
48/71 Checking commit 78eaed8ed7ee (block: Add BlockDriver.bdrv_gather_child_options)
49/71 Checking commit 8592be931fbb (block: Generically refresh runtime options)
WARNING: Block comments use a leading /* on a separate line
#106: FILE: block.c:5612:
+ /* While "driver" and "filename" need to be included in a JSON filename,
WARNING: Block comments use a trailing */ on a separate line
#107: FILE: block.c:5613:
+ * their existence does not prohibit generation of a plain filename. */
WARNING: Block comments use a leading /* on a separate line
#130: FILE: block.c:5805:
+ /* Some block drivers may not want to present all of their children's
WARNING: Block comments use a trailing */ on a separate line
#131: FILE: block.c:5806:
+ * options, or name them differently from BdrvChild.name */
total: 0 errors, 4 warnings, 159 lines checked
Patch 49/71 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
50/71 Checking commit 4e48b99d4455 (block: Purify .bdrv_refresh_filename())
WARNING: Block comments use a leading /* on a separate line
#75: FILE: block.c:5657:
+ bool generate_json_filename; /* Whether our default implementation should
WARNING: Block comments use * on subsequent lines
#76: FILE: block.c:5658:
+ bool generate_json_filename; /* Whether our default implementation should
+ fill exact_filename (false) or not (true) */
WARNING: Block comments use a trailing */ on a separate line
#76: FILE: block.c:5658:
+ fill exact_filename (false) or not (true) */
WARNING: Block comments use a leading /* on a separate line
#178: FILE: block.c:5724:
+ /* Obsolete information is of no use here, so drop the old file name
WARNING: Block comments use a trailing */ on a separate line
#179: FILE: block.c:5725:
+ * information before refreshing it */
WARNING: Block comments use a leading /* on a separate line
#188: FILE: block.c:5734:
+ /* If no specific options have been given for this BDS, the filename of
WARNING: Block comments use a trailing */ on a separate line
#189: FILE: block.c:5735:
+ * the underlying file should suffice for this one as well */
WARNING: Block comments use a leading /* on a separate line
#241: FILE: block/blkdebug.c:827:
+ /* Real child options are under "image", but "x-image" may
WARNING: Block comments use a trailing */ on a separate line
#242: FILE: block/blkdebug.c:828:
+ * contain a filename */
total: 0 errors, 9 warnings, 528 lines checked
Patch 50/71 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
51/71 Checking commit 630f7fffac82 (block: Do not copy exact_filename from format file)
52/71 Checking commit f66bd5522628 (block/nvme: Fix bdrv_refresh_filename())
53/71 Checking commit 9db1762a1aab (block/curl: Harmonize option defaults)
54/71 Checking commit ee9187663b75 (block/curl: Implement bdrv_refresh_filename())
WARNING: Block comments use a leading /* on a separate line
#25: FILE: block/curl.c:957:
+ /* "readahead" and "timeout" do not change the guest-visible data,
WARNING: Block comments use a trailing */ on a separate line
#26: FILE: block/curl.c:958:
+ * so ignore them */
total: 0 errors, 2 warnings, 51 lines checked
Patch 54/71 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
55/71 Checking commit 64f4152927d9 (block/null: Generate filename even with latency-ns)
56/71 Checking commit d580ab483f6f (block: BDS options may lack the "driver" option)
WARNING: Block comments use a leading /* on a separate line
#26: FILE: block.c:5622:
+ /* Drivers created with bdrv_new_open_driver() may not have a
WARNING: Block comments use a trailing */ on a separate line
#27: FILE: block.c:5623:
+ * @driver option. Add it here. */
total: 0 errors, 2 warnings, 12 lines checked
Patch 56/71 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
57/71 Checking commit 470731a3b696 (iotests: Test json:{} filenames of internal BDSs)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13:
new file mode 100755
total: 0 errors, 1 warnings, 164 lines checked
Patch 57/71 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
58/71 Checking commit c2f383ed9ab1 (iotests: Re-add filename filters)
59/71 Checking commit 10dac5f479c1 (iotests: Fix 237 for Python 2.x)
60/71 Checking commit dd6602faddfb (iotests: Remove superfluous rm from 232)
61/71 Checking commit 96b6f085bb5f (iotests: Fix 232 for LUKS)
62/71 Checking commit d505dbed82ef (iotests: Fix 207 to use QMP filters for qmp_log)
63/71 Checking commit 7889a8c497f7 (iotests.py: Add is_str())
64/71 Checking commit 95eecc971470 (iotests.py: Filter filename in any string value)
65/71 Checking commit 24ce684632b5 (iotests: Filter SSH paths)
66/71 Checking commit 62dbee3637e4 (iotests: Let 045 be run concurrently)
67/71 Checking commit 6beaf9e3abca (iotests.py: s/_/-/g on keys in qmp_log())
68/71 Checking commit c80e628e7160 (qcow2: include LUKS payload overhead in qemu-img measure)
69/71 Checking commit c64025e1f51f (iotests: add LUKS payload overhead to 178 qemu-img measure test)
70/71 Checking commit a05be02caa4b (vmdk: false positive of compat6 with hwversion not set)
71/71 Checking commit 10b32f5be0f3 (iotests: Skip 211 on insufficient memory)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190225152053.15976-1-kwolf@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
On Mon, 25 Feb 2019 at 15:21, Kevin Wolf <kwolf@redhat.com> wrote: > > The following changes since commit 59a568b57848b10e8a44518a889323f12ccdd8f4: > > Merge remote-tracking branch 'remotes/kraxel/tags/vga-20190222-pull-request' into staging (2019-02-25 12:49:07 +0000) > > are available in the Git repository at: > > git://repo.or.cz/qemu/kevin.git tags/for-upstream > > for you to fetch changes up to 1b967e9f348d48788a2ab481d45398b80ce71fa6: > > Merge remote-tracking branch 'mreitz/tags/pull-block-2019-02-25' into queue-block (2019-02-25 15:16:57 +0100) > > ---------------------------------------------------------------- > Block layer patches: > > - Block graph change fixes (avoid loops, cope with non-tree graphs) > - bdrv_set_aio_context() related fixes > - HMP snapshot commands: Use only tag, not the ID to identify snapshots > - qmeu-img, commit: Error path fixes > - block/nvme: Build fix for gcc 9 > - MAINTAINERS updates > - Fix various issues with bdrv_refresh_filename() > - Fix various iotests > - Include LUKS overhead in qemu-img measure for qcow2 > - A fix for vmdk's image creation interface > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/4.0 for any user-visible changes. -- PMM
The following changes since commit 59a568b57848b10e8a44518a889323f12ccdd8f4: Merge remote-tracking branch 'remotes/kraxel/tags/vga-20190222-pull-request' into staging (2019-02-25 12:49:07 +0000) are available in the Git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to fetch changes up to 1b967e9f348d48788a2ab481d45398b80ce71fa6: Merge remote-tracking branch 'mreitz/tags/pull-block-2019-02-25' into queue-block (2019-02-25 15:16:57 +0100) ---------------------------------------------------------------- Block layer patches: - Block graph change fixes (avoid loops, cope with non-tree graphs) - bdrv_set_aio_context() related fixes - HMP snapshot commands: Use only tag, not the ID to identify snapshots - qmeu-img, commit: Error path fixes - block/nvme: Build fix for gcc 9 - MAINTAINERS updates - Fix various issues with bdrv_refresh_filename() - Fix various iotests - Include LUKS overhead in qemu-img measure for qcow2 - A fix for vmdk's image creation interface ---------------------------------------------------------------- Alberto Garcia (2): commit: Replace commit_top_bs on failure after deleting the block job qcow2: Assert that L2 table offsets fit in the L1 table Daniel Henrique Barboza (3): block/snapshot.c: eliminate use of ID input in snapshot operations block/snapshot: remove bdrv_snapshot_delete_by_id_or_name qcow2-snapshot: remove redundant find_snapshot_by_id_and_name call Daniel P. Berrangé (1): qemu-img: fix error reporting for -object Denis Plotnikov (1): block: don't set the same context Jeff Cody (2): MAINTAINERS: Replace myself with John Snow for block jobs MAINTAINERS: Remove myself as block maintainer Kevin Wolf (14): block-backend: Make blk_inc/dec_in_flight public virtio-blk: Increase in_flight for request restart BH nbd: Restrict connection_co reentrance io: Make qio_channel_yield() interruptible io: Remove redundant read/write_coroutine assignments nbd: Move nbd_read_eof() to nbd/client.c nbd: Use low-level QIOChannel API in nbd_read_eof() nbd: Increase bs->in_flight during AioContext switch block: Don't poll in bdrv_set_aio_context() block: Fix AioContext switch for drained node test-bdrv-drain: AioContext switch in drained section block: Use normal drain for bdrv_set_aio_context() aio-posix: Assert that aio_poll() is always called in home thread Merge remote-tracking branch 'mreitz/tags/pull-block-2019-02-25' into queue-block Max Reitz (42): block: Use bdrv_refresh_filename() to pull block: Use children list in bdrv_refresh_filename block: Skip implicit nodes for filename info block: Add BDS.auto_backing_file block: Respect backing bs in bdrv_refresh_filename iotests.py: Add filter_imgfmt() iotests.py: Add node_info() iotests: Add test for backing file overrides block: Make path_combine() return the path block: bdrv_get_full_backing_filename_from_...'s ret. val. block: bdrv_get_full_backing_filename's ret. val. block: Add bdrv_make_absolute_filename() block: Fix bdrv_find_backing_image() block: Add bdrv_dirname() blkverify: Make bdrv_dirname() return NULL quorum: Make bdrv_dirname() return NULL block/nbd: Make bdrv_dirname() return NULL block/nfs: Implement bdrv_dirname() block: Use bdrv_dirname() for relative filenames iotests: Add quorum case to test 110 block: Add strong_runtime_opts to BlockDriver block: Add BlockDriver.bdrv_gather_child_options block: Generically refresh runtime options block: Purify .bdrv_refresh_filename() block: Do not copy exact_filename from format file block/nvme: Fix bdrv_refresh_filename() block/curl: Harmonize option defaults block/curl: Implement bdrv_refresh_filename() block/null: Generate filename even with latency-ns block: BDS options may lack the "driver" option iotests: Test json:{} filenames of internal BDSs iotests: Re-add filename filters iotests: Fix 237 for Python 2.x iotests: Remove superfluous rm from 232 iotests: Fix 232 for LUKS iotests: Fix 207 to use QMP filters for qmp_log iotests.py: Add is_str() iotests.py: Filter filename in any string value iotests: Filter SSH paths iotests: Let 045 be run concurrently iotests.py: s/_/-/g on keys in qmp_log() iotests: Skip 211 on insufficient memory Stefan Hajnoczi (2): qcow2: include LUKS payload overhead in qemu-img measure iotests: add LUKS payload overhead to 178 qemu-img measure test Thomas Huth (1): block/nvme: Remove QEMU_PACKED from naturally aligned NVMeRegs struct Vladimir Sementsov-Ogievskiy (3): block: improve should_update_child block: fix bdrv_check_perm for non-tree subgraph tests: add test-bdrv-graph-mod yuchenlin (1): vmdk: false positive of compat6 with hwversion not set block/nbd-client.h | 1 + include/block/block.h | 16 +- include/block/block_int.h | 53 +++- include/block/nbd.h | 3 +- include/block/snapshot.h | 3 - include/io/channel.h | 9 +- include/sysemu/block-backend.h | 2 + nbd/nbd-internal.h | 19 -- block.c | 597 +++++++++++++++++++++++++++------------ block/blkdebug.c | 70 ++--- block/blklogwrites.c | 33 +-- block/blkverify.c | 29 +- block/block-backend.c | 4 +- block/commit.c | 7 +- block/crypto.c | 8 + block/curl.c | 55 +++- block/gluster.c | 19 ++ block/iscsi.c | 18 ++ block/mirror.c | 3 +- block/nbd-client.c | 36 ++- block/nbd.c | 46 +-- block/nfs.c | 54 ++-- block/null.c | 32 ++- block/nvme.c | 29 +- block/qapi.c | 16 +- block/qcow.c | 14 +- block/qcow2-cluster.c | 3 + block/qcow2-snapshot.c | 5 - block/qcow2.c | 89 +++++- block/qed.c | 7 +- block/quorum.c | 71 +++-- block/raw-format.c | 11 +- block/rbd.c | 14 + block/replication.c | 10 +- block/sheepdog.c | 12 + block/snapshot.c | 25 +- block/ssh.c | 12 + block/throttle.c | 7 + block/vhdx-log.c | 1 + block/vmdk.c | 46 ++- block/vpc.c | 7 + block/vvfat.c | 12 + block/vxhs.c | 11 + blockdev.c | 8 + hw/block/virtio-blk.c | 4 + io/channel.c | 22 +- nbd/client.c | 52 +++- qemu-img.c | 64 +++-- tests/test-bdrv-drain.c | 32 +++ tests/test-bdrv-graph-mod.c | 198 +++++++++++++ util/aio-posix.c | 3 +- MAINTAINERS | 22 +- hmp-commands.hx | 32 ++- scripts/qemu.py | 5 +- tests/Makefile.include | 2 + tests/qemu-iotests/045 | 2 +- tests/qemu-iotests/051.out | 8 +- tests/qemu-iotests/051.pc.out | 8 +- tests/qemu-iotests/110 | 29 +- tests/qemu-iotests/110.out | 9 +- tests/qemu-iotests/178 | 8 + tests/qemu-iotests/178.out.qcow2 | 24 ++ tests/qemu-iotests/206.out | 56 ++-- tests/qemu-iotests/207 | 10 +- tests/qemu-iotests/207.out | 18 +- tests/qemu-iotests/210 | 5 +- tests/qemu-iotests/210.out | 28 +- tests/qemu-iotests/211 | 9 +- tests/qemu-iotests/211.out | 26 +- tests/qemu-iotests/212 | 5 +- tests/qemu-iotests/212.out | 44 +-- tests/qemu-iotests/213 | 5 +- tests/qemu-iotests/213.out | 46 +-- tests/qemu-iotests/224 | 139 +++++++++ tests/qemu-iotests/224.out | 18 ++ tests/qemu-iotests/228 | 239 ++++++++++++++++ tests/qemu-iotests/228.out | 84 ++++++ tests/qemu-iotests/232 | 5 +- tests/qemu-iotests/237 | 7 +- tests/qemu-iotests/237.out | 54 ++-- tests/qemu-iotests/common.rc | 1 + tests/qemu-iotests/group | 2 + tests/qemu-iotests/iotests.py | 36 ++- 83 files changed, 2191 insertions(+), 697 deletions(-) create mode 100644 tests/test-bdrv-graph-mod.c create mode 100755 tests/qemu-iotests/224 create mode 100644 tests/qemu-iotests/224.out create mode 100755 tests/qemu-iotests/228 create mode 100644 tests/qemu-iotests/228.out