From patchwork Thu Mar 7 17:04:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 10843471 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A44E514DE for ; Thu, 7 Mar 2019 17:17:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 807142F71E for ; Thu, 7 Mar 2019 17:17:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 718292F72B; Thu, 7 Mar 2019 17:17:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 180292F71E for ; Thu, 7 Mar 2019 17:17:30 +0000 (UTC) Received: from localhost ([127.0.0.1]:55786 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1we9-00007S-BN for patchwork-qemu-devel@patchwork.kernel.org; Thu, 07 Mar 2019 12:17:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58902) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1wSC-0006OA-DB for qemu-devel@nongnu.org; Thu, 07 Mar 2019 12:05:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1wS8-0004fU-SZ for qemu-devel@nongnu.org; Thu, 07 Mar 2019 12:05:06 -0500 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]:40872) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h1wS1-0004Qf-Jx for qemu-devel@nongnu.org; Thu, 07 Mar 2019 12:04:58 -0500 Received: by mail-pf1-x435.google.com with SMTP id h1so11900042pfo.7 for ; Thu, 07 Mar 2019 09:04:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Qjf8/+eMsRpPN3rEl0yhqiJZbFAONC5pwBHjHSM3tpI=; b=EnnaHOzQlysAHbLmkr9zwCwAFW80b4ad8PlWUyZg/+7ld5SlvUuyyoYn7uhAMQ9WzM 1VtNE8mWOdl5y5V2IoLEngHtiYS2ARSyDJ5I9rF0gmC+wGFtY6EsR+sbjvt6uy/um634 clX3rYbz2utxFfcoSVOEf1pPI2vKtZ8E1qWu80KQ4gDxB2Eey/8reXqsBl9gqx8xuX1L TNzR2vr1cGexsp/27/dMIgv1hwV8ZF8evX7AI3bff4eP/uRNPs66RJRLaOK3fsSXREeR DCW2ytTfJmCoJOuts1grSG/nEF9uOO98Ykm7KjEVX9fNz0DkxR2Ur6Vq5/n8nBaMweQ8 w+hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Qjf8/+eMsRpPN3rEl0yhqiJZbFAONC5pwBHjHSM3tpI=; b=QDRZ8XOQf2qaLvJZNOM0qLN8Y+PI3yHWKtHRIXrrOiZnwdXKbpAfaSbBttARFxpCsP XefWY4SBrQmCB/r9tbK6NdGvM6qtw+6FshwXGYhlEctjkt0XuOQe0p9uLE6fH0KNjndl SOJrK85WcFSM7yoqv42oSCz9MzGL90aT9hiXS7cTksO4HoPNJ1ABCHXuDz9byCm7/ohG ddp/Euh1bY2WPkfiK8pJB9T3JmJgUIolqwnMwulWlIraK2sfYmcKr6hvF10wk/ABt5k+ KzmV4kHxc/mnVz+D07mNeNsZF4qaRo4qjkcF1JKfsHJhxNph9ZhcxHx+KDMKDeDT0BCh y5JQ== X-Gm-Message-State: APjAAAWZtRG0lXVRlu4PHjbe5rufQ4XAKUD/Vbnvzk4HExkWKI7/zJyt k3ir3tpudOLROy3NPIuycUVtoW8GE+8= X-Google-Smtp-Source: APXvYqwRCSmZt8ADen4z9r/+UCJTmwAG4dRrGNSL38mpSHcXvh5imDHRwp5tCm/60LCFqInV9FkCnw== X-Received: by 2002:a17:902:7614:: with SMTP id k20mr13843529pll.298.1551978293714; Thu, 07 Mar 2019 09:04:53 -0800 (PST) Received: from cloudburst.twiddle.net (97-113-188-82.tukw.qwest.net. [97.113.188.82]) by smtp.gmail.com with ESMTPSA id r82sm10040562pfa.161.2019.03.07.09.04.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Mar 2019 09:04:53 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 7 Mar 2019 09:04:27 -0800 Message-Id: <20190307170440.3113-10-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190307170440.3113-1-richard.henderson@linaro.org> References: <20190307170440.3113-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::435 Subject: [Qemu-devel] [PATCH v4 09/22] target/arm: Implement the SUBP instruction X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- v2: Fix extraction length. --- target/arm/translate-a64.c | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index e756985982..b27f5c697a 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -5290,19 +5290,39 @@ static void handle_crc32(DisasContext *s, */ static void disas_data_proc_2src(DisasContext *s, uint32_t insn) { - unsigned int sf, rm, opcode, rn, rd; + unsigned int sf, rm, opcode, rn, rd, setflag; sf = extract32(insn, 31, 1); + setflag = extract32(insn, 29, 1); rm = extract32(insn, 16, 5); opcode = extract32(insn, 10, 6); rn = extract32(insn, 5, 5); rd = extract32(insn, 0, 5); - if (extract32(insn, 29, 1)) { + if (setflag && opcode != 0) { unallocated_encoding(s); return; } switch (opcode) { + case 0: /* SUBP(S) */ + if (sf == 0 || !dc_isar_feature(aa64_mte_insn_reg, s)) { + goto do_unallocated; + } else { + TCGv_i64 tcg_n, tcg_m, tcg_d; + + tcg_n = read_cpu_reg_sp(s, rn, true); + tcg_m = read_cpu_reg_sp(s, rm, true); + tcg_gen_sextract_i64(tcg_n, tcg_n, 0, 56); + tcg_gen_sextract_i64(tcg_m, tcg_m, 0, 56); + tcg_d = cpu_reg(s, rd); + + if (setflag) { + gen_sub_CC(true, tcg_d, tcg_n, tcg_m); + } else { + tcg_gen_sub_i64(tcg_d, tcg_n, tcg_m); + } + } + break; case 2: /* UDIV */ handle_div(s, false, sf, rm, rn, rd); break;