| Message ID | 20190308202858.26636-1-jsnow@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Patchew URL: https://patchew.org/QEMU/20190308202858.26636-1-jsnow@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20190308202858.26636-1-jsnow@redhat.com
Subject: [Qemu-devel] [PULL 00/17] Bitmaps patches
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20190308202858.26636-1-jsnow@redhat.com -> patchew/20190308202858.26636-1-jsnow@redhat.com
Switched to a new branch 'test'
6a083e7a44 block/dirty-bitmaps: implement inconsistent bit
f00e672dd7 block/dirty-bitmaps: disallow busy bitmaps as merge source
ca8fdb5e18 block/dirty-bitmaps: prohibit removing readonly bitmaps
4085064d76 block/dirty-bitmaps: prohibit readonly bitmaps for backups
46e4307e40 block/dirty-bitmaps: add block_dirty_bitmap_check function
e0e53b95d2 block/dirty-bitmap: add inconsistent status
061152794d block/dirty-bitmaps: add inconsistent bit
20eb6ea4b5 iotests: add busy/recording bit test to 124
f0dea169fe blockdev: remove unused paio parameter documentation
5b090a904b block/dirty-bitmaps: move comment block
235c618265 block/dirty-bitmaps: unify qmp_locked and user_locked calls
9cd31200c1 block/dirty-bitmap: explicitly lock bitmaps with successors
0260a9c1c5 nbd: change error checking order for bitmaps
80fbc5114e block/dirty-bitmap: change semantics of enabled predicate
62a0dda136 block/dirty-bitmap: remove set/reset assertions against enabled bit
4d10356687 block/dirty-bitmaps: rename frozen predicate helper
8e21a1f266 block/dirty-bitmap: add recording and busy properties
=== OUTPUT BEGIN ===
1/17 Checking commit 8e21a1f266ae (block/dirty-bitmap: add recording and busy properties)
2/17 Checking commit 4d10356687c2 (block/dirty-bitmaps: rename frozen predicate helper)
WARNING: line over 80 characters
#87: FILE: block/dirty-bitmap.c:248:
+ error_setg(errp, "Cannot create a successor for a bitmap that is in-use "
total: 0 errors, 1 warnings, 124 lines checked
Patch 2/17 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/17 Checking commit 62a0dda1369b (block/dirty-bitmap: remove set/reset assertions against enabled bit)
4/17 Checking commit 80fbc5114eb1 (block/dirty-bitmap: change semantics of enabled predicate)
5/17 Checking commit 0260a9c1c566 (nbd: change error checking order for bitmaps)
6/17 Checking commit 9cd31200c142 (block/dirty-bitmap: explicitly lock bitmaps with successors)
7/17 Checking commit 235c61826568 (block/dirty-bitmaps: unify qmp_locked and user_locked calls)
ERROR: open brace '{' following function declarations go on the next line
#39: FILE: block/dirty-bitmap.c:190:
+bool bdrv_dirty_bitmap_busy(BdrvDirtyBitmap *bitmap) {
total: 1 errors, 0 warnings, 271 lines checked
Patch 7/17 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/17 Checking commit 5b090a904b91 (block/dirty-bitmaps: move comment block)
9/17 Checking commit f0dea169fe5e (blockdev: remove unused paio parameter documentation)
10/17 Checking commit 20eb6ea4b57a (iotests: add busy/recording bit test to 124)
11/17 Checking commit 061152794d63 (block/dirty-bitmaps: add inconsistent bit)
WARNING: Block comments use a leading /* on a separate line
#26: FILE: block/dirty-bitmap.c:49:
+ bool inconsistent; /* bitmap is persistent, but inconsistent.
WARNING: Block comments use a trailing */ on a separate line
#28: FILE: block/dirty-bitmap.c:51:
+ * a QMP user can remove it. */
total: 0 errors, 2 warnings, 82 lines checked
Patch 11/17 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/17 Checking commit e0e53b95d21c (block/dirty-bitmap: add inconsistent status)
13/17 Checking commit 46e4307e401e (block/dirty-bitmaps: add block_dirty_bitmap_check function)
ERROR: open brace '{' following function declarations go on the next line
#37: FILE: block/dirty-bitmap.c:177:
+static bool bdrv_dirty_bitmap_busy(const BdrvDirtyBitmap *bitmap) {
WARNING: line over 80 characters
#284: FILE: migration/block-dirty-bitmap.c:305:
+ if (bdrv_dirty_bitmap_check(bitmap, BDRV_BITMAP_DEFAULT, &local_err)) {
total: 1 errors, 1 warnings, 236 lines checked
Patch 13/17 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/17 Checking commit 4085064d763d (block/dirty-bitmaps: prohibit readonly bitmaps for backups)
15/17 Checking commit ca8fdb5e18fe (block/dirty-bitmaps: prohibit removing readonly bitmaps)
16/17 Checking commit f00e672dd7a8 (block/dirty-bitmaps: disallow busy bitmaps as merge source)
17/17 Checking commit 6a083e7a449c (block/dirty-bitmaps: implement inconsistent bit)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190308202858.26636-1-jsnow@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190308202858.26636-1-jsnow@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20190308202858.26636-1-jsnow@redhat.com
Subject: [Qemu-devel] [PULL 00/17] Bitmaps patches
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/20190308202858.26636-1-jsnow@redhat.com -> patchew/20190308202858.26636-1-jsnow@redhat.com
Switched to a new branch 'test'
3d5e719ca4 block/dirty-bitmaps: implement inconsistent bit
465831cd59 block/dirty-bitmaps: disallow busy bitmaps as merge source
31780545dd block/dirty-bitmaps: prohibit removing readonly bitmaps
7559e374a2 block/dirty-bitmaps: prohibit readonly bitmaps for backups
aa7d65f2c7 block/dirty-bitmaps: add block_dirty_bitmap_check function
c680f34e1a block/dirty-bitmap: add inconsistent status
144ff09b4a block/dirty-bitmaps: add inconsistent bit
3404fb4d3c iotests: add busy/recording bit test to 124
c1abe84ba0 blockdev: remove unused paio parameter documentation
a9cea08dae block/dirty-bitmaps: move comment block
0c7cb0afda block/dirty-bitmaps: unify qmp_locked and user_locked calls
0978398f68 block/dirty-bitmap: explicitly lock bitmaps with successors
359bac67ac nbd: change error checking order for bitmaps
03ca272dcf block/dirty-bitmap: change semantics of enabled predicate
39788c7010 block/dirty-bitmap: remove set/reset assertions against enabled bit
953dca788e block/dirty-bitmaps: rename frozen predicate helper
ad226cd02f block/dirty-bitmap: add recording and busy properties
=== OUTPUT BEGIN ===
1/17 Checking commit ad226cd02f0d (block/dirty-bitmap: add recording and busy properties)
2/17 Checking commit 953dca788e01 (block/dirty-bitmaps: rename frozen predicate helper)
WARNING: line over 80 characters
#87: FILE: block/dirty-bitmap.c:248:
+ error_setg(errp, "Cannot create a successor for a bitmap that is in-use "
total: 0 errors, 1 warnings, 124 lines checked
Patch 2/17 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/17 Checking commit 39788c7010d2 (block/dirty-bitmap: remove set/reset assertions against enabled bit)
4/17 Checking commit 03ca272dcfe2 (block/dirty-bitmap: change semantics of enabled predicate)
5/17 Checking commit 359bac67ac40 (nbd: change error checking order for bitmaps)
6/17 Checking commit 0978398f6879 (block/dirty-bitmap: explicitly lock bitmaps with successors)
7/17 Checking commit 0c7cb0afdaff (block/dirty-bitmaps: unify qmp_locked and user_locked calls)
ERROR: open brace '{' following function declarations go on the next line
#39: FILE: block/dirty-bitmap.c:190:
+bool bdrv_dirty_bitmap_busy(BdrvDirtyBitmap *bitmap) {
total: 1 errors, 0 warnings, 271 lines checked
Patch 7/17 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/17 Checking commit a9cea08daeed (block/dirty-bitmaps: move comment block)
9/17 Checking commit c1abe84ba004 (blockdev: remove unused paio parameter documentation)
10/17 Checking commit 3404fb4d3ca7 (iotests: add busy/recording bit test to 124)
11/17 Checking commit 144ff09b4a7c (block/dirty-bitmaps: add inconsistent bit)
WARNING: Block comments use a leading /* on a separate line
#26: FILE: block/dirty-bitmap.c:49:
+ bool inconsistent; /* bitmap is persistent, but inconsistent.
WARNING: Block comments use a trailing */ on a separate line
#28: FILE: block/dirty-bitmap.c:51:
+ * a QMP user can remove it. */
total: 0 errors, 2 warnings, 82 lines checked
Patch 11/17 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/17 Checking commit c680f34e1af5 (block/dirty-bitmap: add inconsistent status)
13/17 Checking commit aa7d65f2c71f (block/dirty-bitmaps: add block_dirty_bitmap_check function)
ERROR: open brace '{' following function declarations go on the next line
#37: FILE: block/dirty-bitmap.c:177:
+static bool bdrv_dirty_bitmap_busy(const BdrvDirtyBitmap *bitmap) {
WARNING: line over 80 characters
#284: FILE: migration/block-dirty-bitmap.c:305:
+ if (bdrv_dirty_bitmap_check(bitmap, BDRV_BITMAP_DEFAULT, &local_err)) {
total: 1 errors, 1 warnings, 236 lines checked
Patch 13/17 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/17 Checking commit 7559e374a22f (block/dirty-bitmaps: prohibit readonly bitmaps for backups)
15/17 Checking commit 31780545dd08 (block/dirty-bitmaps: prohibit removing readonly bitmaps)
16/17 Checking commit 465831cd595f (block/dirty-bitmaps: disallow busy bitmaps as merge source)
17/17 Checking commit 3d5e719ca44a (block/dirty-bitmaps: implement inconsistent bit)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190308202858.26636-1-jsnow@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190308202858.26636-1-jsnow@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20190308202858.26636-1-jsnow@redhat.com
Subject: [Qemu-devel] [PULL 00/17] Bitmaps patches
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/20190308202858.26636-1-jsnow@redhat.com -> patchew/20190308202858.26636-1-jsnow@redhat.com
Switched to a new branch 'test'
d67d39e43b block/dirty-bitmaps: implement inconsistent bit
cc50ffdaaa block/dirty-bitmaps: disallow busy bitmaps as merge source
fe93ecd8b1 block/dirty-bitmaps: prohibit removing readonly bitmaps
1d82e65c16 block/dirty-bitmaps: prohibit readonly bitmaps for backups
61c55a9de7 block/dirty-bitmaps: add block_dirty_bitmap_check function
4f1ceecd95 block/dirty-bitmap: add inconsistent status
9d5d76cbd6 block/dirty-bitmaps: add inconsistent bit
bdc998d9d5 iotests: add busy/recording bit test to 124
22c03a2fd5 blockdev: remove unused paio parameter documentation
d74e8a7202 block/dirty-bitmaps: move comment block
8ea8b7a875 block/dirty-bitmaps: unify qmp_locked and user_locked calls
ae989ad6ff block/dirty-bitmap: explicitly lock bitmaps with successors
6c71258b44 nbd: change error checking order for bitmaps
cf861d0168 block/dirty-bitmap: change semantics of enabled predicate
5ba70dfbcf block/dirty-bitmap: remove set/reset assertions against enabled bit
83886ed7db block/dirty-bitmaps: rename frozen predicate helper
0e38e3ff4f block/dirty-bitmap: add recording and busy properties
=== OUTPUT BEGIN ===
1/17 Checking commit 0e38e3ff4ff4 (block/dirty-bitmap: add recording and busy properties)
2/17 Checking commit 83886ed7db44 (block/dirty-bitmaps: rename frozen predicate helper)
WARNING: line over 80 characters
#87: FILE: block/dirty-bitmap.c:248:
+ error_setg(errp, "Cannot create a successor for a bitmap that is in-use "
total: 0 errors, 1 warnings, 124 lines checked
Patch 2/17 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/17 Checking commit 5ba70dfbcf19 (block/dirty-bitmap: remove set/reset assertions against enabled bit)
4/17 Checking commit cf861d01687f (block/dirty-bitmap: change semantics of enabled predicate)
5/17 Checking commit 6c71258b445a (nbd: change error checking order for bitmaps)
6/17 Checking commit ae989ad6ffc7 (block/dirty-bitmap: explicitly lock bitmaps with successors)
7/17 Checking commit 8ea8b7a8757e (block/dirty-bitmaps: unify qmp_locked and user_locked calls)
ERROR: open brace '{' following function declarations go on the next line
#39: FILE: block/dirty-bitmap.c:190:
+bool bdrv_dirty_bitmap_busy(BdrvDirtyBitmap *bitmap) {
total: 1 errors, 0 warnings, 271 lines checked
Patch 7/17 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/17 Checking commit d74e8a720254 (block/dirty-bitmaps: move comment block)
9/17 Checking commit 22c03a2fd589 (blockdev: remove unused paio parameter documentation)
10/17 Checking commit bdc998d9d5ed (iotests: add busy/recording bit test to 124)
11/17 Checking commit 9d5d76cbd6ca (block/dirty-bitmaps: add inconsistent bit)
WARNING: Block comments use a leading /* on a separate line
#26: FILE: block/dirty-bitmap.c:49:
+ bool inconsistent; /* bitmap is persistent, but inconsistent.
WARNING: Block comments use a trailing */ on a separate line
#28: FILE: block/dirty-bitmap.c:51:
+ * a QMP user can remove it. */
total: 0 errors, 2 warnings, 82 lines checked
Patch 11/17 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/17 Checking commit 4f1ceecd9528 (block/dirty-bitmap: add inconsistent status)
13/17 Checking commit 61c55a9de7e4 (block/dirty-bitmaps: add block_dirty_bitmap_check function)
ERROR: open brace '{' following function declarations go on the next line
#37: FILE: block/dirty-bitmap.c:177:
+static bool bdrv_dirty_bitmap_busy(const BdrvDirtyBitmap *bitmap) {
WARNING: line over 80 characters
#284: FILE: migration/block-dirty-bitmap.c:305:
+ if (bdrv_dirty_bitmap_check(bitmap, BDRV_BITMAP_DEFAULT, &local_err)) {
total: 1 errors, 1 warnings, 236 lines checked
Patch 13/17 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/17 Checking commit 1d82e65c16d6 (block/dirty-bitmaps: prohibit readonly bitmaps for backups)
15/17 Checking commit fe93ecd8b1cd (block/dirty-bitmaps: prohibit removing readonly bitmaps)
16/17 Checking commit cc50ffdaaa38 (block/dirty-bitmaps: disallow busy bitmaps as merge source)
17/17 Checking commit d67d39e43b84 (block/dirty-bitmaps: implement inconsistent bit)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190308202858.26636-1-jsnow@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Guess I'll fix these first, sorry for the noise. On 3/8/19 3:53 PM, no-reply@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20190308202858.26636-1-jsnow@redhat.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 20190308202858.26636-1-jsnow@redhat.com > Subject: [Qemu-devel] [PULL 00/17] Bitmaps patches > > === TEST SCRIPT BEGIN === > #!/bin/bash > git rev-parse base > /dev/null || exit 0 > git config --local diff.renamelimit 0 > git config --local diff.renames True > git config --local diff.algorithm histogram > ./scripts/checkpatch.pl --mailback base.. > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > From https://github.com/patchew-project/qemu > t [tag update] patchew/20190308202858.26636-1-jsnow@redhat.com -> patchew/20190308202858.26636-1-jsnow@redhat.com > Switched to a new branch 'test' > d67d39e43b block/dirty-bitmaps: implement inconsistent bit > cc50ffdaaa block/dirty-bitmaps: disallow busy bitmaps as merge source > fe93ecd8b1 block/dirty-bitmaps: prohibit removing readonly bitmaps > 1d82e65c16 block/dirty-bitmaps: prohibit readonly bitmaps for backups > 61c55a9de7 block/dirty-bitmaps: add block_dirty_bitmap_check function > 4f1ceecd95 block/dirty-bitmap: add inconsistent status > 9d5d76cbd6 block/dirty-bitmaps: add inconsistent bit > bdc998d9d5 iotests: add busy/recording bit test to 124 > 22c03a2fd5 blockdev: remove unused paio parameter documentation > d74e8a7202 block/dirty-bitmaps: move comment block > 8ea8b7a875 block/dirty-bitmaps: unify qmp_locked and user_locked calls > ae989ad6ff block/dirty-bitmap: explicitly lock bitmaps with successors > 6c71258b44 nbd: change error checking order for bitmaps > cf861d0168 block/dirty-bitmap: change semantics of enabled predicate > 5ba70dfbcf block/dirty-bitmap: remove set/reset assertions against enabled bit > 83886ed7db block/dirty-bitmaps: rename frozen predicate helper > 0e38e3ff4f block/dirty-bitmap: add recording and busy properties > > === OUTPUT BEGIN === > 1/17 Checking commit 0e38e3ff4ff4 (block/dirty-bitmap: add recording and busy properties) > 2/17 Checking commit 83886ed7db44 (block/dirty-bitmaps: rename frozen predicate helper) > WARNING: line over 80 characters > #87: FILE: block/dirty-bitmap.c:248: > + error_setg(errp, "Cannot create a successor for a bitmap that is in-use " > > total: 0 errors, 1 warnings, 124 lines checked > > Patch 2/17 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > 3/17 Checking commit 5ba70dfbcf19 (block/dirty-bitmap: remove set/reset assertions against enabled bit) > 4/17 Checking commit cf861d01687f (block/dirty-bitmap: change semantics of enabled predicate) > 5/17 Checking commit 6c71258b445a (nbd: change error checking order for bitmaps) > 6/17 Checking commit ae989ad6ffc7 (block/dirty-bitmap: explicitly lock bitmaps with successors) > 7/17 Checking commit 8ea8b7a8757e (block/dirty-bitmaps: unify qmp_locked and user_locked calls) > ERROR: open brace '{' following function declarations go on the next line > #39: FILE: block/dirty-bitmap.c:190: > +bool bdrv_dirty_bitmap_busy(BdrvDirtyBitmap *bitmap) { > > total: 1 errors, 0 warnings, 271 lines checked > > Patch 7/17 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > 8/17 Checking commit d74e8a720254 (block/dirty-bitmaps: move comment block) > 9/17 Checking commit 22c03a2fd589 (blockdev: remove unused paio parameter documentation) > 10/17 Checking commit bdc998d9d5ed (iotests: add busy/recording bit test to 124) > 11/17 Checking commit 9d5d76cbd6ca (block/dirty-bitmaps: add inconsistent bit) > WARNING: Block comments use a leading /* on a separate line > #26: FILE: block/dirty-bitmap.c:49: > + bool inconsistent; /* bitmap is persistent, but inconsistent. > > WARNING: Block comments use a trailing */ on a separate line > #28: FILE: block/dirty-bitmap.c:51: > + * a QMP user can remove it. */ > > total: 0 errors, 2 warnings, 82 lines checked > > Patch 11/17 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > 12/17 Checking commit 4f1ceecd9528 (block/dirty-bitmap: add inconsistent status) > 13/17 Checking commit 61c55a9de7e4 (block/dirty-bitmaps: add block_dirty_bitmap_check function) > ERROR: open brace '{' following function declarations go on the next line > #37: FILE: block/dirty-bitmap.c:177: > +static bool bdrv_dirty_bitmap_busy(const BdrvDirtyBitmap *bitmap) { > > WARNING: line over 80 characters > #284: FILE: migration/block-dirty-bitmap.c:305: > + if (bdrv_dirty_bitmap_check(bitmap, BDRV_BITMAP_DEFAULT, &local_err)) { > > total: 1 errors, 1 warnings, 236 lines checked > > Patch 13/17 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > 14/17 Checking commit 1d82e65c16d6 (block/dirty-bitmaps: prohibit readonly bitmaps for backups) > 15/17 Checking commit fe93ecd8b1cd (block/dirty-bitmaps: prohibit removing readonly bitmaps) > 16/17 Checking commit cc50ffdaaa38 (block/dirty-bitmaps: disallow busy bitmaps as merge source) > 17/17 Checking commit d67d39e43b84 (block/dirty-bitmaps: implement inconsistent bit) > === OUTPUT END === > > Test command exited with code: 1 > > > The full log is available at > http://patchew.org/logs/20190308202858.26636-1-jsnow@redhat.com/testing.checkpatch/?type=message. > --- > Email generated automatically by Patchew [http://patchew.org/]. > Please send your feedback to patchew-devel@redhat.com >
On 3/8/19 2:28 PM, John Snow wrote: > The following changes since commit 234afe78281b10a798fb97c584e1b677844aaab8: > > Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2019-03-08' into staging (2019-03-08 16:31:34 +0000) > > are available in the Git repository at: > > https://github.com/jnsnow/qemu.git tags/bitmaps-pull-request > > for you to fetch changes up to fc91aa3d937e56d512c702d9b966fcea0e499f0e: > > block/dirty-bitmaps: implement inconsistent bit (2019-03-08 14:07:29 -0500) > > ---------------------------------------------------------------- > Pull request Replying to the cover letter in case Peter doesn't see the nested reply: NACK, v2 coming up for minor checkpatch fixes