diff mbox series

[PULL,1/4] util/error: Remove an unnecessary NULL check

Message ID 20190326071233.1947-2-armbru@redhat.com (mailing list archive)
State New, archived
Headers show
Series [PULL,1/4] util/error: Remove an unnecessary NULL check | expand

Commit Message

Markus Armbruster March 26, 2019, 7:12 a.m. UTC 
From: Philippe Mathieu-Daudé <philmd@redhat.com>

This NULL check was required while introduced in 680d16dcb79f.
Later refactor added a NULL check in error_setv(), so this check
is now redundant.

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20190302223825.11192-2-philmd@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 util/error.c | 4 ----
 1 file changed, 4 deletions(-)
diff mbox series

Patch

diff --git a/util/error.c b/util/error.c
index b5ccbd8eac..934a78e1b1 100644
--- a/util/error.c
+++ b/util/error.c
@@ -103,10 +103,6 @@  void error_setg_errno_internal(Error **errp,
     va_list ap;
     int saved_errno = errno;
 
-    if (errp == NULL) {
-        return;
-    }
-
     va_start(ap, fmt);
     error_setv(errp, src, line, func, ERROR_CLASS_GENERIC_ERROR, fmt, ap,
                os_errno != 0 ? strerror(os_errno) : NULL);