| Message ID | 20190409054852.22547-1-sw@weilnetz.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] Fix type of cluster_index | expand |
diff --git a/include/qom/cpu.h b/include/qom/cpu.h index 1d6099e5d4..6a753caed7 100644 --- a/include/qom/cpu.h +++ b/include/qom/cpu.h @@ -422,7 +422,7 @@ struct CPUState { /* TODO Move common fields from CPUArchState here. */ int cpu_index; - int cluster_index; + uint32_t cluster_index; uint32_t halted; uint32_t can_do_io; int32_t exception_index; @@ -1129,6 +1129,6 @@ extern const struct VMStateDescription vmstate_cpu_common; #endif /* NEED_CPU_H */ #define UNASSIGNED_CPU_INDEX -1 -#define UNASSIGNED_CLUSTER_INDEX -1 +#define UNASSIGNED_CLUSTER_INDEX UINT32_MAX #endif
The type should be the same as the type of cluster_id. This fixed a runtime error reported by sanitizers: /qemu/include/exec/tb-lookup.h:33:35: runtime error: left shift of negative value -1 /qemu/accel/tcg/translate-all.c:1692:34: runtime error: left shift of negative value -1 Signed-off-by: Stefan Weil <sw@weilnetz.de> --- v2: Fixed my e-mail address. include/qom/cpu.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)