From patchwork Tue May 7 00:48:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Blanchard X-Patchwork-Id: 10932137 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B0BE2924 for ; Tue, 7 May 2019 00:49:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8B611288D8 for ; Tue, 7 May 2019 00:49:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 63B4B28905; Tue, 7 May 2019 00:49:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C7349288D8 for ; Tue, 7 May 2019 00:49:53 +0000 (UTC) Received: from localhost ([127.0.0.1]:36021 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNoIq-0007qv-Ha for patchwork-qemu-devel@patchwork.kernel.org; Mon, 06 May 2019 20:49:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37353) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNoHW-0006qd-Fg for qemu-devel@nongnu.org; Mon, 06 May 2019 20:48:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hNoHV-0002w4-E6 for qemu-devel@nongnu.org; Mon, 06 May 2019 20:48:30 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:37571) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hNoHV-0002sY-08; Mon, 06 May 2019 20:48:29 -0400 Received: by ozlabs.org (Postfix, from userid 1010) id 44ygvX6pdXz9sB8; Tue, 7 May 2019 10:48:24 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ozlabs.org; s=201707; t=1557190104; bh=SRPwm3An5+fJjsd0L6bwnIgSg1J0AqbyzQJpxhSUQEo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kqIaXQ3Hpik3ht83Rb0ODlmAovYzq29uRMQz604NDt+1LN86ToE238vwroYdS5mTG DHdKiF0hD1R0Pb8IrgiZlvwfC/QND0uAli0cQl2cpJlf+rVg6H9aUqyHmTAycgKSq8 8K6JSQWe6xEFoZaEi8xhWYan9Rddpd4DffVfAgtx5dHS4z/oAbjIEd2WGcL0VWNybX lU6mQfngzeurB9C7DKkV8fNkF60HCnvx6CA+VfMy3ml/L6Xpjsf9s4dCCa8u/w4HC3 W+L/ej12v2taWkD8Cjf93i8Gz00sVvQFhTTpxBYAmsw+wA2VMywRWvgOA9csVdjZQ8 q9I5hq3/M1y8g== From: Anton Blanchard To: qemu-ppc@nongnu.org, qemu-devel@nongnu.org Date: Tue, 7 May 2019 10:48:05 +1000 Message-Id: <20190507004811.29968-3-anton@ozlabs.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190507004811.29968-1-anton@ozlabs.org> References: <20190507004811.29968-1-anton@ozlabs.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 Subject: [Qemu-devel] [PATCH 3/9] target/ppc: Fix xxbrq, xxbrw X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ego@linux.vnet.ibm.com, sandipandas1990@gmail.com, richard.henderson@linaro.org, mark.cave-ayland@ilande.co.uk, f4bug@amsat.org, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Fix a typo in xxbrq and xxbrw where we put both results into the lower doubleword. Fixes: 8b3b2d75c7c0 ("introduce get_cpu_vsr{l,h}() and set_cpu_vsr{l,h}() helpers for VSR register access") Signed-off-by: Anton Blanchard --- target/ppc/translate/vsx-impl.inc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/ppc/translate/vsx-impl.inc.c b/target/ppc/translate/vsx-impl.inc.c index d050cc03ed..05b75105be 100644 --- a/target/ppc/translate/vsx-impl.inc.c +++ b/target/ppc/translate/vsx-impl.inc.c @@ -1192,7 +1192,7 @@ static void gen_xxbrq(DisasContext *ctx) tcg_gen_bswap64_i64(xtl, xbh); set_cpu_vsrl(xT(ctx->opcode), xtl); tcg_gen_mov_i64(xth, t0); - set_cpu_vsrl(xT(ctx->opcode), xth); + set_cpu_vsrh(xT(ctx->opcode), xth); tcg_temp_free_i64(t0); tcg_temp_free_i64(xth); @@ -1220,7 +1220,7 @@ static void gen_xxbrw(DisasContext *ctx) get_cpu_vsrl(xbl, xB(ctx->opcode)); gen_bswap32x4(xth, xtl, xbh, xbl); - set_cpu_vsrl(xT(ctx->opcode), xth); + set_cpu_vsrh(xT(ctx->opcode), xth); set_cpu_vsrl(xT(ctx->opcode), xtl); tcg_temp_free_i64(xth);