| Message ID | 20190618210238.9524-1-mreitz@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iotests: Fix 205 for concurrent runs | expand |
On 6/18/19 4:02 PM, Max Reitz wrote: > Tests should place their files into the test directory. This includes > Unix sockets. 205 currently fails to do so, which prevents it from > being run concurrently. > > Signed-off-by: Max Reitz <mreitz@redhat.com> > --- > tests/qemu-iotests/205 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake <eblake@redhat.com> Feel free to take this through your iotests tree, but I can also stage it through my NBD tree if I haven't seen it go in by the time of my next pull request. > > diff --git a/tests/qemu-iotests/205 b/tests/qemu-iotests/205 > index 69f2c1d392..b8a86c446e 100755 > --- a/tests/qemu-iotests/205 > +++ b/tests/qemu-iotests/205 > @@ -24,7 +24,7 @@ import iotests > import time > from iotests import qemu_img_create, qemu_io, filter_qemu_io, QemuIoInteractive > > -nbd_sock = 'nbd_sock' > +nbd_sock = os.path.join(iotests.test_dir, 'nbd_sock') > nbd_uri = 'nbd+unix:///exp?socket=' + nbd_sock > disk = os.path.join(iotests.test_dir, 'disk') > >
On 18.06.19 23:02, Max Reitz wrote: > Tests should place their files into the test directory. This includes > Unix sockets. 205 currently fails to do so, which prevents it from > being run concurrently. > > Signed-off-by: Max Reitz <mreitz@redhat.com> > --- > tests/qemu-iotests/205 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks for the review, applied to my block branch. Max
diff --git a/tests/qemu-iotests/205 b/tests/qemu-iotests/205 index 69f2c1d392..b8a86c446e 100755 --- a/tests/qemu-iotests/205 +++ b/tests/qemu-iotests/205 @@ -24,7 +24,7 @@ import iotests import time from iotests import qemu_img_create, qemu_io, filter_qemu_io, QemuIoInteractive -nbd_sock = 'nbd_sock' +nbd_sock = os.path.join(iotests.test_dir, 'nbd_sock') nbd_uri = 'nbd+unix:///exp?socket=' + nbd_sock disk = os.path.join(iotests.test_dir, 'disk')
Tests should place their files into the test directory. This includes Unix sockets. 205 currently fails to do so, which prevents it from being run concurrently. Signed-off-by: Max Reitz <mreitz@redhat.com> --- tests/qemu-iotests/205 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)