[01/17] MAINTAINERS: new maintainers for QOM

Commit Message

Markus Armbruster June 19, 2019, 8:10 p.m. UTC

From: Paolo Bonzini <[e-mail]>

QOM is not a particularly active subsystem now: 51 commits in two years.
But, we need active maintainers to review and merge patches, and Git
shows the following top committers taking on QOM:

    Markus Armbruster <[e-mail]>
    Eduardo Habkost <[e-mail]>
    Paolo Bonzini <[e-mail]>
    Marc-André Lureau <[e-mail]>
    Eric Blake <[e-mail]>

I volunteer myself, and also volunteer Eduardo and Daniel as reviewers
since they understand the code well.

Cc: Andreas Färber <[e-mail]>
Cc: Daniel P. Berrange <[e-mail]>
Cc: Eduardo Habkost <[e-mail]>
Suggested-by: Markus Armbruster <[e-mail]>
Signed-off-by: Paolo Bonzini <[e-mail]>
Message-Id: <[e-mail]>
Signed-off-by: Markus Armbruster <[e-mail]>
---
 MAINTAINERS | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Andreas Färber June 19, 2019, 8:31 p.m. UTC | #1

Am 19.06.19 um 22:10 schrieb Markus Armbruster:
> From: Paolo Bonzini <[e-mail]>
> 
> QOM is not a particularly active subsystem now: 51 commits in two years.
> But, we need active maintainers to review and merge patches, and Git
> shows the following top committers taking on QOM:
> 
>     Markus Armbruster <[e-mail]>
>     Eduardo Habkost <[e-mail]>
>     Paolo Bonzini <[e-mail]>
>     Marc-André Lureau <[e-mail]>
>     Eric Blake <[e-mail]>
> 
> I volunteer myself, and also volunteer Eduardo and Daniel as reviewers
> since they understand the code well.
> 
> Cc: Andreas Färber <[e-mail]>
> Cc: Daniel P. Berrange <[e-mail]>
> Cc: Eduardo Habkost <[e-mail]>
> Suggested-by: Markus Armbruster <[e-mail]>
> Signed-off-by: Paolo Bonzini <[e-mail]>
> Message-Id: <[e-mail]>
> Signed-off-by: Markus Armbruster <[e-mail]>

I'm pretty sure I gave an Acked-by that's missing above?

Regards,
Andreas

Daniel P. Berrangé June 20, 2019, 8:31 a.m. UTC | #2

On Wed, Jun 19, 2019 at 10:10:34PM +0200, Markus Armbruster wrote:
> From: Paolo Bonzini <[e-mail]>
> 
> QOM is not a particularly active subsystem now: 51 commits in two years.
> But, we need active maintainers to review and merge patches, and Git
> shows the following top committers taking on QOM:
> 
>     Markus Armbruster <[e-mail]>
>     Eduardo Habkost <[e-mail]>
>     Paolo Bonzini <[e-mail]>
>     Marc-André Lureau <[e-mail]>
>     Eric Blake <[e-mail]>
> 
> I volunteer myself, and also volunteer Eduardo and Daniel as reviewers
> since they understand the code well.
> 
> Cc: Andreas Färber <[e-mail]>
> Cc: Daniel P. Berrange <[e-mail]>
> Cc: Eduardo Habkost <[e-mail]>
> Suggested-by: Markus Armbruster <[e-mail]>
> Signed-off-by: Paolo Bonzini <[e-mail]>
> Message-Id: <[e-mail]>
> Signed-off-by: Markus Armbruster <[e-mail]>
> ---
>  MAINTAINERS | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <[e-mail]>


Regards,
Daniel

Paolo Bonzini June 20, 2019, 8:37 a.m. UTC | #3

On 19/06/19 22:31, Andreas Färber wrote:
> Am 19.06.19 um 22:10 schrieb Markus Armbruster:
>> From: Paolo Bonzini <[e-mail]>
>>
>> QOM is not a particularly active subsystem now: 51 commits in two years.
>> But, we need active maintainers to review and merge patches, and Git
>> shows the following top committers taking on QOM:
>>
>>     Markus Armbruster <[e-mail]>
>>     Eduardo Habkost <[e-mail]>
>>     Paolo Bonzini <[e-mail]>
>>     Marc-André Lureau <[e-mail]>
>>     Eric Blake <[e-mail]>
>>
>> I volunteer myself, and also volunteer Eduardo and Daniel as reviewers
>> since they understand the code well.
>>
>> Cc: Andreas Färber <[e-mail]>
>> Cc: Daniel P. Berrange <[e-mail]>
>> Cc: Eduardo Habkost <[e-mail]>
>> Suggested-by: Markus Armbruster <[e-mail]>
>> Signed-off-by: Paolo Bonzini <[e-mail]>
>> Message-Id: <[e-mail]>
>> Signed-off-by: Markus Armbruster <[e-mail]>
> 
> I'm pretty sure I gave an Acked-by that's missing above?

Yes, and Markus even replied to it:

https://patchew.org/QEMU/[e-mail]/

Paolo

Markus Armbruster June 24, 2019, 11:07 a.m. UTC | #4

Andreas Färber <[e-mail]> writes:

> Am 19.06.19 um 22:10 schrieb Markus Armbruster:
>> From: Paolo Bonzini <[e-mail]>
>> 
>> QOM is not a particularly active subsystem now: 51 commits in two years.
>> But, we need active maintainers to review and merge patches, and Git
>> shows the following top committers taking on QOM:
>> 
>>     Markus Armbruster <[e-mail]>
>>     Eduardo Habkost <[e-mail]>
>>     Paolo Bonzini <[e-mail]>
>>     Marc-André Lureau <[e-mail]>
>>     Eric Blake <[e-mail]>
>> 
>> I volunteer myself, and also volunteer Eduardo and Daniel as reviewers
>> since they understand the code well.
>> 
>> Cc: Andreas Färber <[e-mail]>
>> Cc: Daniel P. Berrange <[e-mail]>
>> Cc: Eduardo Habkost <[e-mail]>
>> Suggested-by: Markus Armbruster <[e-mail]>
>> Signed-off-by: Paolo Bonzini <[e-mail]>
>> Message-Id: <[e-mail]>
>> Signed-off-by: Markus Armbruster <[e-mail]>
>
> I'm pretty sure I gave an Acked-by that's missing above?

My fault.  I'll make sure it's in v2 or else the pull request.

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index d32c5c2313..63390eadb5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2029,9 +2029,10 @@  F: docs/interop/qemu-ga-ref.texi
 T: git https://github.com/mdroth/qemu.git qga
 
 QOM
-M: Andreas Färber <[e-mail]>
+M: Paolo Bonzini <[e-mail]>
+R: Daniel P. Berrange <[e-mail]>
+R: Eduardo Habkost <[e-mail]>
 S: Supported
-T: git https://github.com/afaerber/qemu-cpu.git qom-next
 F: include/qom/
 X: include/qom/cpu.h
 F: qom/