mbox

[PULL,00/19] testing/next (tests/vm, Travis and hyperv build fix)

Message ID 20190624134337.10532-1-alex.bennee@linaro.org (mailing list archive)
State New, archived
Headers show

Pull-request

https://github.com/stsquad/qemu.git tags/pull-testing-next-240619-1

Message

Alex Bennée June 24, 2019, 1:43 p.m. UTC
The following changes since commit 474f3938d79ab36b9231c9ad3b5a9314c2aeacde:

  Merge remote-tracking branch 'remotes/amarkovic/tags/mips-queue-jun-21-2019' into staging (2019-06-21 15:40:50 +0100)

are available in the Git repository at:

  https://github.com/stsquad/qemu.git tags/pull-testing-next-240619-1

for you to fetch changes up to e0fe22c3528773fcbfd135a0ef7f6b3c5d373bb9:

  target/i386: fix feature check in hyperv-stub.c (2019-06-24 14:36:39 +0100)

----------------------------------------------------------------
Various testing fixes:

   - tests/vm updates and clean-ups
   - tests/vm serial autobuild on host
   - ensure MacOS builds do "brew update"
   - ensure we test --static user builds
   - fix hyperv compile failure

This brings my testing back to green on all CI services.

----------------------------------------------------------------
Alex Bennée (3):
      .travis.yml: default the --disable-system build to --static
      .travis.yml: force a brew update for MacOS builds
      target/i386: fix feature check in hyperv-stub.c

Cleber Rosa (4):
      tests/vm: avoid extra compressed image copy
      tests/vm: avoid image presence check and removal
      tests/vm: pin ubuntu.i386 image
      tests/vm: add source repos on ubuntu.i386

Gerd Hoffmann (11):
      tests/vm: send proxy environment variables over ssh
      tests/vm: use ssh with pty unconditionally
      tests/vm: run test builds on snapshot
      tests/vm: proper guest shutdown
      tests/vm: add vm-boot-{ssh,serial}-<guest> targets
      tests/vm: serial console support helpers
      tests/vm: openbsd autoinstall, using serial console
      tests/vm: freebsd autoinstall, using serial console
      tests/vm: netbsd autoinstall, using serial console
      tests/vm: fedora autoinstall, using serial console
      tests/vm: ubuntu.i386: apt proxy setup

Philippe Mathieu-Daudé (1):
      Makefile: Rename the 'vm-test' target as 'vm-help'

 .travis.yml               |   3 +-
 Makefile                  |   4 +-
 docs/devel/testing.rst    |   4 +-
 target/i386/hyperv-stub.c |   2 +-
 tests/vm/Makefile.include |  28 ++++++-
 tests/vm/basevm.py        | 135 ++++++++++++++++++++++++++++-----
 tests/vm/centos           |   6 +-
 tests/vm/fedora           | 189 ++++++++++++++++++++++++++++++++++++++++++++++
 tests/vm/freebsd          | 180 ++++++++++++++++++++++++++++++++++++++++---
 tests/vm/netbsd           | 187 ++++++++++++++++++++++++++++++++++++++++++---
 tests/vm/openbsd          | 159 ++++++++++++++++++++++++++++++++++----
 tests/vm/ubuntu.i386      |  11 ++-
 12 files changed, 841 insertions(+), 67 deletions(-)
 create mode 100755 tests/vm/fedora

--
2.20.1

Comments

Peter Maydell July 1, 2019, 9:52 a.m. UTC | #1
On Mon, 24 Jun 2019 at 14:43, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> The following changes since commit 474f3938d79ab36b9231c9ad3b5a9314c2aeacde:
>
>   Merge remote-tracking branch 'remotes/amarkovic/tags/mips-queue-jun-21-2019' into staging (2019-06-21 15:40:50 +0100)
>
> are available in the Git repository at:
>
>   https://github.com/stsquad/qemu.git tags/pull-testing-next-240619-1
>
> for you to fetch changes up to e0fe22c3528773fcbfd135a0ef7f6b3c5d373bb9:
>
>   target/i386: fix feature check in hyperv-stub.c (2019-06-24 14:36:39 +0100)
>
> ----------------------------------------------------------------
> Various testing fixes:
>
>    - tests/vm updates and clean-ups
>    - tests/vm serial autobuild on host
>    - ensure MacOS builds do "brew update"
>    - ensure we test --static user builds
>    - fix hyperv compile failure
>
> This brings my testing back to green on all CI services.

The FreeBSD tests pass OK but the new output includes
some stuff that trips my "find error/warning messages grep:
con recv: /etc/rc: WARNING: $hostname is not set -- see rc.conf(5).
con recv: /etc/rc: WARNING: hostid: unable to figure out a UUID from
DMI data, generating a new one
pkg: Repository FreeBSD load error: access repo
file(/var/db/pkg/repo-FreeBSD.sqlite) failed: No such file or
directory
        p5-Error: 0.17027

There's also a new compile warning:
/home/qemu/qemu-test.r7G0Wv/src/migration/rdma.c:842:26: warning:
unused variable 'port_attr' [-Wunused-variable]
    struct ibv_port_attr port_attr;
                         ^
which I guess was not being flagged up by the old compiler/VM image.

OpenBSD also passes but has some output which my 'find warnings'
grep picks up:

con recv: WARNING: root is targeted by password guessing attacks,
pubkeys are safer.

thanks
-- PMM
Alex Bennée July 1, 2019, 3:07 p.m. UTC | #2
Peter Maydell <peter.maydell@linaro.org> writes:

> On Mon, 24 Jun 2019 at 14:43, Alex Bennée <alex.bennee@linaro.org> wrote:
>>
>> The following changes since commit 474f3938d79ab36b9231c9ad3b5a9314c2aeacde:
>>
>>   Merge remote-tracking branch 'remotes/amarkovic/tags/mips-queue-jun-21-2019' into staging (2019-06-21 15:40:50 +0100)
>>
>> are available in the Git repository at:
>>
>>   https://github.com/stsquad/qemu.git tags/pull-testing-next-240619-1
>>
>> for you to fetch changes up to e0fe22c3528773fcbfd135a0ef7f6b3c5d373bb9:
>>
>>   target/i386: fix feature check in hyperv-stub.c (2019-06-24 14:36:39 +0100)
>>
>> ----------------------------------------------------------------
>> Various testing fixes:
>>
>>    - tests/vm updates and clean-ups
>>    - tests/vm serial autobuild on host
>>    - ensure MacOS builds do "brew update"
>>    - ensure we test --static user builds
>>    - fix hyperv compile failure
>>
>> This brings my testing back to green on all CI services.
>
> The FreeBSD tests pass OK but the new output includes
> some stuff that trips my "find error/warning messages grep:
> con recv: /etc/rc: WARNING: $hostname is not set -- see rc.conf(5).
> con recv: /etc/rc: WARNING: hostid: unable to figure out a UUID from
> DMI data, generating a new one

These are artefacts of setting up a new system - we have no hostname
until we've been through the setup. It won't occur on installed systems.

> pkg: Repository FreeBSD load error: access repo
> file(/var/db/pkg/repo-FreeBSD.sqlite) failed: No such file or
> directory
>         p5-Error: 0.17027

That seems to be a transient fault I haven't been able to replicate.

>
> There's also a new compile warning:
> /home/qemu/qemu-test.r7G0Wv/src/migration/rdma.c:842:26: warning:
> unused variable 'port_attr' [-Wunused-variable]
>     struct ibv_port_attr port_attr;

Fixed.

>                          ^
> which I guess was not being flagged up by the old compiler/VM image.
>
> OpenBSD also passes but has some output which my 'find warnings'
> grep picks up:
>
> con recv: WARNING: root is targeted by password guessing attacks,
> pubkeys are safer.

Looking at this now.

>
> thanks
> -- PMM

--
Alex Bennée
Alex Bennée July 1, 2019, 3:58 p.m. UTC | #3
Peter Maydell <peter.maydell@linaro.org> writes:

> On Mon, 24 Jun 2019 at 14:43, Alex Bennée <alex.bennee@linaro.org> wrote:
>>
>> The following changes since commit 474f3938d79ab36b9231c9ad3b5a9314c2aeacde:
>>
>>   Merge remote-tracking branch 'remotes/amarkovic/tags/mips-queue-jun-21-2019' into staging (2019-06-21 15:40:50 +0100)
<snip>
>
> OpenBSD also passes but has some output which my 'find warnings'
> grep picks up:
>
> con recv: WARNING: root is targeted by password guessing attacks,
> pubkeys are safer.

This is a warning the installer issues before it asks you the question:

  Allow root ssh login?

Again this will only occur on the initial setup.

Can you whitelist these warnings on your script?

--
Alex Bennée
Philippe Mathieu-Daudé July 2, 2019, 10:10 a.m. UTC | #4
On 7/1/19 5:58 PM, Alex Bennée wrote:
> 
> Peter Maydell <peter.maydell@linaro.org> writes:
> 
>> On Mon, 24 Jun 2019 at 14:43, Alex Bennée <alex.bennee@linaro.org> wrote:
>>>
>>> The following changes since commit 474f3938d79ab36b9231c9ad3b5a9314c2aeacde:
>>>
>>>   Merge remote-tracking branch 'remotes/amarkovic/tags/mips-queue-jun-21-2019' into staging (2019-06-21 15:40:50 +0100)
> <snip>
>>
>> OpenBSD also passes but has some output which my 'find warnings'
>> grep picks up:
>>
>> con recv: WARNING: root is targeted by password guessing attacks,
>> pubkeys are safer.
> 
> This is a warning the installer issues before it asks you the question:
> 
>   Allow root ssh login?
> 
> Again this will only occur on the initial setup.
> 
> Can you whitelist these warnings on your script?

Hmm if this is installer-only warning, why not filter it in
OpenBSDVM::build_image()?
Alex Bennée July 2, 2019, 10:28 a.m. UTC | #5
Philippe Mathieu-Daudé <philmd@redhat.com> writes:

> On 7/1/19 5:58 PM, Alex Bennée wrote:
>>
>> Peter Maydell <peter.maydell@linaro.org> writes:
>>
>>> On Mon, 24 Jun 2019 at 14:43, Alex Bennée <alex.bennee@linaro.org> wrote:
>>>>
>>>> The following changes since commit 474f3938d79ab36b9231c9ad3b5a9314c2aeacde:
>>>>
>>>>   Merge remote-tracking branch 'remotes/amarkovic/tags/mips-queue-jun-21-2019' into staging (2019-06-21 15:40:50 +0100)
>> <snip>
>>>
>>> OpenBSD also passes but has some output which my 'find warnings'
>>> grep picks up:
>>>
>>> con recv: WARNING: root is targeted by password guessing attacks,
>>> pubkeys are safer.
>>
>> This is a warning the installer issues before it asks you the question:
>>
>>   Allow root ssh login?
>>
>> Again this will only occur on the initial setup.
>>
>> Can you whitelist these warnings on your script?
>
> Hmm if this is installer-only warning, why not filter it in
> OpenBSDVM::build_image()?

We could I guess. I'd prefer it if we could have the check for warnings
script in the source tree and documented so it's easier to see when we
trip up this stuff.

--
Alex Bennée
Peter Maydell July 2, 2019, 10:29 a.m. UTC | #6
On Tue, 2 Jul 2019 at 11:28, Alex Bennée <alex.bennee@linaro.org> wrote:
> We could I guess. I'd prefer it if we could have the check for warnings
> script in the source tree and documented so it's easier to see when we
> trip up this stuff.

Well, it's part of my ad-hoc testing scripts. If we can move
to using gitlab runners or whatever it'll become obsolete.

thanks
-- PMM