| Message ID | 20190716122836.31187-5-thuth@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Enable iotests during "make check" | expand |
On 16.07.19 14:28, Thomas Huth wrote: > Since most iotests are now run during "make check" already, we do not > need to test them explicitly from the gitlab-ci.yml script anymore. > And while we're at it, add some of the new non-auto tests >= 248 instead. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > .gitlab-ci.yml | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > index c63bf2f822..fa5d094453 100644 > --- a/.gitlab-ci.yml > +++ b/.gitlab-ci.yml > @@ -45,15 +45,9 @@ build-tcg-disabled: > - ./check -raw 001 002 003 004 005 008 009 010 011 012 021 025 032 033 048 > 052 063 077 086 101 104 106 113 147 148 150 151 152 157 159 160 > 163 170 171 183 184 192 194 197 205 208 215 221 222 226 227 236 > - - ./check -qcow2 001 002 003 004 005 007 008 009 010 011 012 013 017 018 019 > - 020 021 022 024 025 027 028 029 031 032 033 034 035 036 037 038 > - 039 040 042 043 046 047 048 049 050 051 052 053 054 056 057 058 > - 060 061 062 063 065 066 067 068 069 071 072 073 074 079 080 082 > - 085 086 089 090 091 095 096 097 098 099 102 103 104 105 107 108 > - 110 111 114 117 120 122 124 126 127 129 130 132 133 134 137 138 > - 139 140 141 142 143 144 145 147 150 151 152 154 155 156 157 158 > - 161 165 170 172 174 176 177 179 184 186 187 190 192 194 195 196 > - 197 200 202 203 205 208 209 214 215 216 217 218 222 226 227 229 234 > + - ./check -qcow2 028 040 051 056 057 058 065 067 068 082 085 091 095 096 102 > + 124 127 129 132 139 142 144 145 147 151 152 155 157 165 194 196 > + 200 202 203 205 208 209 216 218 222 227 234 248 250 254 255 256 This removes 197 and 215. Why? Max
On 16/07/2019 17.41, Max Reitz wrote: > On 16.07.19 14:28, Thomas Huth wrote: >> Since most iotests are now run during "make check" already, we do not >> need to test them explicitly from the gitlab-ci.yml script anymore. >> And while we're at it, add some of the new non-auto tests >= 248 instead. >> >> Signed-off-by: Thomas Huth <thuth@redhat.com> >> --- >> .gitlab-ci.yml | 12 +++--------- >> 1 file changed, 3 insertions(+), 9 deletions(-) >> >> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml >> index c63bf2f822..fa5d094453 100644 >> --- a/.gitlab-ci.yml >> +++ b/.gitlab-ci.yml >> @@ -45,15 +45,9 @@ build-tcg-disabled: >> - ./check -raw 001 002 003 004 005 008 009 010 011 012 021 025 032 033 048 >> 052 063 077 086 101 104 106 113 147 148 150 151 152 157 159 160 >> 163 170 171 183 184 192 194 197 205 208 215 221 222 226 227 236 >> - - ./check -qcow2 001 002 003 004 005 007 008 009 010 011 012 013 017 018 019 >> - 020 021 022 024 025 027 028 029 031 032 033 034 035 036 037 038 >> - 039 040 042 043 046 047 048 049 050 051 052 053 054 056 057 058 >> - 060 061 062 063 065 066 067 068 069 071 072 073 074 079 080 082 >> - 085 086 089 090 091 095 096 097 098 099 102 103 104 105 107 108 >> - 110 111 114 117 120 122 124 126 127 129 130 132 133 134 137 138 >> - 139 140 141 142 143 144 145 147 150 151 152 154 155 156 157 158 >> - 161 165 170 172 174 176 177 179 184 186 187 190 192 194 195 196 >> - 197 200 202 203 205 208 209 214 215 216 217 218 222 226 227 229 234 >> + - ./check -qcow2 028 040 051 056 057 058 065 067 068 082 085 091 095 096 102 >> + 124 127 129 132 139 142 144 145 147 151 152 155 157 165 194 196 >> + 200 202 203 205 208 209 216 218 222 227 234 248 250 254 255 256 > > This removes 197 and 215. Why? As mentioned in the cover letter, I've seen problems with 197 and 215 in the gitlab CI pipelines (since the two tests apparently cause a lot of memory pressure). At least they were causing trouble when "make check" was running with other tests in parallel. Maybe they still work fine when they run alone here. I'll give it another try... Thomas
On 16.07.19 17:51, Thomas Huth wrote: > On 16/07/2019 17.41, Max Reitz wrote: >> On 16.07.19 14:28, Thomas Huth wrote: >>> Since most iotests are now run during "make check" already, we do not >>> need to test them explicitly from the gitlab-ci.yml script anymore. >>> And while we're at it, add some of the new non-auto tests >= 248 instead. >>> >>> Signed-off-by: Thomas Huth <thuth@redhat.com> >>> --- >>> .gitlab-ci.yml | 12 +++--------- >>> 1 file changed, 3 insertions(+), 9 deletions(-) >>> >>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml >>> index c63bf2f822..fa5d094453 100644 >>> --- a/.gitlab-ci.yml >>> +++ b/.gitlab-ci.yml >>> @@ -45,15 +45,9 @@ build-tcg-disabled: >>> - ./check -raw 001 002 003 004 005 008 009 010 011 012 021 025 032 033 048 >>> 052 063 077 086 101 104 106 113 147 148 150 151 152 157 159 160 >>> 163 170 171 183 184 192 194 197 205 208 215 221 222 226 227 236 >>> - - ./check -qcow2 001 002 003 004 005 007 008 009 010 011 012 013 017 018 019 >>> - 020 021 022 024 025 027 028 029 031 032 033 034 035 036 037 038 >>> - 039 040 042 043 046 047 048 049 050 051 052 053 054 056 057 058 >>> - 060 061 062 063 065 066 067 068 069 071 072 073 074 079 080 082 >>> - 085 086 089 090 091 095 096 097 098 099 102 103 104 105 107 108 >>> - 110 111 114 117 120 122 124 126 127 129 130 132 133 134 137 138 >>> - 139 140 141 142 143 144 145 147 150 151 152 154 155 156 157 158 >>> - 161 165 170 172 174 176 177 179 184 186 187 190 192 194 195 196 >>> - 197 200 202 203 205 208 209 214 215 216 217 218 222 226 227 229 234 >>> + - ./check -qcow2 028 040 051 056 057 058 065 067 068 082 085 091 095 096 102 >>> + 124 127 129 132 139 142 144 145 147 151 152 155 157 165 194 196 >>> + 200 202 203 205 208 209 216 218 222 227 234 248 250 254 255 256 >> >> This removes 197 and 215. Why? > > As mentioned in the cover letter, I've seen problems with 197 and 215 in > the gitlab CI pipelines (since the two tests apparently cause a lot of > memory pressure). At least they were causing trouble when "make check" > was running with other tests in parallel. Maybe they still work fine > when they run alone here. I'll give it another try... OK. Shouldn’t this be mentioned in the commit message here, too? ;-) Reviewed-by: Max Reitz <mreitz@redhat.com>
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index c63bf2f822..fa5d094453 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -45,15 +45,9 @@ build-tcg-disabled: - ./check -raw 001 002 003 004 005 008 009 010 011 012 021 025 032 033 048 052 063 077 086 101 104 106 113 147 148 150 151 152 157 159 160 163 170 171 183 184 192 194 197 205 208 215 221 222 226 227 236 - - ./check -qcow2 001 002 003 004 005 007 008 009 010 011 012 013 017 018 019 - 020 021 022 024 025 027 028 029 031 032 033 034 035 036 037 038 - 039 040 042 043 046 047 048 049 050 051 052 053 054 056 057 058 - 060 061 062 063 065 066 067 068 069 071 072 073 074 079 080 082 - 085 086 089 090 091 095 096 097 098 099 102 103 104 105 107 108 - 110 111 114 117 120 122 124 126 127 129 130 132 133 134 137 138 - 139 140 141 142 143 144 145 147 150 151 152 154 155 156 157 158 - 161 165 170 172 174 176 177 179 184 186 187 190 192 194 195 196 - 197 200 202 203 205 208 209 214 215 216 217 218 222 226 227 229 234 + - ./check -qcow2 028 040 051 056 057 058 065 067 068 082 085 091 095 096 102 + 124 127 129 132 139 142 144 145 147 151 152 155 157 165 194 196 + 200 202 203 205 208 209 216 218 222 227 234 248 250 254 255 256 build-user: script:
Since most iotests are now run during "make check" already, we do not need to test them explicitly from the gitlab-ci.yml script anymore. And while we're at it, add some of the new non-auto tests >= 248 instead. Signed-off-by: Thomas Huth <thuth@redhat.com> --- .gitlab-ci.yml | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-)