From patchwork Fri Jul 19 11:23:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11050029 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BEC9C746 for ; Fri, 19 Jul 2019 11:23:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AED51287BD for ; Fri, 19 Jul 2019 11:23:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A03A8287FA; Fri, 19 Jul 2019 11:23:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 56CF1287BD for ; Fri, 19 Jul 2019 11:23:33 +0000 (UTC) Received: from localhost ([::1]:44110 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hoQz6-0007mR-An for patchwork-qemu-devel@patchwork.kernel.org; Fri, 19 Jul 2019 07:23:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37117) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hoQyy-0007Nj-Kp for qemu-devel@nongnu.org; Fri, 19 Jul 2019 07:23:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hoQyx-0006v4-MA for qemu-devel@nongnu.org; Fri, 19 Jul 2019 07:23:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40426) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hoQyx-0006uI-HE for qemu-devel@nongnu.org; Fri, 19 Jul 2019 07:23:23 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A39AF308620E; Fri, 19 Jul 2019 11:23:22 +0000 (UTC) Received: from x1w.redhat.com (unknown [10.40.205.153]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6640564037; Fri, 19 Jul 2019 11:23:18 +0000 (UTC) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Date: Fri, 19 Jul 2019 13:23:15 +0200 Message-Id: <20190719112315.14432-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Fri, 19 Jul 2019 11:23:22 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [RFC PATCH-for-4.1] target/i386: Correct misplaced break statement in gen_shiftd_rm_T1() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= , Eduardo Habkost , Richard Henderson Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Reported by GCC9 when building with CFLAG -Wimplicit-fallthrough=2: CC target/i386/translate.o target/i386/translate.c: In function ‘gen_shiftd_rm_T1’: target/i386/translate.c:1785:12: error: this statement may fall through [-Werror=implicit-fallthrough=] 1785 | if (is_right) { | ^ target/i386/translate.c:1810:5: note: here 1810 | default: | ^~~~~~~ cc1: all warnings being treated as errors Fixes: f437d0a3c24 Signed-off-by: Philippe Mathieu-Daudé --- target/i386/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/translate.c b/target/i386/translate.c index 03150a86e2..4b2b5937ca 100644 --- a/target/i386/translate.c +++ b/target/i386/translate.c @@ -1805,8 +1805,8 @@ static void gen_shiftd_rm_T1(DisasContext *s, TCGMemOp ot, int op1, tcg_gen_shri_i64(s->tmp0, s->tmp0, 32); tcg_gen_shri_i64(s->T0, s->T0, 32); } - break; #endif + break; default: tcg_gen_subi_tl(s->tmp0, count, 1); if (is_right) {