| Message ID | 20190725155735.11872-7-mreitz@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | vmdk: Misc fixes | expand |
On 7/25/19 11:57 AM, Max Reitz wrote: > The error message for the test case where we have a quorum node for > which no directory name can be generated is different: For > twoGbMaxExtentSparse, it complains that it cannot open the extent file. > For other (sub)formats, it just notes that it cannot determine the > backing file path. Both are fine, but just disable twoGbMaxExtentSparse > for simplicity's sake. > > Signed-off-by: Max Reitz <mreitz@redhat.com> > --- > tests/qemu-iotests/110 | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/qemu-iotests/110 b/tests/qemu-iotests/110 > index 2cdc7c8a72..2ef516baf1 100755 > --- a/tests/qemu-iotests/110 > +++ b/tests/qemu-iotests/110 > @@ -40,7 +40,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 > # Any format supporting backing files > _supported_fmt qed qcow qcow2 vmdk > _supported_proto file > -_unsupported_imgopts "subformat=monolithicFlat" "subformat=twoGbMaxExtentFlat" > +_unsupported_imgopts "subformat=monolithicFlat" "subformat=twoGbMaxExtentFlat" \ > + "subformat=twoGbMaxExtentSparse" > > TEST_IMG_REL=$(basename "$TEST_IMG") > > Hm, fine. This is the second patch I've seen today that tries to work around error messages changing because of configuration options, though. Wonder if we need a more general purpose solution to this kind of thing. Ah, well, regardless... good enough for now, I think, probably. Reviewed-by: John Snow <jsnow@redhat.com>
diff --git a/tests/qemu-iotests/110 b/tests/qemu-iotests/110 index 2cdc7c8a72..2ef516baf1 100755 --- a/tests/qemu-iotests/110 +++ b/tests/qemu-iotests/110 @@ -40,7 +40,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 # Any format supporting backing files _supported_fmt qed qcow qcow2 vmdk _supported_proto file -_unsupported_imgopts "subformat=monolithicFlat" "subformat=twoGbMaxExtentFlat" +_unsupported_imgopts "subformat=monolithicFlat" "subformat=twoGbMaxExtentFlat" \ + "subformat=twoGbMaxExtentSparse" TEST_IMG_REL=$(basename "$TEST_IMG")
The error message for the test case where we have a quorum node for which no directory name can be generated is different: For twoGbMaxExtentSparse, it complains that it cannot open the extent file. For other (sub)formats, it just notes that it cannot determine the backing file path. Both are fine, but just disable twoGbMaxExtentSparse for simplicity's sake. Signed-off-by: Max Reitz <mreitz@redhat.com> --- tests/qemu-iotests/110 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)