[v4,10/54] translate-all: use cpu_in_exclusive_work_context() in tb_flush

Commit Message

Alex Bennée July 31, 2019, 4:06 p.m. UTC

From: "Emilio G. Cota" <[e-mail]>

tb_flush will be called by the plugin module from a safe
work environment. Prepare for that.

Suggested-by: Alex Bennée <[e-mail]>
Reviewed-by: Alex Bennée <[e-mail]>
Signed-off-by: Emilio G. Cota <[e-mail]>
Signed-off-by: Alex Bennée <[e-mail]>
---
 accel/tcg/translate-all.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

Comments

Richard Henderson Aug. 1, 2019, 3:25 p.m. UTC | #1

On 7/31/19 9:06 AM, Alex Bennée wrote:
> From: "Emilio G. Cota" <[e-mail]>
> 
> tb_flush will be called by the plugin module from a safe
> work environment. Prepare for that.
> 
> Suggested-by: Alex Bennée <[e-mail]>
> Reviewed-by: Alex Bennée <[e-mail]>
> Signed-off-by: Emilio G. Cota <[e-mail]>
> Signed-off-by: Alex Bennée <[e-mail]>
> ---
>  accel/tcg/translate-all.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)

Reviewed-by: Richard Henderson <[e-mail]>


r~

Patch

diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c
index 5d1e08b1699..9c5c60ed964 100644
--- a/accel/tcg/translate-all.c
+++ b/accel/tcg/translate-all.c
@@ -1268,8 +1268,13 @@  void tb_flush(CPUState *cpu)
 {
     if (tcg_enabled()) {
         unsigned tb_flush_count = atomic_mb_read(&tb_ctx.tb_flush_count);
-        async_safe_run_on_cpu(cpu, do_tb_flush,
-                              RUN_ON_CPU_HOST_INT(tb_flush_count));
+
+        if (cpu_in_exclusive_context(cpu)) {
+            do_tb_flush(cpu, RUN_ON_CPU_HOST_INT(tb_flush_count));
+        } else {
+            async_safe_run_on_cpu(cpu, do_tb_flush,
+                                  RUN_ON_CPU_HOST_INT(tb_flush_count));
+        }
     }
 }